glibc/sysdeps/ieee754/k_standardl.c
Joseph Myers 8b1bab5ffa Fix spurious "inexact" exceptions from __kernel_standard_l (bug 18245, bug 18583).
__kernel_standard_l converts long double arguments to double for use
in SVID "struct exception".  This has special-case handling for when
that conversion would overflow or underflow but the original long
double function wouldn't.  However, it turns out that "inexact"
exceptions can be spurious here as well, when the function is exactly
determined and __kernel_standard_l is being called for a domain error.
This patch fixes this by using feholdexcept / fesetenv to avoid
exceptions from the conversion, replacing the previous special-case
logic for overflow and underflow (this covers all functions using
__kernel_standard_l, not just those that actually need a change, since
there doesn't seem to be much point in restricting things just to the
functions that mustn't get "inexact" here).

Tested for x86_64 and x86.

	[BZ #18245]
	[BZ #18583]
	* sysdeps/ieee754/k_standardl.c: Include <fenv.h>.
	(__kernel_standard_l): Use feholdexcept and fesetenv around
	conversion to double instead of special-casing overflow and
	underflow.
	* math/libm-test.inc (fmod_test_data): Add more tests.
	(remainder_test_data): Likewise.
	(sqrt_test_data): Likewise.
2015-06-23 17:26:46 +00:00

108 lines
2.8 KiB
C

/* Implement __kernel_standard_l.
Copyright (C) 2012-2015 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>.
Parts based on k_standard.c from fdlibm: */
/* @(#)k_standard.c 5.1 93/09/24 */
/*
* ====================================================
* Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved.
*
* Developed at SunPro, a Sun Microsystems, Inc. business.
* Permission to use, copy, modify, and distribute this
* software is freely granted, provided that this notice
* is preserved.
* ====================================================
*/
#include <math.h>
#include <math_private.h>
#include <fenv.h>
#include <float.h>
#include <errno.h>
static double zero = 0.0;
/* Handle errors for a libm function as specified by TYPE (see
comments in k_standard.c for details), with arguments X and Y,
returning the appropriate return value for that function. */
long double
__kernel_standard_l (long double x, long double y, int type)
{
double dx, dy;
struct exception exc;
fenv_t env;
feholdexcept (&env);
dx = x;
dy = y;
math_force_eval (dx);
math_force_eval (dy);
fesetenv (&env);
switch (type)
{
case 221:
/* powl (x, y) overflow. */
exc.arg1 = dx;
exc.arg2 = dy;
exc.type = OVERFLOW;
exc.name = (char *) "powl";
if (_LIB_VERSION == _SVID_)
{
exc.retval = HUGE;
y *= 0.5;
if (x < zero && __rintl (y) != y)
exc.retval = -HUGE;
}
else
{
exc.retval = HUGE_VAL;
y *= 0.5;
if (x < zero && __rintl (y) != y)
exc.retval = -HUGE_VAL;
}
if (_LIB_VERSION == _POSIX_)
__set_errno (ERANGE);
else if (!matherr (&exc))
__set_errno (ERANGE);
return exc.retval;
case 222:
/* powl (x, y) underflow. */
exc.arg1 = dx;
exc.arg2 = dy;
exc.type = UNDERFLOW;
exc.name = (char *) "powl";
exc.retval = zero;
y *= 0.5;
if (x < zero && __rintl (y) != y)
exc.retval = -zero;
if (_LIB_VERSION == _POSIX_)
__set_errno (ERANGE);
else if (!matherr (&exc))
__set_errno (ERANGE);
return exc.retval;
default:
return __kernel_standard (dx, dy, type);
}
}