mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-22 04:50:07 +00:00
365624e2d2
The assumption behind the assert in activate_nodelete was wrong:
Inconsistency detected by ld.so: dl-open.c: 459: activate_nodelete:
Assertion `!imap->l_init_called || imap->l_type != lt_loaded' failed! (edit)
It can happen that an already-loaded object that is in the local
scope is promoted to NODELETE status, via binding to a unique
symbol.
Similarly, it is possible that such NODELETE promotion occurs to
an already-loaded object from the global scope. This is why the
loop in activate_nodelete has to cover all objects in the namespace
of the new object.
In do_lookup_unique, it could happen that the NODELETE status of
an already-loaded object was overwritten with a pending NODELETE
status. As a result, if dlopen fails, this could cause a loss of
the NODELETE status of the affected object, eventually resulting
in an incorrect unload.
Fixes commit f63b73814f ("Remove all
loaded objects if dlopen fails, ignoring NODELETE [BZ #20839]").
49 lines
1.5 KiB
C++
49 lines
1.5 KiB
C++
/* Second module for NODELETE test defining a unique symbol (with DT_NEEDED).
|
|
Copyright (C) 2019 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include "tst-dlopen-nodelete-reloc.h"
|
|
|
|
#include <stdbool.h>
|
|
#include <stdio.h>
|
|
#include <unistd.h>
|
|
|
|
/* Just a flag here, not used for NODELETE processing. */
|
|
bool may_finalize_mod13 = false;
|
|
|
|
extern template struct unique_symbol<12>;
|
|
|
|
/* Trigger the creation of a unique symbol reference. This should
|
|
cause tst-dlopen-nodelete-reloc-mod12.so to be marked as
|
|
NODELETE. */
|
|
int
|
|
global_function_mod13 (void)
|
|
{
|
|
return unique_symbol<12>::value;
|
|
}
|
|
|
|
static void __attribute__ ((destructor))
|
|
fini (void)
|
|
{
|
|
if (!may_finalize_mod13)
|
|
{
|
|
puts ("error: tst-dlopen-nodelete-reloc-mod13.so destructor"
|
|
" called too early");
|
|
_exit (1);
|
|
}
|
|
}
|