glibc/sysdeps/mach/hurd/closedir.c
Sergey Bugaev 9ec31e5727 hurd: Use __hurd_fail () instead of assigning errno
The __hurd_fail () inline function is the dedicated, idiomatic way of
reporting errors in the Hurd part of glibc. Not only is it more concise
than '{ errno = err; return -1; }', it is since commit
6639cc1002
"hurd: Mark error functions as __COLD" marked with the cold attribute,
telling the compiler that this codepath is unlikely to be executed.

In one case, use __hurd_dfail () over the plain __hurd_fail ().

Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
Message-Id: <20230520115531.3911877-1-bugaevc@gmail.com>
2023-05-20 18:14:01 +02:00

58 lines
1.6 KiB
C

/* Copyright (C) 1993-2023 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#include <errno.h>
#include <stddef.h>
#include <stdlib.h>
#include <dirent.h>
#include <unistd.h>
#include <hurd.h>
#include <hurd/fd.h>
#include "dirstream.h"
/* Close the directory stream DIRP.
Return 0 if successful, -1 if not. */
int
__closedir (DIR *dirp)
{
error_t err;
if (dirp == NULL)
return __hurd_fail (EINVAL);
__libc_lock_lock (dirp->__lock);
err = __vm_deallocate (__mach_task_self (),
(vm_address_t) dirp->__data, dirp->__allocation);
dirp->__data = NULL;
err = _hurd_fd_close (dirp->__fd);
if (err)
{
/* Unlock the DIR. A failing closedir can be repeated (and may fail
again, but shouldn't deadlock). */
__libc_lock_unlock (dirp->__lock);
return __hurd_fail (err);
}
/* Clean up the lock and free the structure. */
__libc_lock_fini (dirp->__lock);
free (dirp);
return 0;
}
weak_alias (__closedir, closedir)