glibc/nptl/pthread_setattr_default_np.c
Adhemerval Zanella 72b3c6eecd nptl: Change tst-typesizes to _Static_assert
Instead of rely on runtime check to assure correct pthread types
size a better strategy would use _Static_assert to trigger an error
on build time (and thus allowing to check to potentially ABI breakage
on cross-compiling make check).

This patch moves nptl/tst-typesizes.c to libpthread build time on
each specific initialization routine and also remove some runtime
redundant asserts for the same type sizes.

Checked on x86_64-linux-gnu and with a build check for all affected
ABIs (aarch64-linux-gnu, alpha-linux-gnu, arm-linux-gnueabihf,
hppa-linux-gnu, i686-linux-gnu, ia64-linux-gnu, m68k-linux-gnu,
microblaze-linux-gnu, mips64-linux-gnu, mips64-n32-linux-gnu,
mips-linux-gnu, powerpc64le-linux-gnu, powerpc-linux-gnu,
s390-linux-gnu, s390x-linux-gnu, sh4-linux-gnu, sparc64-linux-gnu,
sparcv9-linux-gnu, tilegx-linux-gnu, tilegx-linux-gnu-x32,
tilepro-linux-gnu, x86_64-linux-gnu, and x86_64-linux-x32).

	* nptl/pthreadP.h (ASSERT_TYPE_SIZE, ASSERT_PTHREAD_INTERNAL_SIZE):
	New macros.
	* nptl/pthread_attr_init.c (__pthread_mutex_init): Add build time
	checks for expected input type size.
	* nptl/pthread_barrier_init.c (__pthread_barrier_init): Likewise.
	* nptl/pthread_barrierattr_init.c (pthread_barrierattr_init):
	Likewise.
	* nptl/pthread_cond_init.c (__pthread_cond_init): Likewise.
	* nptl/pthread_condattr_init.c (__pthread_condattr_init): Likewise.
	* nptl/pthread_mutex_init.c (__pthread_mutex_init): Likewise.
	* nptl/pthread_mutexattr_init.c (__pthread_mutexattr_init): Likewise.
	* nptl/pthread_rwlock_init.c (__pthread_rwlock_init): Likewise.
	* nptl/pthread_rwlockattr_init.c (pthread_rwlockattr_init): Likewise.
	* nptl/sem_init.c (__new_sem_init, __old_sem_init): Likewise
	* nptl/pthread_attr_destroy.c (__pthread_attr_destroy): Remove
	superflous runtime assert check.
	* nptl/pthread_attr_getaffinity.c (__pthread_attr_getaffinity_new):
	Likewise.
	* nptl/pthread_attr_getdetachstate.c (__pthread_attr_getdetachstate):
	Likewise.
	* nptl/pthread_attr_getguardsize.c (pthread_attr_getguardsize):
	Likewise.
	* nptl/pthread_attr_getinheritsched.c (__pthread_attr_getinheritsched):
	Likewise.
	* nptl/pthread_attr_getschedparam.c (__pthread_attr_getschedparam):
	Likewise.
	* nptl/pthread_attr_getschedpolicy.c (__pthread_attr_getschedpolicy):
	Likewise.
	* nptl/pthread_attr_getscope.c (__pthread_attr_getscope): Likewise.
	* nptl/pthread_attr_getstack.c (__pthread_attr_getstack): Likewise.
	* nptl/pthread_attr_getstackaddr.c (__pthread_attr_getstackaddr):
	Likewise.
	* nptl/pthread_attr_getstacksize.c (__pthread_attr_getstacksize):
	Likewise.
	* nptl/pthread_attr_setaffinity.c (__pthread_attr_setaffinity_new):
	Likewise.
	* nptl/pthread_attr_setdetachstate.c (__pthread_attr_setdetachstate):
	Likewise.
	* nptl/pthread_attr_setguardsize.c (pthread_attr_setguardsize):
	Likewise.
	* nptl/pthread_attr_setinheritsched.c
	(__pthread_attr_setinheritsched): Likewise.
	* nptl/pthread_attr_setschedparam.c (__pthread_attr_setschedparam):
	Likewise.
	* nptl/pthread_attr_setschedpolicy.c (__pthread_attr_setschedpolicy):
	Likewise.
	* nptl/pthread_attr_setscope.c (__pthread_attr_setscope): Likewise.
	* nptl/pthread_attr_setstack.c (__pthread_attr_setstack,
	__old_pthread_attr_setstack): Likewise.
	* nptl/pthread_attr_setstackaddr.c (__pthread_attr_setstackaddr):
	Likewise.
	* nptl/pthread_attr_setstacksize.c (__pthread_attr_setstacksize):
	Likewise.
	* nptl/pthread_getattr_default_np.c (pthread_getattr_default_np):
	Likewise.
	* nptl/pthread_mutex_lock.c (__pthread_mutex_lock): Likewise.
	* nptl/pthread_setattr_default_np.c (pthread_setattr_default_np):
	Likewise.
	* nptl/tst-typesizes.c: Remove file.

Signed-off-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2017-11-07 09:48:37 -02:00

107 lines
3.1 KiB
C

/* Set the default attributes to be used by pthread_create in the process.
Copyright (C) 2013-2017 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
#include <errno.h>
#include <stdlib.h>
#include <pthreadP.h>
#include <string.h>
int
pthread_setattr_default_np (const pthread_attr_t *in)
{
const struct pthread_attr *real_in;
struct pthread_attr attrs;
int ret;
real_in = (struct pthread_attr *) in;
/* Catch invalid values. */
int policy = real_in->schedpolicy;
ret = check_sched_policy_attr (policy);
if (ret)
return ret;
const struct sched_param *param = &real_in->schedparam;
if (param->sched_priority > 0)
{
ret = check_sched_priority_attr (param->sched_priority, policy);
if (ret)
return ret;
}
/* stacksize == 0 is fine. It means that we don't change the current
value. */
if (real_in->stacksize != 0)
{
ret = check_stacksize_attr (real_in->stacksize);
if (ret)
return ret;
}
/* Having a default stack address is wrong. */
if (real_in->flags & ATTR_FLAG_STACKADDR)
return EINVAL;
attrs = *real_in;
/* Now take the lock because we start writing into
__default_pthread_attr. */
lll_lock (__default_pthread_attr_lock, LLL_PRIVATE);
/* Free the cpuset if the input is 0. Otherwise copy in the cpuset
contents. */
size_t cpusetsize = attrs.cpusetsize;
if (cpusetsize == 0)
{
free (__default_pthread_attr.cpuset);
__default_pthread_attr.cpuset = NULL;
}
else if (cpusetsize == __default_pthread_attr.cpusetsize)
{
attrs.cpuset = __default_pthread_attr.cpuset;
memcpy (attrs.cpuset, real_in->cpuset, cpusetsize);
}
else
{
/* This may look wrong at first sight, but it isn't. We're freeing
__default_pthread_attr.cpuset and allocating to attrs.cpuset because
we'll copy over all of attr to __default_pthread_attr later. */
cpu_set_t *newp = realloc (__default_pthread_attr.cpuset,
cpusetsize);
if (newp == NULL)
{
ret = ENOMEM;
goto out;
}
attrs.cpuset = newp;
memcpy (attrs.cpuset, real_in->cpuset, cpusetsize);
}
/* We don't want to accidentally set the default stacksize to zero. */
if (attrs.stacksize == 0)
attrs.stacksize = __default_pthread_attr.stacksize;
__default_pthread_attr = attrs;
out:
lll_unlock (__default_pthread_attr_lock, LLL_PRIVATE);
return ret;
}