mirror of
https://sourceware.org/git/glibc.git
synced 2024-09-19 16:10:01 +00:00
a3708cf6b0
This patch is split out of <https://sourceware.org/pipermail/libc-alpha/2022-December/144122.html>. atoi has undefined behavior on out-of-range input, which makes it problematic to use anywhere in glibc that might be processing input out-of-range for atoi but not specified to produce undefined behavior for the function calling atoi. Change some uses of atoi to call strtol instead; this avoids the undefined behavior, though there is no guarantee that the overflow handling of strtol is really right in those places either. This also serves to avoid localplt test failures given an installed header redirection for strtol (which means that the call from the inline atoi implementation doesn't end up at a hidden alias from libc_hidden_proto). Certainly, the use of atoi is questionable in argp-help.c (shared with gnulib, so shouldn't depend on glibc implementation details, and processing user-provided input), and maybe also in argp-parse.c (I'm not sure what that code in argp-parse.c is meant to be used for). I also changed inet/rexec.c and resolv/res_init.c similarly to use strtol to avoid such localplt failures, although given those files (in those versions) are only used in glibc it's not problematic for them to rely on the specific behavior of glibc's atoi on out-of-range input (in the absence of compiler optimizations based on the undefined behavior) in the same way it's problematic for gnulib code to do so. There may be other uses of atoi (or atol or atoll), in any of glibc's installed code, for which it would also be appropriate to avoid the undefined behavior on out-of-range input; this patch only fixes the specific cases needed to avoid localplt failures. Tested for x86_64. |
||
|---|---|---|
| .. | ||
| bits | ||
| argp-ba.c | ||
| argp-eexst.c | ||
| argp-fmtstream.c | ||
| argp-fmtstream.h | ||
| argp-fs-xinl.c | ||
| argp-help.c | ||
| argp-namefrob.h | ||
| argp-parse.c | ||
| argp-pv.c | ||
| argp-pvh.c | ||
| argp-test.c | ||
| argp-xinl.c | ||
| argp.h | ||
| bug-argp1.c | ||
| bug-argp2.c | ||
| Makefile | ||
| tst-argp1.c | ||
| tst-argp2.c | ||
| tst-ldbl-argp.c | ||
| Versions | ||