mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-26 23:10:06 +00:00
04da832e16
Linux/Alpha has two versions of several system call wrappers that take or return data of type "struct timeval" (possibly nested inside a larger structure). The GLIBC_2.0 version is a compat symbol that calls __NR_osf_foo or __NR_old_foo and uses a struct timeval with a 32-bit tv_sec field. The GLIBC_2.1 version is used for current code, calls __NR_foo, and uses a struct timeval with a 64-bit tv_sec field. This patch changes all of the compat symbols of this type to be wrappers around their GLIBC_2.1 counterparts; the compatibility system calls will no longer be used. It serves as a proposal for part of how we do the transition to 64-bit time_t on systems that currently use 32-bit time_t: * The patched glibc will NOT use system calls that involve 32-bit time_t to implement its compatibility symbols. This will make both our lives and the kernel maintainers' lives easier. The primary argument I've seen against it is that the kernel could warn about uses of the old system calls, helping people find old binaries that need to be recompiled. I think there are several other ways we could accomplish this, e.g. scripts to scan the filesystem for binaries with references to the old symbol versions, or issuing diagnostics ourselves. * The compat symbols do NOT report failure after the Y2038 deadline. An earlier revision of this patch had them return -1 and set errno to EOVERFLOW, but Adhemerval pointed out that many of them have already performed side effects at the point where we discover the overflow, so that would break more than it fixes. Also, we don't want people to be _checking_ for EOVERFLOW from these functions; we want them to recompile with 64-bit time_t. So it's not actually useful for them to report failure to the calling code. * What they do do, when they encounter overflow, is saturate the overflowed "struct timeval"(s): tv_sec is set to INT32_MAX and tv_nsec is set to 999999. That means time stops advancing for programs with 32-bit time_t when they reach the deadline. That's obviously going to break stuff, but I think wrapping around is probably going to break _more_ stuff. I'd be interested to hear arguments against, if anyone has one. The new header file tv32-compat.h is currently Alpha-specific but I mean for it to be reused to aid in writing wrappers for all affected architectures. I only put it in sysdeps/unix/sysv/linux/alpha for now because I haven't checked whether the various "foo32" structures it defines agree with the ABI for ports other than Linux/Alpha. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
71 lines
1.9 KiB
C
71 lines
1.9 KiB
C
/* Copyright (C) 1995-2019 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <errno.h>
|
|
#include <limits.h>
|
|
#include <sys/time.h>
|
|
#include <sys/timex.h>
|
|
|
|
#define MAX_SEC (INT_MAX / 1000000L - 2)
|
|
#define MIN_SEC (INT_MIN / 1000000L + 2)
|
|
|
|
int
|
|
__adjtime (const struct timeval *itv, struct timeval *otv)
|
|
{
|
|
struct timex tntx;
|
|
|
|
if (itv)
|
|
{
|
|
struct timeval tmp;
|
|
|
|
/* We will do some check here. */
|
|
tmp.tv_sec = itv->tv_sec + itv->tv_usec / 1000000L;
|
|
tmp.tv_usec = itv->tv_usec % 1000000L;
|
|
if (tmp.tv_sec > MAX_SEC || tmp.tv_sec < MIN_SEC)
|
|
return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL);
|
|
tntx.offset = tmp.tv_usec + tmp.tv_sec * 1000000L;
|
|
tntx.modes = ADJ_OFFSET_SINGLESHOT;
|
|
}
|
|
else
|
|
tntx.modes = ADJ_OFFSET_SS_READ;
|
|
|
|
if (__glibc_unlikely (__adjtimex (&tntx) < 0))
|
|
return -1;
|
|
|
|
if (otv)
|
|
{
|
|
if (tntx.offset < 0)
|
|
{
|
|
otv->tv_usec = -(-tntx.offset % 1000000);
|
|
otv->tv_sec = -(-tntx.offset / 1000000);
|
|
}
|
|
else
|
|
{
|
|
otv->tv_usec = tntx.offset % 1000000;
|
|
otv->tv_sec = tntx.offset / 1000000;
|
|
}
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
#ifdef VERSION_adjtime
|
|
weak_alias (__adjtime, __wadjtime);
|
|
default_symbol_version (__wadjtime, adjtime, VERSION_adjtime);
|
|
#else
|
|
weak_alias (__adjtime, adjtime)
|
|
#endif
|