mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-04 10:50:07 +00:00
a9acb7b39e
Currently glibc uses in_time_t_range to detects time_t overflow, and if it occurs fallbacks to 64 bit syscall version. The function name is confusing because internally time_t might be either 32 bits or 64 bits (depending on __TIMESIZE). This patch refactors the in_time_t_range by replacing it with in_int32_t_range for the case to check if the 64 bit time_t syscall should be used. The in_time_t range is used to detect overflow of the syscall return value. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
94 lines
2.9 KiB
C
94 lines
2.9 KiB
C
/* Copyright (C) 2006-2022 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <sys/select.h>
|
|
#include <sysdep-cancel.h>
|
|
|
|
static int
|
|
pselect64_syscall (int nfds, fd_set *readfds, fd_set *writefds,
|
|
fd_set *exceptfds, const struct __timespec64 *timeout,
|
|
const sigset_t *sigmask)
|
|
{
|
|
#ifndef __NR_pselect6_time64
|
|
# define __NR_pselect6_time64 __NR_pselect6
|
|
#endif
|
|
/* NB: This is required by ARGIFY used in x32 internal_syscallN. */
|
|
__syscall_ulong_t data[2] =
|
|
{
|
|
(uintptr_t) sigmask, __NSIG_BYTES
|
|
};
|
|
return SYSCALL_CANCEL (pselect6_time64, nfds, readfds, writefds, exceptfds,
|
|
timeout, data);
|
|
}
|
|
|
|
int
|
|
__pselect64 (int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds,
|
|
const struct __timespec64 *timeout, const sigset_t *sigmask)
|
|
{
|
|
/* The Linux kernel can in some situations update the timeout value.
|
|
We do not want that so use a local variable. */
|
|
struct __timespec64 tval;
|
|
if (timeout != NULL)
|
|
{
|
|
tval = *timeout;
|
|
timeout = &tval;
|
|
}
|
|
|
|
/* Note: the system call expects 7 values but on most architectures
|
|
we can only pass in 6 directly. If there is an architecture with
|
|
support for more parameters a new version of this file needs to
|
|
be created. */
|
|
#ifdef __ASSUME_TIME64_SYSCALLS
|
|
return pselect64_syscall (nfds, readfds, writefds, exceptfds, timeout,
|
|
sigmask);
|
|
#else
|
|
bool need_time64 = timeout != NULL && !in_int32_t_range (timeout->tv_sec);
|
|
if (need_time64)
|
|
{
|
|
int r = pselect64_syscall (nfds, readfds, writefds, exceptfds, timeout,
|
|
sigmask);
|
|
if (r == 0 || errno != ENOSYS)
|
|
return r;
|
|
__set_errno (EOVERFLOW);
|
|
return -1;
|
|
}
|
|
|
|
return __pselect32 (nfds, readfds, writefds, exceptfds, timeout, sigmask);
|
|
#endif
|
|
}
|
|
|
|
#if __TIMESIZE != 64
|
|
libc_hidden_def (__pselect64)
|
|
|
|
int
|
|
__pselect (int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds,
|
|
const struct timespec *timeout, const sigset_t *sigmask)
|
|
{
|
|
struct __timespec64 ts64, *pts64 = NULL;
|
|
if (timeout != NULL)
|
|
{
|
|
ts64 = valid_timespec_to_timespec64 (*timeout);
|
|
pts64 = &ts64;
|
|
}
|
|
return __pselect64 (nfds, readfds, writefds, exceptfds, pts64, sigmask);
|
|
}
|
|
#endif
|
|
|
|
#ifndef __pselect
|
|
weak_alias (__pselect, pselect)
|
|
#endif
|