mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-22 04:50:07 +00:00
404656009b
Some Linux interfaces never restart after being interrupted by a signal handler, regardless of the use of SA_RESTART [1]. It means that for pthread cancellation, if the target thread disables cancellation with pthread_setcancelstate and calls such interfaces (like poll or select), it should not see spurious EINTR failures due the internal SIGCANCEL. However recent changes made pthread_cancel to always sent the internal signal, regardless of the target thread cancellation status or type. To fix it, the previous semantic is restored, where the cancel signal is only sent if the target thread has cancelation enabled in asynchronous mode. The cancel state and cancel type is moved back to cancelhandling and atomic operation are used to synchronize between threads. The patch essentially revert the following commits:8c1c0aae20nptl: Move cancel type out of cancelhandling2b51742531nptl: Move cancel state out of cancelhandling26cfbb7162nptl: Remove CANCELING_BITMASK However I changed the atomic operation to follow the internal C11 semantic and removed the MACRO usage, it simplifies a bit the resulting code (and removes another usage of the old atomic macros). Checked on x86_64-linux-gnu, i686-linux-gnu, aarch64-linux-gnu, and powerpc64-linux-gnu. [1] https://man7.org/linux/man-pages/man7/signal.7.html Reviewed-by: Florian Weimer <fweimer@redhat.com> Tested-by: Aurelien Jarno <aurelien@aurel32.net>
61 lines
1.7 KiB
C
61 lines
1.7 KiB
C
/* Copyright (C) 2002-2022 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <errno.h>
|
|
#include "pthreadP.h"
|
|
#include <atomic.h>
|
|
#include <libc-lockP.h>
|
|
|
|
int
|
|
__pthread_setcancelstate (int state, int *oldstate)
|
|
{
|
|
volatile struct pthread *self;
|
|
|
|
if (state < PTHREAD_CANCEL_ENABLE || state > PTHREAD_CANCEL_DISABLE)
|
|
return EINVAL;
|
|
|
|
self = THREAD_SELF;
|
|
|
|
int oldval = atomic_load_relaxed (&self->cancelhandling);
|
|
while (1)
|
|
{
|
|
int newval = (state == PTHREAD_CANCEL_DISABLE
|
|
? oldval | CANCELSTATE_BITMASK
|
|
: oldval & ~CANCELSTATE_BITMASK);
|
|
|
|
if (oldstate != NULL)
|
|
*oldstate = ((oldval & CANCELSTATE_BITMASK)
|
|
? PTHREAD_CANCEL_DISABLE : PTHREAD_CANCEL_ENABLE);
|
|
|
|
if (oldval == newval)
|
|
break;
|
|
|
|
if (atomic_compare_exchange_weak_acquire (&self->cancelhandling,
|
|
&oldval, newval))
|
|
{
|
|
if (cancel_enabled_and_canceled_and_async (newval))
|
|
__do_cancel ();
|
|
|
|
break;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
libc_hidden_def (__pthread_setcancelstate)
|
|
weak_alias (__pthread_setcancelstate, pthread_setcancelstate)
|