mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-26 06:50:07 +00:00
3d7229c250
GCC 7 has a -Walloc-size-larger-than= warning for allocations of half the address space or more. This causes errors building glibc tests that deliberately test failure of very large allocations. This patch arranges for this warning to be ignored around the problematic function calls. Tested compilation for aarch64 (GCC mainline) with build-many-glibcs.py; did execution testing for x86_64 (GCC 5). * malloc/tst-malloc.c: Include <libc-internal.h>. (do_test): Disable -Walloc-size-larger-than= around tests of malloc with negative sizes. * malloc/tst-mcheck.c: Include <libc-internal.h>. (do_test): Disable -Walloc-size-larger-than= around tests of malloc and realloc with negative sizes. * malloc/tst-realloc.c: Include <libc-internal.h>. (do_test): Disable -Walloc-size-larger-than= around tests of realloc with negative sizes.
162 lines
3.7 KiB
C
162 lines
3.7 KiB
C
/* Copyright (C) 2013-2017 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <errno.h>
|
|
#include <malloc.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <libc-internal.h>
|
|
|
|
static int errors = 0;
|
|
|
|
static void
|
|
merror (const char *msg)
|
|
{
|
|
++errors;
|
|
printf ("Error: %s\n", msg);
|
|
}
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
void *p;
|
|
unsigned char *c;
|
|
int save, i, ok;
|
|
|
|
errno = 0;
|
|
|
|
/* realloc (NULL, ...) behaves similarly to malloc (C89). */
|
|
DIAG_PUSH_NEEDS_COMMENT;
|
|
#if __GNUC_PREREQ (7, 0)
|
|
/* GCC 7 warns about too-large allocations; here we want to test
|
|
that they fail. */
|
|
DIAG_IGNORE_NEEDS_COMMENT (7, "-Walloc-size-larger-than=");
|
|
#endif
|
|
p = realloc (NULL, -1);
|
|
DIAG_POP_NEEDS_COMMENT;
|
|
save = errno;
|
|
|
|
if (p != NULL)
|
|
merror ("realloc (NULL, -1) succeeded.");
|
|
|
|
/* errno should be set to ENOMEM on failure (POSIX). */
|
|
if (p == NULL && save != ENOMEM)
|
|
merror ("errno is not set correctly");
|
|
|
|
errno = 0;
|
|
|
|
/* realloc (NULL, ...) behaves similarly to malloc (C89). */
|
|
p = realloc (NULL, 10);
|
|
save = errno;
|
|
|
|
if (p == NULL)
|
|
merror ("realloc (NULL, 10) failed.");
|
|
|
|
/* errno should be clear on success (POSIX). */
|
|
if (p != NULL && save != 0)
|
|
merror ("errno is set but should not be");
|
|
|
|
free (p);
|
|
|
|
p = calloc (20, 1);
|
|
if (p == NULL)
|
|
merror ("calloc (20, 1) failed.");
|
|
|
|
/* Check increasing size preserves contents (C89). */
|
|
p = realloc (p, 200);
|
|
if (p == NULL)
|
|
merror ("realloc (p, 200) failed.");
|
|
|
|
c = p;
|
|
ok = 1;
|
|
|
|
for (i = 0; i < 20; i++)
|
|
{
|
|
if (c[i] != 0)
|
|
ok = 0;
|
|
}
|
|
|
|
if (ok == 0)
|
|
merror ("first 20 bytes were not cleared");
|
|
|
|
free (p);
|
|
|
|
p = realloc (NULL, 100);
|
|
if (p == NULL)
|
|
merror ("realloc (NULL, 100) failed.");
|
|
|
|
memset (p, 0xff, 100);
|
|
|
|
/* Check decreasing size preserves contents (C89). */
|
|
p = realloc (p, 16);
|
|
if (p == NULL)
|
|
merror ("realloc (p, 16) failed.");
|
|
|
|
c = p;
|
|
ok = 1;
|
|
|
|
for (i = 0; i < 16; i++)
|
|
{
|
|
if (c[i] != 0xff)
|
|
ok = 0;
|
|
}
|
|
|
|
if (ok == 0)
|
|
merror ("first 16 bytes were not correct");
|
|
|
|
/* Check failed realloc leaves original untouched (C89). */
|
|
DIAG_PUSH_NEEDS_COMMENT;
|
|
#if __GNUC_PREREQ (7, 0)
|
|
/* GCC 7 warns about too-large allocations; here we want to test
|
|
that they fail. */
|
|
DIAG_IGNORE_NEEDS_COMMENT (7, "-Walloc-size-larger-than=");
|
|
#endif
|
|
c = realloc (p, -1);
|
|
DIAG_POP_NEEDS_COMMENT;
|
|
if (c != NULL)
|
|
merror ("realloc (p, -1) succeeded.");
|
|
|
|
c = p;
|
|
ok = 1;
|
|
|
|
for (i = 0; i < 16; i++)
|
|
{
|
|
if (c[i] != 0xff)
|
|
ok = 0;
|
|
}
|
|
|
|
if (ok == 0)
|
|
merror ("first 16 bytes were not correct after failed realloc");
|
|
|
|
/* realloc (p, 0) frees p (C89) and returns NULL (glibc). */
|
|
p = realloc (p, 0);
|
|
if (p != NULL)
|
|
merror ("realloc (p, 0) returned non-NULL.");
|
|
|
|
/* realloc (NULL, 0) acts like malloc (0) (glibc). */
|
|
p = realloc (NULL, 0);
|
|
if (p == NULL)
|
|
merror ("realloc (NULL, 0) returned NULL.");
|
|
|
|
free (p);
|
|
|
|
return errors != 0;
|
|
}
|
|
|
|
#define TEST_FUNCTION do_test ()
|
|
#include "../test-skeleton.c"
|