mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-29 05:51:10 +00:00
ea41469b7a
On ARM, where profil_counter is not static, it is brought in by references to various standard functions, as noted in <https://sourceware.org/ml/libc-alpha/2014-11/msg00890.html>, although it is not a standard function itself. I don't know if this also causes test failures on SPARC, although I see no reason for it not to do so. This patch fixes this namespace issue. profil_counter is renamed to __profil_counter and made a weak alias on ARM and SPARC. Because of the uses in profil.c / sprofil.c it seems simplest to make the rename globally, including on the other architectures for which profil_counter was static and so the change is of no substance. The variant names profil_counter_* used in sprofil.c are also renamed to start with __ so that undesired function names do not get exported in static libc. As I noted in bug 17726, profil_counter should probably be a compat symbol on ARM and SPARC, so it wouldn't exist at all in static libc even as a weak alias. Since defining a compat symbol still requires an internal name as a target of an alias, this patch still seems reasonable as an intermediate step towards that goal: it wouldn't be possible for the function simply to be static profil_counter on ARM and SPARC with profil_counter also being the exported compat symbol name, so profil.c / sprofil.c would still need to be prepared to call the function under another name (here, __profil_counter). Tested for x86_64 (testsuite, and that stripped installed shared libraries are unchanged by the patch) and ARM (ABI and linknamespace tests - this patch reduces the number of linknamespace failures I see on ARM from 227 to 5, the residue being math.h failures for fe* functions and for j0l/j1n/jnl/y0l/y1l/ynl aliases). 2014-12-17 Joseph Myers <joseph@codesourcery.com> [BZ #17725] * sysdeps/generic/profil-counter.h (profil_counter): Rename to __profil_counter. * sysdeps/unix/sysv/linux/hppa/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/i386/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/ia64/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/sh/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/tile/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/x86_64/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/arm/profil-counter.h (profil_counter): Likewise. [!__profil_counter] (profil_counter): Define as weak alias of __profil_counter. * sysdeps/unix/sysv/linux/sparc/sparc32/profil-counter.h (profil_counter): Rename to __profil_counter. [!__profil_counter] (profil_counter): Define as weak alias of __profil_counter. * sysdeps/unix/sysv/linux/sparc/sparc64/profil-counter.h (profil_counter): Rename to __profil_counter. [!__profil_counter] (profil_counter): Define as weak alias of __profil_counter. * sysdeps/posix/profil.c: Update comment referring to profil_counter. (__profil): Use __profil_counter instead of profil_counter. * sysdeps/posix/sprofil.c (profil_counter): Rename to __profil_counter. Use __profil_counter_ushort and __profil_counter_uint in definitions. (__sprofil): Use __profil_counter_uint and __profil_counter_ushort instead of profil_counter_uint and profil_counter_ushort. |
||
|---|---|---|
| .. | ||
| alarm.c | ||
| clock_getres.c | ||
| clock.c | ||
| closedir.c | ||
| ctermid.c | ||
| cuserid.c | ||
| dirfd.c | ||
| dirstream.h | ||
| dup2.c | ||
| dup.c | ||
| euidaccess.c | ||
| fdopendir.c | ||
| flock.c | ||
| fpathconf.c | ||
| gai_strerror-strs.h | ||
| gai_strerror.c | ||
| getaddrinfo.c | ||
| getcwd.c | ||
| getdtsz.c | ||
| gethostname.c | ||
| getpagesize.c | ||
| gettimeofday.c | ||
| isatty.c | ||
| isfdtype.c | ||
| killpg.c | ||
| libc_fatal.c | ||
| Makefile | ||
| mkfifo.c | ||
| mkfifoat.c | ||
| nice.c | ||
| open64.c | ||
| opendir.c | ||
| pathconf.c | ||
| pause.c | ||
| posix_fallocate64.c | ||
| posix_fallocate.c | ||
| pread64.c | ||
| pread.c | ||
| preadv64.c | ||
| preadv.c | ||
| profil.c | ||
| pwrite64.c | ||
| pwrite.c | ||
| pwritev64.c | ||
| pwritev.c | ||
| raise.c | ||
| readdir_r.c | ||
| readdir.c | ||
| readv.c | ||
| remove.c | ||
| rename.c | ||
| rewinddir.c | ||
| seekdir.c | ||
| shm_open.c | ||
| shm_unlink.c | ||
| shm-directory.c | ||
| shm-directory.h | ||
| sigblock.c | ||
| sigignore.c | ||
| sigintr.c | ||
| signal.c | ||
| sigpause.c | ||
| sigset.c | ||
| sigsetmask.c | ||
| sigsuspend.c | ||
| sigwait.c | ||
| sleep.c | ||
| spawni.c | ||
| sprofil.c | ||
| sysconf.c | ||
| system.c | ||
| sysv_signal.c | ||
| telldir.c | ||
| tempname.c | ||
| time.c | ||
| timespec_get.c | ||
| truncate.c | ||
| ttyname_r.c | ||
| ttyname.c | ||
| ulimit.c | ||
| utime.c | ||
| utimes.c | ||
| wait3.c | ||
| wait.c | ||
| waitid.c | ||
| writev.c | ||