glibc/stdio-common
Joseph Myers db6c4935fa Fix memmove call in vfprintf-internal.c:group_number
A recent GCC mainline change introduces errors of the form:

vfprintf-internal.c: In function 'group_number':
vfprintf-internal.c:2093:15: error: 'memmove' specified bound between 9223372036854775808 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
 2093 |               memmove (w, s, (front_ptr -s) * sizeof (CHAR_T));
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is a genuine bug in the glibc code: s > front_ptr is always true
at this point in the code, and the intent is clearly for the
subtraction to be the other way round.  The other arguments to the
memmove call here also appear to be wrong; w and s point just *after*
the destination and source for copying the rest of the number, so the
size needs to be subtracted to get appropriate pointers for the
copying.  Adjust the memmove call to conform to the apparent intent of
the code, so fixing the -Wstringop-overflow error.

Now, if the original code were ever executed, a buffer overrun would
result.  However, I believe this code (introduced in commit
edc1686af0, "vfprintf: Reuse work_buffer
in group_number", so in glibc 2.26) is unreachable in prior glibc
releases (so there is no need for a bug in Bugzilla, no need to
consider any backports unless someone wants to build older glibc
releases with GCC 12 and no possibility of this buffer overrun
resulting in a security issue).

work_buffer is 1000 bytes / 250 wide characters.  This case is only
reachable if an initial part of the number, plus a grouped copy of the
rest of the number, fail to fit in that space; that is, if the grouped
number fails to fit in the space.  In the wide character case,
grouping is always one wide character, so even with a locale (of which
there aren't any in glibc) grouping every digit, a number would need
to occupy at least 125 wide characters to overflow, and a 64-bit
integer occupies at most 23 characters in octal including a leading 0.
In the narrow character case, the multibyte encoding of the grouping
separator would need to be at least 42 bytes to overflow, again
supposing grouping every digit, but MB_LEN_MAX is 16.  So even if we
admit the case of artificially constructed locales not shipped with
glibc, given that such a locale would need to use one of the character
sets supported by glibc, this code cannot be reached at present.  (And
POSIX only actually specifies the ' flag for grouping for decimal
output, though glibc acts on it for other bases as well.)

With binary output (if you consider use of grouping there to be
valid), you'd need a 15-byte multibyte character for overflow; I don't
know if any supported character set has such a character (if, again,
we admit constructed locales using grouping every digit and a grouping
separator chosen to have a multibyte encoding as long as possible, as
well as accepting use of grouping with binary), but given that we have
this code at all (clearly it's not *correct*, or in accordance with
the principle of avoiding arbitrary limits, to skip grouping on
running out of internal space like that), I don't think it should need
any further changes for binary printf support to go in.

On the other hand, support for large sizes of _BitInt in printf (see
the N2858 proposal) *would* require something to be done about such
arbitrary limits (presumably using dynamic allocation in printf again,
for sufficiently large _BitInt arguments only - currently only
floating-point uses dynamic allocation, and, as previously discussed,
that could actually be replaced by bounded allocation given smarter
code).

Tested with build-many-glibcs.py for aarch64-linux-gnu (GCC mainline).
Also tested natively for x86_64.
2021-11-08 19:11:51 +00:00
..
bits Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
_i18n_number.h Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
_itoa.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
_itowa.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
_itowa.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
asprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
bug1.c Update. 1999-07-17 23:56:47 +00:00
bug1.input * Makefile (subdirs): Replace stdio with stdio-common and $(stdio). 1995-10-17 00:41:39 +00:00
bug2.c Update. 1997-05-26 23:01:17 +00:00
bug3.c Fix hardcoded /tmp paths in testing (bug 13888). 2018-06-26 21:48:48 +00:00
bug4.c Fix hardcoded /tmp paths in testing (bug 13888). 2018-06-26 21:48:48 +00:00
bug5.c Fix hardcoded /tmp paths in testing (bug 13888). 2018-06-26 21:48:48 +00:00
bug6.c Update. 1997-05-26 23:01:17 +00:00
bug6.input * Makefile (subdirs): Replace stdio with stdio-common and $(stdio). 1995-10-17 00:41:39 +00:00
bug7.c Avoid insecure usage of tmpnam in tests. 2018-07-18 21:04:12 +00:00
bug8.c update from main archive 961008 1996-10-08 23:39:20 +00:00
bug9.c update from main archive 961008 1996-10-08 23:39:20 +00:00
bug10.c update from main archive 970218 1997-02-19 04:43:53 +00:00
bug11.c update from main archive 961008 1996-10-08 23:39:20 +00:00
bug12.c Update. 1998-06-15 14:55:03 +00:00
bug13.c Update. 2000-07-29 06:45:51 +00:00
bug14.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
bug16.c stdio-common: Use array_length and array_end macros 2017-11-02 12:45:20 +01:00
bug17.c [BZ #3902] 2007-01-22 16:18:03 +00:00
bug18.c * libio/wstrops.c (_IO_wstr_underflow): Clear errno before 2007-07-07 21:38:43 +00:00
bug18a.c * libio/wstrops.c (_IO_wstr_underflow): Clear errno before 2007-07-07 21:38:43 +00:00
bug19.c * stdio-common/vfscanf.c (_IO_vfscanf): Add additional test for EOF 2007-07-08 04:41:34 +00:00
bug19a.c * stdio-common/vfscanf.c (_IO_vfscanf): Add additional test for EOF 2007-07-08 04:41:34 +00:00
bug20.c * stdio-common/Makefile (tests): Add bug20. 2007-10-28 16:45:27 +00:00
bug21.c Use C99-compliant scanf under _GNU_SOURCE with modern compilers. 2019-01-03 11:12:39 -05:00
bug22.c Remove most vfprintf width/precision-dependent allocations (bug 14231, bug 26211). 2020-07-07 14:54:12 +00:00
bug23-2.c CVE-2012-3406: Stack overflow in vfprintf [BZ #16617] 2014-12-15 10:09:33 +01:00
bug23-3.c CVE-2012-3406: Stack overflow in vfprintf [BZ #16617] 2014-12-15 10:09:33 +01:00
bug23-4.c CVE-2012-3406: Stack overflow in vfprintf [BZ #16617] 2014-12-15 10:09:33 +01:00
bug23.c Fix allocation when handling positional parameters in printf. 2011-02-20 07:59:49 -05:00
bug24.c Add test for BZ 13114 2011-08-20 09:22:16 -04:00
bug25.c Another round of inclusion fixes for _ISOMAC testsuite. 2017-03-22 08:44:32 -04:00
bug26.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
bug-vfprintf-nargs.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
ctermid.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
cuserid.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Depend Update. 2000-07-29 06:45:51 +00:00
dprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
errlist-compat.c signal: Move sys_errlist to a compat symbol 2020-07-07 14:10:58 -03:00
errlist.c hurd: Fix errlist error mapping 2021-08-23 19:06:49 +02:00
errnobug.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
flockfile.c linux: Move flockfile/_IO_flockfile into libc 2021-05-10 23:35:44 -03:00
fprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
fscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
ftrylockfile.c linux: Move ftrylockfile/_IO_ftrylockfile into libc 2021-05-10 23:35:44 -03:00
funlockfile.c linux: Move funlockfile/_IO_funlockfile into libc 2021-05-10 23:35:44 -03:00
fxprintf.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
gentempfd.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
getline.c libio: Replace internal _IO_getdelim symbol with __getdelim 2021-07-07 18:33:52 +02:00
getw.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
iovfscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_fscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_scanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_sscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_vfscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_vscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_vsscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
itoa-digits.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
itoa-udigits.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
itowa-digits.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Makefile Move malloc hooks into a compat DSO 2021-07-22 18:37:59 +05:30
perror.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
printf_fp.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
printf_fphex.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
printf_size.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
printf-parse.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
printf-parsemb.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
printf-parsewc.c Update. 2003-06-11 23:22:36 +00:00
printf-prs.c stdio-common/printf-prs.c: Reword comment 2021-03-31 17:20:18 -03:00
printf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
printf.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
psiginfo-data.h Fix typos. 2013-10-12 14:47:50 +02:00
psiginfo-define.h * locale/langinfo.h: nl_langinfo_l is in POSIX 2008. 2009-02-26 06:18:24 +00:00
psiginfo.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
psignal.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
putw.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
reg-modifier.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
reg-printf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
reg-type.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
remove.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
rename.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
renameat2.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
renameat.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
scanf1.c update from main archive 970121 1997-01-23 04:24:20 +00:00
scanf2.c update from main archive 961008 1996-10-08 23:39:20 +00:00
scanf3.c update from main archive 970121 1997-01-23 04:24:20 +00:00
scanf4.c Split DIAG_* macros to new header libc-diag.h. 2017-02-25 09:59:46 -05:00
scanf5.c * tst-trans.c: Include <stdlib.h> and <string.h>. 2000-06-21 12:39:22 +00:00
scanf7.c Split DIAG_* macros to new header libc-diag.h. 2017-02-25 09:59:46 -05:00
scanf8.c update from main archive 961008 1996-10-08 23:39:20 +00:00
scanf9.c Update. 2000-12-15 16:03:57 +00:00
scanf10.c update from main archive 970121 1997-01-23 04:24:20 +00:00
scanf11.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
scanf12.c Update. 2000-07-22 07:26:13 +00:00
scanf12.input Update. 1999-02-07 00:06:12 +00:00
scanf13.c Avoid warning in scanf test. 2009-10-30 09:23:24 -07:00
scanf14.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
scanf14a.c Fix stdio-common tests for GCC 12 -Waddress 2021-10-04 19:10:43 +00:00
scanf15.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
scanf16.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
scanf16a.c Fix stdio-common tests for GCC 12 -Waddress 2021-10-04 19:10:43 +00:00
scanf17.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
scanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
siglist.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
snprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
sprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
sscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
stdio_ext.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
stdio_lim.h.in Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tempnam.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tempname.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
temptest.c * malloc/memusagestat.c (main): Use return instead of exit to 2000-12-31 10:52:32 +00:00
test_rdwr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-fseek.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-fwrite.c Modify several tests to use test-skeleton.c 2015-08-06 02:59:04 -04:00
test-popen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strerr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-vfprintf.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
tfformat.c stdio-common: Add a few double formatting tests [BZ #27245] 2021-02-03 16:47:47 -03:00
tiformat.c Update. 2000-06-17 19:22:43 +00:00
tllformat.c Update. 1999-02-14 20:03:55 +00:00
tmpfile64.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tmpfile.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tmpnam_r.c Annotate additional APIs with GCC attribute access. 2021-05-06 11:01:05 -06:00
tmpnam.c Annotate additional APIs with GCC attribute access. 2021-05-06 11:01:05 -06:00
tst-bz11319-fortify2.c Use PRINTF_FORTIFY instead of _IO_FLAGS2_FORTIFY (bug 11319) 2018-12-05 18:15:43 -02:00
tst-bz11319.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cookie.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-errno-manual.py Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fdopen.c Avoid insecure usage of tmpnam in tests. 2018-07-18 21:04:12 +00:00
tst-ferror.c Modify several tests to use test-skeleton.c 2015-08-06 02:59:04 -04:00
tst-ferror.input Update. 1997-04-08 23:42:08 +00:00
tst-fgets.c Prefer https for Sourceware links 2017-11-16 11:49:26 +05:30
tst-fileno.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fmemopen2.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fmemopen3.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fmemopen4.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fmemopen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fphex-wide.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
tst-fphex.c stdio-common: Use array_length and array_end macros 2017-11-02 12:45:20 +01:00
tst-fseek.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
tst-fwrite.c Prefer https for Sourceware links 2017-11-16 11:49:26 +05:30
tst-gets.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
tst-gets.input Update. 2001-02-15 19:57:43 +00:00
tst-grouping.c Fix grouping when rounding increases number of integer digits. 2011-01-12 20:37:51 -05:00
tst-long-dbl-fphex.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
tst-obprintf.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-perror.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
tst-popen2.c * libio/iopopen.c (_IO_new_proc_open): Don't close child_std_end 2007-07-19 17:03:08 +00:00
tst-popen.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
tst-printf-bz18872.sh Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printf-bz25691.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printf-fp-free.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printf-fp-leak.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printf-round.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printf.c printf: Add smoke tests for long double 2021-02-05 09:52:52 +05:30
tst-printf.sh printf: Add smoke tests for long double 2021-02-05 09:52:52 +05:30
tst-printfsz-islongdouble.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printfsz-islongdouble.sh Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printfsz.c Split DIAG_* macros to new header libc-diag.h. 2017-02-25 09:59:46 -05:00
tst-put-error.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-renameat2.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-rndseek.c Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
tst-scanf-round.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-setvbuf1.c * stdio-common/Makefile: Add rules to build and run tst-setvbuf1. 2008-07-08 16:32:55 +00:00
tst-setvbuf1.expect * stdio-common/Makefile: Add rules to build and run tst-setvbuf1. 2008-07-08 16:32:55 +00:00
tst-sprintf2.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-sprintf3.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-sprintf.c Split DIAG_* macros to new header libc-diag.h. 2017-02-25 09:59:46 -05:00
tst-sscanf.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
tst-swprintf.c stdio-common: Use array_length and array_end macros 2017-11-02 12:45:20 +01:00
tst-swscanf.c * stdio-common/Makefile (tests): Add tst-swscanf. 2007-02-18 09:21:24 +00:00
tst-tmpnam.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-unbputc.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-unbputc.sh Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-ungetc.c Avoid insecure usage of tmpnam in tests. 2018-07-18 21:04:12 +00:00
tst-unlockedio.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
tst-vfprintf-mbs-prec.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-vfprintf-user-type.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-vfprintf-width-prec-alloc.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-vfprintf-width-prec.c Fix stdio-common tests for GCC 12 -Waddress 2021-10-04 19:10:43 +00:00
tst-wc-printf.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tstdiomisc.c stdio-common: Use array_length and array_end macros 2017-11-02 12:45:20 +01:00
tstgetln.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tstgetln.input * Makefile (subdirs): Replace stdio with stdio-common and $(stdio). 1995-10-17 00:41:39 +00:00
tstscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tstscanf.input * Makefile (subdirs): Replace stdio with stdio-common and $(stdio). 1995-10-17 00:41:39 +00:00
Versions Add __vfscanf_internal and __vfwscanf_internal with flags arguments. 2018-12-05 18:15:42 -02:00
vfprintf-internal.c Fix memmove call in vfprintf-internal.c:group_number 2021-11-08 19:11:51 +00:00
vfprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
vfscanf-internal.c stdio: fix vfscanf with matches longer than INT_MAX (bug 27650) 2021-05-03 10:34:11 +02:00
vfscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
vfwprintf-internal.c Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
vfwprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
vfwscanf-internal.c Add __vfscanf_internal and __vfwscanf_internal with flags arguments. 2018-12-05 18:15:42 -02:00
vfwscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
vprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
xbug.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00