mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-25 14:30:06 +00:00
bb4acb522c
fnmatch brings in references to towlower (and thereby towupper), which isn't in all the standards that contain fnmatch, resulting in linknamespace test failures. (This is contrary to glibc conventions, rather than a standards conformance issue, because of the to* reservation.) This patch fixes this in the usual way, making those functions into weak aliases. Tested for x86_64 and x86 (testsuite, and that disassembly of installed shared libraries is unchanged by the patch). This is on top of <https://sourceware.org/ml/libc-alpha/2015-06/msg00019.html>, but the two patches should be independent. (The __attribute_pure__ on the declarations in include/wctype.h comes from GCC's built-in attributes for towlower and towupper, and is needed to get the same code generation for fnmatch before and after the patch. It seems likely there are cases where the declaration of __foo in the internal headers is missing attributes from foo in the public headers, built-in to GCC or both, but I don't know a good way to detect such missing attributes.) [BZ #18469] * wctype/wcfuncs.c (towlower): Rename to __towlower and define as weak alias of __towlower. Use libc_hidden_weak. (towupper): Rename to __towupper and define as weak alias of __towupper. Use libc_hidden_weak. * include/wctype.h (__towlower): Declare. Use libc_hidden_proto. (__towupper): Likewise. * posix/fnmatch.c [HANDLE_MULTIBYTE && _LIBC] (FOLD): Use __towlower instead of towlower. |
||
|---|---|---|
| .. | ||
| bug-wctypeh.c | ||
| iswctype_l.c | ||
| iswctype.c | ||
| Makefile | ||
| test_wcfuncs.c | ||
| test_wctype.c | ||
| towctrans_l.c | ||
| towctrans.c | ||
| Versions | ||
| wcfuncs_l.c | ||
| wcfuncs.c | ||
| wchar-lookup.h | ||
| wctrans_l.c | ||
| wctrans.c | ||
| wctype_l.c | ||
| wctype.c | ||
| wctype.h | ||