AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-12-26 04:31:03 +00:00
Code Issues Packages Projects Releases Wiki Activity
bc10e22c90
glibc/misc
History
Joseph Myers 32db86d558 Add fall-through comments. 
This patch adds fall-through comments in some cases where -Wextra
produces implicit-fallthrough warnings.

The patch is non-exhaustive.  Apart from architecture-specific code
for non-x86_64 architectures, it does not change sunrpc/xdr.c (legacy
code, probably should have such changes, but left to be dealt with
separately), or places that already had comments about the
fall-through but not matching the form expected by
-Wimplicit-fallthrough=3 (the default level with -Wextra; my
inclination is to adjust those comments to match rather than
downgrading to -Wimplicit-fallthrough=1 to allow any comment), or one
place where I thought the implicit fallthrough was not correct and so
should be handled separately as a bug fix.  I think the key thing to
consider in review of this patch is whether the fall-through is indeed
intended and correct in each place where such a comment is added.

Tested for x86_64.

	* elf/dl-exception.c (_dl_exception_create_format): Add
	fall-through comments.
	* elf/ldconfig.c (parse_conf_include): Likewise.
	* elf/rtld.c (print_statistics): Likewise.
	* locale/programs/charmap.c (parse_charmap): Likewise.
	* misc/mntent_r.c (__getmntent_r): Likewise.
	* posix/wordexp.c (parse_arith): Likewise.
	(parse_backtick): Likewise.
	* resolv/ns_ttl.c (ns_parse_ttl): Likewise.
	* sysdeps/x86/cpu-features.c (init_cpu_features): Likewise.
	* sysdeps/x86_64/dl-machine.h (elf_machine_rela): Likewise.
2019-02-12 10:30:34 +00:00
..
bits Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sys Fix a few typos in comments 2019-01-12 13:44:51 +00:00
acct.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
allocate_once.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ar.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
brk.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
bug18240.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
bug-hsearch1.c
chflags.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
chroot.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
daemon.c Consolidate non cancellable close call 2017-08-18 18:38:55 -03:00
dirname.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
efgcvt_r.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
efgcvt.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
err.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
err.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
error.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
error.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fchflags.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fdatasync.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fgetxattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
flistxattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fremovexattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fsetxattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fstab.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fstab.h
fsync.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ftruncate64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ftruncate.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
futimes.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
futimesat.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getauxval.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getclktck.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getdomain.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getdtsz.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
gethostid.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
gethostname.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getloadavg.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getpagesize.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getpass.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getsysstats.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getttyent.c Fix -Os getc_unlocked linknamespace, localplt issues (bug 15105, bug 19463). 2018-02-21 18:01:11 +00:00
getusershell.c
getxattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
gtty.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
hsearch_r.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
hsearch.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ifunc-impl-list.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
init-misc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
insremque.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ioctl.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lgetxattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
libgen.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
listxattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
llistxattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lremovexattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lsearch.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lsetxattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lutimes.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
madvise.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
makedev.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
Makefile Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mincore.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mkdtemp.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mkostemp64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mkostemp.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mkostemps64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mkostemps.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mkstemp64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mkstemp.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mkstemps64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mkstemps.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mktemp.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mlock.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mlockall.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mmap64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mmap.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mntent_r.c Add fall-through comments. 2019-02-12 10:30:34 +00:00
mntent.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mntent.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mprotect.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
msync.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
munlock.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
munlockall.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
munmap.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
preadv2.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
preadv64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
preadv64v2.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
preadv.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pselect.c nptl: Remove tst-cancel-wrappers test and related macros 2019-01-03 18:38:08 -02:00
ptrace.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pwritev2.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pwritev64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pwritev64v2.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pwritev.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
qefgcvt_r.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
qefgcvt.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
readv.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
reboot.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
regexp.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
regexp.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
remap_file_pages.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
removexattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
revoke.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sbrk.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
search.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
select.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
setdomain.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
setegid.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
seteuid.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sethostid.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sethostname.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
setregid.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
setreuid.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
setxattr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sgtty.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sstk.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
stab.h
stty.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
swapoff.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
swapon.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sync.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
syncfs.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
syscall.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
syscall.h
sysexits.h
syslog.c Add __vsyslog_internal, with same flags as __v*printf_internal. 2018-12-05 18:15:43 -02:00
syslog.h
truncate64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
truncate.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tsearch.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-allocate_once.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-atomic-long.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-atomic.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-dbl-efgcvt.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-dirname.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-efgcvt-template.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-empty.c Move all tests out of the csu subdirectory 2016-12-21 11:52:19 +01:00
tst-error1.c Split DIAG_* macros to new header libc-diag.h. 2017-02-25 09:59:46 -05:00
tst-fdset.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-gethostid.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-hsearch.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-insremque.c
tst-ldbl-efgcvt.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-ldbl-error.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-ldbl-warn.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-makedev.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-mntent2.c Fix warning in misc/tst-mntent2.c. 2014-12-16 10:27:16 +01:00
tst-mntent-blank-corrupt.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-mntent-blank-passno.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-mntent.c getmntent: fix memory corruption w/blank lines [BZ #18887] 2015-08-29 18:07:00 -04:00
tst-preadvwritev2-common.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-preadvwritev2.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-preadvwritev64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-preadvwritev64v2.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-preadvwritev-common.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-preadvwritev.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-pselect.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-tsearch.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-warn-wide.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ttyent.h
ttyslot.c As a minor cleanup remove the (r)index defines from include/string.h as 2017-02-06 18:15:18 +00:00
ualarm.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
usleep.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ustat.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
utimes.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
Versions Implement allocate_once for atomic initialization with allocation 2018-05-23 15:27:01 +02:00
vhangup.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
writev.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00