glibc/support/timespec.h
H.J. Lu f896fc0f2b Correct timespec implementation [BZ #26232]
commit 04deeaa9ea
Author: Lucas A. M. Magalhaes <lamm@linux.ibm.com>
Date:   Fri Jul 10 19:41:06 2020 -0300

    Fix time/tst-cpuclock1 intermitent failures

has 2 issues:

1. It assumes time_t == long which is false on x32.
2. tst-timespec.c is compiled without -fexcess-precision=standard which
generates incorrect results on i686 in support_timespec_check_in_range:

  double ratio = (double)observed_norm / expected_norm;
  return (lower_bound <= ratio && ratio <= upper_bound);

This patch does

1. Compile tst-timespec.c with -fexcess-precision=standard.
2. Replace long with time_t.
3. Replace LONG_MIN and LONG_MAX with TYPE_MINIMUM (time_t) and
TYPE_MAXIMUM (time_t).
2020-07-14 04:42:58 -07:00

88 lines
3.4 KiB
C

/* Useful functions for tests that use struct timespec.
Copyright (C) 2019-2020 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#ifndef SUPPORT_TIMESPEC_H
#define SUPPORT_TIMESPEC_H
#include <stdio.h>
#include <time.h>
#include <support/check.h>
#include <support/xtime.h>
struct timespec timespec_add (struct timespec, struct timespec)
__attribute__((const));
struct timespec timespec_sub (struct timespec, struct timespec)
__attribute__((const));
static inline struct timespec
make_timespec (time_t s, long int ns)
{
struct timespec r;
r.tv_sec = s;
r.tv_nsec = ns;
return r;
}
enum { TIMESPEC_HZ = 1000000000 };
void test_timespec_before_impl (const char *file, int line,
const struct timespec left,
const struct timespec right);
void test_timespec_equal_or_after_impl (const char *file, int line,
const struct timespec left,
const struct timespec right);
time_t support_timespec_ns (struct timespec time);
struct timespec support_timespec_normalize (struct timespec time);
int support_timespec_check_in_range (struct timespec expected, struct timespec observed,
double lower_bound, double upper_bound);
/* Check that the timespec on the left represents a time before the
time on the right. */
#define TEST_TIMESPEC_BEFORE(left, right) \
test_timespec_before_impl (__FILE__, __LINE__, (left), (right))
#define TEST_TIMESPEC_BEFORE_NOW(left, clockid) \
({ \
struct timespec now; \
const int saved_errno = errno; \
xclock_gettime ((clockid), &now); \
TEST_TIMESPEC_BEFORE ((left), now); \
errno = saved_errno; \
})
/* Check that the timespec on the left represents a time equal to or
after the time on the right. */
#define TEST_TIMESPEC_EQUAL_OR_AFTER(left, right) \
test_timespec_equal_or_after_impl (__FILE__, __LINE__, left, right)
#define TEST_TIMESPEC_NOW_OR_AFTER(clockid, right) \
({ \
struct timespec now; \
const int saved_errno = errno; \
xclock_gettime ((clockid), &now); \
TEST_TIMESPEC_EQUAL_OR_AFTER (now, (right)); \
errno = saved_errno; \
})
#endif /* SUPPORT_TIMESPEC_H */