mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-27 05:00:15 +00:00
f4f8f4d4e0
This is a follow up patch to the fix for bug 19329. This adds relaxed MO atomics to accesses that were previously data races but are now race conditions, and where relaxed MO is sufficient. The race conditions all follow the pattern that the write is behind the dlopen lock, but a read can happen concurrently (e.g. during tls access) without holding the lock. For slotinfo entries the read value only matters if it reads from a synchronized write in dlopen or dlclose, otherwise the related dtv entry is not valid to access so it is fine to leave it in an inconsistent state. The same applies for GL(dl_tls_max_dtv_idx) and GL(dl_tls_generation), but there the algorithm relies on the fact that the read of the last synchronized write is an increasing value. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
55 lines
1.7 KiB
C
55 lines
1.7 KiB
C
/* Thread-local storage handling in the ELF dynamic linker. x86-64 version.
|
|
Copyright (C) 2017-2021 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#ifdef SHARED
|
|
/* Work around GCC PR58066, due to which __tls_get_addr may be called
|
|
with an unaligned stack. The compat implementation is in
|
|
tls_get_addr-compat.S. */
|
|
|
|
# include <dl-tls.h>
|
|
|
|
/* Define __tls_get_addr within elf/dl-tls.c under a different
|
|
name. */
|
|
extern __typeof__ (__tls_get_addr) ___tls_get_addr;
|
|
|
|
# define __tls_get_addr ___tls_get_addr
|
|
# include <elf/dl-tls.c>
|
|
# undef __tls_get_addr
|
|
|
|
hidden_ver (___tls_get_addr, __tls_get_addr)
|
|
|
|
/* Only handle slow paths for __tls_get_addr. */
|
|
attribute_hidden
|
|
void *
|
|
__tls_get_addr_slow (GET_ADDR_ARGS)
|
|
{
|
|
dtv_t *dtv = THREAD_DTV ();
|
|
|
|
size_t gen = atomic_load_relaxed (&GL(dl_tls_generation));
|
|
if (__glibc_unlikely (dtv[0].counter != gen))
|
|
return update_get_addr (GET_ADDR_PARAM);
|
|
|
|
return tls_get_addr_tail (GET_ADDR_PARAM, dtv, NULL);
|
|
}
|
|
#else
|
|
|
|
/* No compatibility symbol needed. */
|
|
# include <elf/dl-tls.c>
|
|
|
|
#endif
|