mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-12 06:10:10 +00:00
c579f48edb
This patch remove the PID cache and usage in current GLIBC code. Current usage is mainly used a performance optimization to avoid the syscall, however it adds some issues: - The exposed clone syscall will try to set pid/tid to make the new thread somewhat compatible with current GLIBC assumptions. This cause a set of issue with new workloads and usecases (such as BZ#17214 and [1]) as well for new internal usage of clone to optimize other algorithms (such as clone plus CLONE_VM for posix_spawn, BZ#19957). - The caching complexity also added some bugs in the past [2] [3] and requires more effort of each port to handle such requirements (for both clone and vfork implementation). - Caching performance gain in mainly on getpid and some specific code paths. The getpid performance leverage is questionable [4], either by the idea of getpid being a hotspot as for the getpid implementation itself (if it is indeed a justifiable hotspot a vDSO symbol could let to a much more simpler solution). Other usage is mainly for non usual code paths, such as pthread cancellation signal and handling. For thread creation (on stack allocation) the code simplification in fact adds some performance gain due the no need of transverse the stack cache and invalidate each element pid. Other thread usages will require a direct getpid syscall, such as cancellation/setxid signal, thread cancellation, thread fail path (at create_thread), and thread signal (pthread_kill and pthread_sigqueue). However these are hardly usual hotspots and I think adding a syscall is justifiable. It also simplifies both the clone and vfork arch-specific implementation. And by review each fork implementation there are some discrepancies that this patch also solves: - microblaze clone/vfork does not set/reset the pid/tid field - hppa uses the default vfork implementation that fallback to fork. Since vfork is deprecated I do not think we should bother with it. The patch also removes the TID caching in clone. My understanding for such semantic is try provide some pthread usage after a user program issue clone directly (as done by thread creation with CLONE_PARENT_SETTID and pthread tid member). However, as stated before in multiple discussions threads, GLIBC provides clone syscalls without further supporting all this semantics. I ran a full make check on x86_64, x32, i686, armhf, aarch64, and powerpc64le. For sparc32, sparc64, and mips I ran the basic fork and vfork tests from posix/ folder (on a qemu system). So it would require further testing on alpha, hppa, ia64, m68k, nios2, s390, sh, and tile (I excluded microblaze because it is already implementing the patch semantic regarding clone/vfork). [1] https://codereview.chromium.org/800183004/ [2] https://sourceware.org/ml/libc-alpha/2006-07/msg00123.html [3] https://sourceware.org/bugzilla/show_bug.cgi?id=15368 [4] http://yarchive.net/comp/linux/getpid_caching.html * sysdeps/nptl/fork.c (__libc_fork): Remove pid cache setting. * nptl/allocatestack.c (allocate_stack): Likewise. (__reclaim_stacks): Likewise. (setxid_signal_thread): Obtain pid through syscall. * nptl/nptl-init.c (sigcancel_handler): Likewise. (sighandle_setxid): Likewise. * nptl/pthread_cancel.c (pthread_cancel): Likewise. * sysdeps/unix/sysv/linux/pthread_kill.c (__pthread_kill): Likewise. * sysdeps/unix/sysv/linux/pthread_sigqueue.c (pthread_sigqueue): Likewise. * sysdeps/unix/sysv/linux/createthread.c (create_thread): Likewise. * sysdeps/unix/sysv/linux/getpid.c: Remove file. * nptl/descr.h (struct pthread): Change comment about pid value. * nptl/pthread_getattr_np.c (pthread_getattr_np): Remove thread pid assert. * sysdeps/unix/sysv/linux/pthread-pids.h (__pthread_initialize_pids): Do not set pid value. * nptl_db/td_ta_thr_iter.c (iterate_thread_list): Remove thread pid cache check. * nptl_db/td_thr_validate.c (td_thr_validate): Likewise. * sysdeps/aarch64/nptl/tcb-offsets.sym: Remove pid offset. * sysdeps/alpha/nptl/tcb-offsets.sym: Likewise. * sysdeps/arm/nptl/tcb-offsets.sym: Likewise. * sysdeps/hppa/nptl/tcb-offsets.sym: Likewise. * sysdeps/i386/nptl/tcb-offsets.sym: Likewise. * sysdeps/ia64/nptl/tcb-offsets.sym: Likewise. * sysdeps/m68k/nptl/tcb-offsets.sym: Likewise. * sysdeps/microblaze/nptl/tcb-offsets.sym: Likewise. * sysdeps/mips/nptl/tcb-offsets.sym: Likewise. * sysdeps/nios2/nptl/tcb-offsets.sym: Likewise. * sysdeps/powerpc/nptl/tcb-offsets.sym: Likewise. * sysdeps/s390/nptl/tcb-offsets.sym: Likewise. * sysdeps/sh/nptl/tcb-offsets.sym: Likewise. * sysdeps/sparc/nptl/tcb-offsets.sym: Likewise. * sysdeps/tile/nptl/tcb-offsets.sym: Likewise. * sysdeps/x86_64/nptl/tcb-offsets.sym: Likewise. * sysdeps/unix/sysv/linux/aarch64/clone.S: Remove pid and tid caching. * sysdeps/unix/sysv/linux/alpha/clone.S: Likewise. * sysdeps/unix/sysv/linux/arm/clone.S: Likewise. * sysdeps/unix/sysv/linux/hppa/clone.S: Likewise. * sysdeps/unix/sysv/linux/i386/clone.S: Likewise. * sysdeps/unix/sysv/linux/ia64/clone2.S: Likewise. * sysdeps/unix/sysv/linux/mips/clone.S: Likewise. * sysdeps/unix/sysv/linux/nios2/clone.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/clone.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/clone.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/clone.S: Likewise. * sysdeps/unix/sysv/linux/sh/clone.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/clone.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/clone.S: Likewise. * sysdeps/unix/sysv/linux/tile/clone.S: Likewise. * sysdeps/unix/sysv/linux/x86_64/clone.S: Likewise. * sysdeps/unix/sysv/linux/aarch64/vfork.S: Remove pid set and reset. * sysdeps/unix/sysv/linux/alpha/vfork.S: Likewise. * sysdeps/unix/sysv/linux/arm/vfork.S: Likewise. * sysdeps/unix/sysv/linux/i386/vfork.S: Likewise. * sysdeps/unix/sysv/linux/ia64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/m68k/clone.S: Likewise. * sysdeps/unix/sysv/linux/m68k/vfork.S: Likewise. * sysdeps/unix/sysv/linux/mips/vfork.S: Likewise. * sysdeps/unix/sysv/linux/nios2/vfork.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/vfork.S: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/vfork.S: Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/sh/vfork.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/vfork.S: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/tile/vfork.S: Likewise. * sysdeps/unix/sysv/linux/x86_64/vfork.S: Likewise. * sysdeps/unix/sysv/linux/tst-clone2.c (f): Remove direct pthread struct access. (clone_test): Remove function. (do_test): Rewrite to take in consideration pid is not cached anymore.
179 lines
4.1 KiB
ArmAsm
179 lines
4.1 KiB
ArmAsm
/* Copyright (C) 2011-2016 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Chris Metcalf <cmetcalf@tilera.com>, 2011.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library. If not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
/* clone() is even more special than fork() as it mucks with stacks
|
|
and invokes a function in the right context after it's all over. */
|
|
|
|
#include <sysdep.h>
|
|
#define _ERRNO_H 1
|
|
#include <bits/errno.h>
|
|
|
|
#include <asm/unistd.h>
|
|
#include <arch/abi.h>
|
|
#include <tls.h>
|
|
#include <linux/sched.h>
|
|
|
|
/* What we save where in the stack frame; must include all callee-saves. */
|
|
#define FRAME_NEXT_LR (0 * REGSIZE) /* reserved by ABI; not used here */
|
|
#define FRAME_SP (1 * REGSIZE)
|
|
#define FRAME_R30 (2 * REGSIZE)
|
|
#define FRAME_R31 (3 * REGSIZE)
|
|
#define FRAME_R32 (4 * REGSIZE)
|
|
#define FRAME_SIZE (5 * REGSIZE)
|
|
|
|
/* int clone(int (*fn)(void *arg), void *child_stack, int flags, void *arg,
|
|
pid_t *ptid, struct user_desc *tls, pid_t *ctid); */
|
|
|
|
.text
|
|
ENTRY (__clone)
|
|
/* Create a stack frame so we can pass callee-saves to new task. */
|
|
{
|
|
move r10, sp
|
|
ST sp, lr
|
|
ADDI_PTR sp, sp, -FRAME_SIZE
|
|
}
|
|
cfi_offset (lr, 0)
|
|
cfi_def_cfa_offset (FRAME_SIZE)
|
|
ADDI_PTR r11, sp, FRAME_SP
|
|
{
|
|
ST r11, r10
|
|
ADDI_PTR r11, sp, FRAME_R30
|
|
}
|
|
{
|
|
ST r11, r30
|
|
ADDI_PTR r11, sp, FRAME_R31
|
|
}
|
|
cfi_offset (r30, FRAME_R30 - FRAME_SIZE)
|
|
{
|
|
ST r11, r31
|
|
ADDI_PTR r11, sp, FRAME_R32
|
|
}
|
|
cfi_offset (r31, FRAME_R31 - FRAME_SIZE)
|
|
ST r11, r32
|
|
cfi_offset (r32, FRAME_R32 - FRAME_SIZE)
|
|
|
|
/* sanity check arguments */
|
|
BEQZ r0, .Linvalid
|
|
BEQZ r1, .Linvalid
|
|
|
|
/* Make sure child stack is properly aligned, and set up the
|
|
top frame so that we can call out of it immediately in the
|
|
child. Setting it up here means we fault in the parent if
|
|
it's bogus, which is probably cleaner than faulting first
|
|
thing in the child. */
|
|
ADDI_PTR r1, r1, -C_ABI_SAVE_AREA_SIZE
|
|
andi r1, r1, -C_ABI_SAVE_AREA_SIZE
|
|
ADDI_PTR r9, r1, REGSIZE /* sp of this frame on entry, i.e. zero */
|
|
ST r9, zero
|
|
|
|
/* We need to switch the argument convention around from
|
|
libc to kernel:
|
|
|
|
libc:
|
|
r0 fn
|
|
r1 child_stack
|
|
r2 flags
|
|
r3 arg
|
|
r4 ptid
|
|
r5 tls
|
|
r6 ctid
|
|
|
|
kernel:
|
|
r0 flags
|
|
r1 child_stack [same as libc]
|
|
r2 ptid
|
|
r3 ctid
|
|
r4 tls
|
|
|
|
Plus the callee-saves as described at .Lthread_start, below. */
|
|
{
|
|
move r32, r0
|
|
move r0, r2
|
|
}
|
|
{
|
|
move r31, r3
|
|
move r3, r6
|
|
}
|
|
{
|
|
move r30, r2
|
|
move r2, r4
|
|
}
|
|
{
|
|
move r4, r5
|
|
moveli TREG_SYSCALL_NR_NAME, __NR_clone
|
|
}
|
|
swint1
|
|
BEQZ r0, .Lthread_start /* If in child task. */
|
|
|
|
.Ldone:
|
|
/* Restore the callee-saved registers and return. */
|
|
ADDLI_PTR lr, sp, FRAME_SIZE
|
|
{
|
|
LD lr, lr
|
|
ADDLI_PTR r30, sp, FRAME_R30
|
|
}
|
|
{
|
|
LD r30, r30
|
|
ADDLI_PTR r31, sp, FRAME_R31
|
|
}
|
|
{
|
|
LD r31, r31
|
|
ADDLI_PTR r32, sp, FRAME_R32
|
|
}
|
|
{
|
|
LD r32, r32
|
|
ADDI_PTR sp, sp, FRAME_SIZE
|
|
}
|
|
cfi_def_cfa_offset (0)
|
|
|
|
BNEZ r1, .Lerror
|
|
jrp lr
|
|
|
|
.Lerror:
|
|
j SYSCALL_ERROR_NAME
|
|
|
|
.Linvalid:
|
|
{
|
|
movei r1, EINVAL
|
|
j .Ldone
|
|
}
|
|
|
|
/* This function expects to receive:
|
|
|
|
sp: the top of a valid stack area
|
|
r30: clone() flags
|
|
r31: the argument to pass to the user function
|
|
r32: the user function pointer */
|
|
|
|
.Lthread_start:
|
|
cfi_def_cfa_offset (FRAME_SIZE)
|
|
cfi_undefined (lr)
|
|
{
|
|
/* Invoke user function with specified argument. */
|
|
move r0, r31
|
|
jalr r32
|
|
}
|
|
{
|
|
j HIDDEN_JUMPTARGET(_exit)
|
|
info INFO_OP_CANNOT_BACKTRACE /* Notify backtracer to stop. */
|
|
}
|
|
PSEUDO_END (__clone)
|
|
|
|
libc_hidden_def (__clone)
|
|
weak_alias (__clone, clone)
|