mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-31 23:11:09 +00:00
d0c5d731af
The powerpc and sparc bits/mathinline.h include inlines of fdim and fdimf. These are not restricted to -fno-math-errno, but do not set errno, and wrongly use ordered <= comparisons instead of the required islessequal comparisons (this latter issue is latent on powerpc because GCC wrongly uses unordered comparison instructions for operations that should use ordered comparison instructions). Since we wish to avoid such header inlines anyway, leaving it to the compiler to inline such standard functions under appropriate conditions, this patch fixes those issues by removing the inlines in question (and thus removing the sparc bits/mathinline.h header which had no other inlines left in it). I've filed <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85003> for adding correct fdim inlines to GCC, since the function is simple enough that a correct inline is a perfectly reasonable architecture-independent optimization with -fno-math-errno and in the absence of implicit excess precision. Tested with build-many-glibcs.py for all its powerpc and sparc configurations. [BZ #22987] * sysdeps/powerpc/bits/mathinline.h (fdim): Remove inline function. (fdimf): Likewise. * sysdeps/sparc/fpu/bits/mathinline.h: Remove file.
59 lines
1.7 KiB
C
59 lines
1.7 KiB
C
/* Inline math functions for powerpc.
|
|
Copyright (C) 1995-2018 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef _MATH_H
|
|
# error "Never use <bits/mathinline.h> directly; include <math.h> instead."
|
|
#endif
|
|
|
|
#ifndef __extern_inline
|
|
# define __MATH_INLINE __inline
|
|
#else
|
|
# define __MATH_INLINE __extern_inline
|
|
#endif /* __cplusplus */
|
|
|
|
#if defined __GNUC__ && !defined _SOFT_FLOAT && !defined __NO_FPRS__
|
|
|
|
#if !defined __NO_MATH_INLINES && defined __OPTIMIZE__
|
|
|
|
#ifdef __USE_ISOC99
|
|
|
|
# ifndef __powerpc64__
|
|
__MATH_INLINE long int lrint (double __x) __THROW;
|
|
__MATH_INLINE long int
|
|
__NTH (lrint (double __x))
|
|
{
|
|
union {
|
|
double __d;
|
|
long long __ll;
|
|
} __u;
|
|
__asm__ ("fctiw %0,%1" : "=f"(__u.__d) : "f"(__x));
|
|
return __u.__ll;
|
|
}
|
|
|
|
__MATH_INLINE long int lrintf (float __x) __THROW;
|
|
__MATH_INLINE long int
|
|
__NTH (lrintf (float __x))
|
|
{
|
|
return lrint ((double) __x);
|
|
}
|
|
# endif
|
|
|
|
#endif /* __USE_ISOC99 */
|
|
#endif /* !__NO_MATH_INLINES && __OPTIMIZE__ */
|
|
#endif /* __GNUC__ && !_SOFT_FLOAT && !__NO_FPRS__ */
|