mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-25 12:11:10 +00:00
64924422a9
C2x adds binary integer constants starting with 0b or 0B, and supports those constants in strtol-family functions when the base passed is 0 or 2. Implement that strtol support for glibc. As discussed at <https://sourceware.org/pipermail/libc-alpha/2020-December/120414.html>, this is incompatible with previous C standard versions, in that such an input string starting with 0b or 0B was previously required to be parsed as 0 (with the rest of the string unprocessed). Thus, as proposed there, this patch adds 20 new __isoc23_* functions with appropriate header redirection support. This patch does *not* do anything about scanf %i (which will need 12 new functions per long double variant, so 12, 24 or 36 depending on the glibc configuration), instead leaving that for a future patch. The function names would remain as __isoc23_* even if C2x ends up published in 2024 rather than 2023. Making this change leads to the question of what should happen to internal uses of these functions in glibc and its tests. The header redirection (which applies for _GNU_SOURCE or any other feature test macros enabling C2x features) has the effect of redirecting internal uses but without those uses then ending up at a hidden alias (see the comment in include/stdio.h about interaction with libc_hidden_proto). It seems desirable for the default for internal uses to be the same versions used by normal code using _GNU_SOURCE, so rather than doing anything to disable that redirection, similar macro definitions to those in include/stdio.h are added to the include/ headers for the new functions. Given that the default for uses in glibc is for the redirections to apply, the next question is whether the C2x semantics are correct for all those uses. Uses with the base fixed to 10, 16 or any other value other than 0 or 2 can be ignored. I think this leaves the following internal uses to consider (an important consideration for review of this patch will be both whether this list is complete and whether my conclusions on all entries in it are correct): benchtests/bench-malloc-simple.c benchtests/bench-string.h elf/sotruss-lib.c math/libm-test-support.c nptl/perf.c nscd/nscd_conf.c nss/nss_files/files-parse.c posix/tst-fnmatch.c posix/wordexp.c resolv/inet_addr.c rt/tst-mqueue7.c soft-fp/testit.c stdlib/fmtmsg.c support/support_test_main.c support/test-container.c sysdeps/pthread/tst-mutex10.c I think all of these places are OK with the new semantics, except for resolv/inet_addr.c, where the POSIX semantics of inet_addr do not allow for binary constants; thus, I changed that file (to use __strtoul_internal, whose semantics are unchanged) and added a test for this case. In the case of posix/wordexp.c I think accepting binary constants is OK since POSIX explicitly allows additional forms of shell arithmetic expressions, and in stdlib/fmtmsg.c SEV_LEVEL is not in POSIX so again I think accepting binary constants is OK. Functions such as __strtol_internal, which are only exported for compatibility with old binaries from when those were used in inline functions in headers, have unchanged semantics; the __*_l_internal versions (purely internal to libc and not exported) have a new argument to specify whether to accept binary constants. As well as for the standard functions, the header redirection also applies to the *_l versions (GNU extensions), and to legacy functions such as strtoq, to avoid confusing inconsistency (the *q functions redirect to __isoc23_*ll rather than needing their own __isoc23_* entry points). For the functions that are only declared with _GNU_SOURCE, this means the old versions are no longer available for normal user programs at all. An internal __GLIBC_USE_C2X_STRTOL macro is used to control the redirections in the headers, and cases in glibc that wish to avoid the redirections - the function implementations themselves and the tests of the old versions of the GNU functions - then undefine and redefine that macro to allow the old versions to be accessed. (There would of course be greater complexity should we wish to make any of the old versions into compat symbols / avoid them being defined at all for new glibc ABIs.) strtol_l.c has some similarity to strtol.c in gnulib, but has already diverged some way (and isn't listed at all at https://sourceware.org/glibc/wiki/SharedSourceFiles unlike strtoll.c and strtoul.c); I haven't made any attempts at gnulib compatibility in the changes to that file. I note incidentally that inttypes.h and wchar.h are missing the __nonnull present on declarations of this family of functions in stdlib.h; I didn't make any changes in that regard for the new declarations added. |
||
---|---|---|
.. | ||
arpa | ||
bits/types | ||
nss_dns | ||
sys | ||
tst-leaks2.root/etc | ||
base64.c | ||
compat-gethnamaddr.c | ||
compat-hooks.c | ||
Depend | ||
dn_comp.c | ||
dn_expand.c | ||
dn_skipname.c | ||
gai_cancel.c | ||
gai_error.c | ||
gai_misc.c | ||
gai_misc.h | ||
gai_notify.c | ||
gai_sigqueue.c | ||
gai_suspend.c | ||
getaddrinfo_a.c | ||
herror.c | ||
inet_addr.c | ||
inet_net_ntop.c | ||
inet_net_pton.c | ||
inet_neta.c | ||
inet_ntop.c | ||
inet_pton.c | ||
libanl-compat.c | ||
Makefile | ||
netdb.h | ||
ns_date.c | ||
ns_makecanon.c | ||
ns_name_compress.c | ||
ns_name_length_uncompressed.c | ||
ns_name_ntop.c | ||
ns_name_pack.c | ||
ns_name_pton.c | ||
ns_name_skip.c | ||
ns_name_uncompress.c | ||
ns_name_unpack.c | ||
ns_name.c | ||
ns_netint.c | ||
ns_parse.c | ||
ns_print.c | ||
ns_rr_cursor_init.c | ||
ns_rr_cursor_next.c | ||
ns_samebinaryname.c | ||
ns_samedomain.c | ||
ns_samename.c | ||
ns_ttl.c | ||
nsap_addr.c | ||
nss_dns_functions.c | ||
README | ||
res_context_hostalias.c | ||
res_data.c | ||
res_debug.c | ||
res_enable_icmp.c | ||
res_get_nsaddr.c | ||
res_hconf.c | ||
res_hconf.h | ||
res_hostalias.c | ||
res_init.c | ||
res_isourserver.c | ||
res_libc.c | ||
res_mkquery.c | ||
res_nameinquery.c | ||
res_queriesmatch.c | ||
res_query.c | ||
res_randomid.c | ||
res_send.c | ||
res-close.c | ||
res-name-checking.c | ||
res-noaaaa.c | ||
res-putget.c | ||
res-state.c | ||
resolv_conf.c | ||
resolv_conf.h | ||
resolv_context.c | ||
resolv_context.h | ||
resolv-deprecated.c | ||
resolv-internal.h | ||
resolv.h | ||
tst-aton.c | ||
tst-bug18665-tcp.c | ||
tst-bug18665.c | ||
tst-inet_addr-binary.c | ||
tst-inet_aton_exact.c | ||
tst-inet_ntop.c | ||
tst-inet_pton.c | ||
tst-leaks2.c | ||
tst-leaks.c | ||
tst-no-libidn2.c | ||
tst-ns_name_compress.c | ||
tst-ns_name_length_uncompressed.c | ||
tst-ns_name_pton.c | ||
tst-ns_name.c | ||
tst-ns_name.data | ||
tst-ns_rr_cursor.c | ||
tst-ns_samebinaryname.c | ||
tst-p_secstodate.c | ||
tst-res_hconf_reorder.c | ||
tst-res_hnok.c | ||
tst-resolv-ai_idn-common.c | ||
tst-resolv-ai_idn-latin1.c | ||
tst-resolv-ai_idn-nolibidn2.c | ||
tst-resolv-ai_idn.c | ||
tst-resolv-aliases.c | ||
tst-resolv-basic.c | ||
tst-resolv-binary.c | ||
tst-resolv-byaddr.c | ||
tst-resolv-canonname.c | ||
tst-resolv-edns.c | ||
tst-resolv-invalid-cname.c | ||
tst-resolv-maybe_insert_sig.h | ||
tst-resolv-network.c | ||
tst-resolv-noaaaa.c | ||
tst-resolv-nondecimal.c | ||
tst-resolv-qtypes.c | ||
tst-resolv-res_init-multi.c | ||
tst-resolv-res_init-skeleton.c | ||
tst-resolv-res_init-thread.c | ||
tst-resolv-res_init.c | ||
tst-resolv-res_ninit.c | ||
tst-resolv-rotate.c | ||
tst-resolv-search.c | ||
tst-resolv-threads.c | ||
tst-resolv-trailing.c | ||
tst-resolv-trustad.c | ||
tst-resolv-txnid-collision.c | ||
Versions |
The resolver in the GNU C Library ********************************* Starting with version 2.2, the resolver in the GNU C Library comes from BIND 8. Only a subset of the src/lib/resolv part of libbind is included here; basically the parts that are needed to provide the functionality present in the resolver from BIND 4.9.7 that was included in the previous release of the GNU C Library, augmented by the parts needed to provide thread-safety. This means that support for things as dynamic DNS updates and TSIG keys isn't included. If you need those facilities, please take a look at the full BIND distribution. Differences =========== The resolver in the GNU C Library still differs from what's in BIND 8.2.3-T5B: * The RES_DEBUG option (`options debug' in /etc/resolv.conf) has been disabled. * The resolver in glibc allows underscores in domain names. * The <resolv.h> header in glibc includes <netinet/in.h> and <arpa/nameser.h> to make it self-contained. * The `res_close' function in glibc only tries to close open files referenced through `_res' if the RES_INIT bit is set in `_res.options'. This fixes a potential security bug with programs that bogusly call `res_close' without initialising the resolver state first. Note that the thread-safe `res_nclose' still doesn't check the RES_INIT bit. By the way, you're not really supposed to call `res_close/res_nclose' directly. * The resolver in glibc can connect to a nameserver over IPv6. Just specify the IPv6 address in /etc/resolv.conf. You cannot change the address of an IPv6 nameserver dynamically in your program though. Using the resolver in multi-threaded code ========================================= The traditional resolver interfaces `res_query', `res_search', `res_mkquery', `res_send' and `res_init', used a static (global) resolver state stored in the `_res' structure. Therefore, these interfaces are not thread-safe. Therefore, BIND 8.2 introduced a set of "new" interfaces `res_nquery', `res_nsearch', `res_nmkquery', `res_nsend' and `res_ninit' that take a `res_state' as their first argument, so you can use a per-thread resolver state. In glibc, when you link with -lpthread, such a per-thread resolver state is already present. It can be accessed using `_res', which has been redefined as a macro, in a similar way to what has been done for the `errno' and `h_errno' variables. This per-thread resolver state is also used for the `gethostby*' family of functions, which means that for example `gethostbyname_r' is now fully thread-safe and re-entrant. The traditional resolver interfaces however, continue to use a single resolver state and are therefore still thread-unsafe. The resolver state is the same resolver state that is used for the initial ("main") thread. This has the following consequences for existing binaries and source code: * Single-threaded programs will continue to work. There should be no user-visible changes when you recompile them. * Multi-threaded programs that use the traditional resolver interfaces in the "main" thread should continue to work, except that they no longer see any changes in the global resolver state caused by calls to, for example, `gethostbyname' in other threads. Again there should be no user-visible changes when you recompile these programs. * Multi-threaded programs that use the traditional resolver interfaces in more than one thread should be just as buggy as before (there are no problems if you use proper locking of course). If you recompile these programs, manipulating the _res structure in threads other than the "main" thread will seem to have no effect though. * In Multi-threaded that manipulate the _res structure, calls to functions like `gethostbyname' in threads other than the "main" thread won't be influenced by the those changes anymore. We recommend to use the new thread-safe interfaces in new code, since the traditional interfaces have been deprecated by the BIND folks. For compatibility with other (older) systems you might want to continue to use those interfaces though. Using the resolver in C++ code ============================== There resolver contains some hooks which will allow the user to install some callback functions that make it possible to filter DNS requests and responses. Although we do not encourage you to make use of this facility at all, C++ developers should realise that it isn't safe to throw exceptions from such callback functions. Source code =========== The following files come from the BIND distribution (currently version 8.2.3-T5B): src/include/ arpa/nameser.h arpa/nameser_compat.h resolv.h src/lib/resolv/ herror.c res_comp.c res_data.c res_debug.c res_init.c res_mkquery.c res_query.c res_send.c src/lib/nameser/ ns_name.c ns_netint.c ns_parse.c ns_print.c ns_samedomain.c ns_ttl.c src/lib/inet/ inet_addr.c inet_net_ntop.c inet_net_pton.c inet_neta.c inet_ntop.c inet_pton.c nsap_addr.c src/lib/isc/ base64.c Some of these files have been optimised a bit, and adaptations have been made to make them fit in with the rest of glibc. res_libc.c is home-brewn, although parts of it are taken from res_data.c. res_hconf.c and res_hconf.h were contributed by David Mosberger, and do not come from BIND.