mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-28 15:51:07 +00:00
96b7fe4243
This patch consolidates mostly of the Linux posix_fadvise{64} implementations on sysdeps/unix/sysv/linux/posix_fadvise{64}.c. It still keeps arch-specific files for: * S390-32: it uses a packed structure to pass all the arguments on syscall. It is the only supported port that implements __NR_fadvise64_64 in this way. * ARM: it does not implement __NR_fadvise64 (as other 32-bits ports), so posix_fadvise calls internal posix_fadvise64 symbol. * MIPS64 n64: it requires a different version number that other ports. The new macro SYSCALL_LL{64} is used to handle the offset argument and INTERNAL_SYSCALL_CALL to handle passing the correct number of expect arguments. The default Linux adds two new defines a port can use to control how __NR_fadvise64_64 passes the kernel arguments: * __ASSUME_FADVISE64_64_6ARG: the 'advise' argument is moved on second position. This is the case of powerpc32 and arm to avoid implement 7 argument syscall. * __ASSUME_FADVISE64_64_NO_ALIGN: for ABIs that defines __ASSUME_ALIGNED_REGISTER_PAIRS packs the offset without the leading '0'. This is the case of tile 32 bits. ARM also defines __NR_fadvise64_64 as __NR_arm_fadvise64_64 (which is also handled on arch kernel-feature.h). Tested on x86_64, x32, i686, armhf, and aarch64. * posix/Makefile (tests): Add tst-posix_fadvise and tst-posix_fadvise64. * posix/tst-posix_fadvise.c: New file. * posix/tst-posix_fadvise64.c: Likewise. * posix/tst-posix_fadvise-common.c: Likewise. * sysdeps/unix/sysv/linux/arm/kernel-features.h (__ASSUME_FADVISE64_64_6ARG): Define. * sysdeps/unix/sysv/linux/powerpc/kernel-features.h [!__powerpc64__] (__ASSUME_FADVISE64_64_6ARG): Add define. * sysdeps/unix/sysv/linux/arm/posix_fadvise64.c: Remove file. * sysdeps/unix/sysv/linux/generic/wordsize-32/posix_fadvise.c: Likewise. * sysdeps/unix/sysv/linux/i386/posix_fadvise64.S: Likewise. * sysdeps/unix/sysv/linux/mips/mips32/posix_fadvise.c: Likewise. * sysdeps/unix/sysv/linux/mips/mips32/posix_fadvise64.c: Likewise. * sysdeps/unix/sysv/linux/mips/mips64/n32/posix_fadvise.c: Likewise. * sysdeps/unix/sysv/linux/mips/mips64/n32/posix_fadvise64.c: Likewise. * sysdeps/unix/sysv/linux/mips/mips64/n64/posix_fadvise.c: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/posix_fadvise.c: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/posix_fadvise64.c: Likewise. * sysdeps/unix/sysv/linux/wordsize-64/posix_fadvise.c: Likewise. * sysdeps/unix/sysv/linux/wordsize-64/posix_fadvise64.c: Likewise. * sysdeps/unix/sysv/linux/mips/mips64/n64/posix_fadvise64.c (SHLIB_COMPAT(libc, GLIBC_2_2, GLIBC_2_3_3) [__posix_fadvise64_l64]: Alias to __posix_fadvise64_l32. (SHLIB_COMPAT(libc, GLIBC_2_2, GLIBC_2_3_3) [__posix_fadvise64_l32]: Add compat definition to posix_fadvise64. (SHLIB_COMPAT(libc, GLIBC_2_2, GLIBC_2_3_3) [__posix_fadvise64_l64]: Add versioned definition to posix_fadvise64. * sysdeps/unix/sysv/linux/posix_fadvise.c (posix_fadvise): Build iff __OFF_T_MATCHES_OFF64_T is defined, use INTERNAL_SYSCALL_CALL, add __ASSUME_FADVISE64_64_6ARG/__ASSUME_FADVISE64_64_NO_ALIGN support. * sysdeps/unix/sysv/linux/posix_fadvise64.c (posix_fadvise64): Add __ASSUME_FADVISE64_64_NO_ALIGN support and use INTERNAL_SYSCALL_CALL.
104 lines
3.5 KiB
C
104 lines
3.5 KiB
C
/* Common posix_fadvise tests definitions.
|
|
Copyright (C) 2016 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <fcntl.h>
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <unistd.h>
|
|
|
|
static void do_prepare (void);
|
|
#define PREPARE(argc, argv) do_prepare ()
|
|
static int do_test (void);
|
|
#define TEST_FUNCTION do_test ()
|
|
|
|
#include <test-skeleton.c>
|
|
|
|
static char *temp_filename;
|
|
static int temp_fd;
|
|
static char fifoname[] = "/tmp/tst-posix_fadvise-fifo-XXXXXX";
|
|
static int fifofd;
|
|
|
|
static void
|
|
do_prepare (void)
|
|
{
|
|
temp_fd = create_temp_file ("tst-posix_fadvise.", &temp_filename);
|
|
if (temp_fd == -1)
|
|
FAIL_EXIT1 ("cannot create temporary file: %m");
|
|
|
|
if (mktemp (fifoname) == NULL)
|
|
FAIL_EXIT1 ("cannot generate temp file name: %m");
|
|
add_temp_file (fifoname);
|
|
|
|
if (mkfifo (fifoname, S_IWUSR | S_IRUSR) != 0)
|
|
FAIL_EXIT1 ("cannot create fifo: %m");
|
|
|
|
fifofd = open (fifoname, O_RDONLY | O_NONBLOCK);
|
|
if (fifofd == -1)
|
|
FAIL_EXIT1 ("cannot open fifo: %m");
|
|
}
|
|
|
|
/* Effectivelly testing posix_fadvise is hard because side effects are not
|
|
observed without checking either performance or any kernel specific
|
|
supplied information. Also, the syscall is meant to be an advisory,
|
|
so the kernel is free to use this information in any way it deems fit,
|
|
including ignoring it.
|
|
|
|
This test check for some invalid returned operation to check argument
|
|
passing and if implementation follows POSIX error definition. */
|
|
static int
|
|
do_test_common (void)
|
|
{
|
|
/* Add some data to file and ensure it is written to disk. */
|
|
#define BLK_SIZE 2048
|
|
char buffer[BLK_SIZE] = { 0xcd };
|
|
ssize_t ret;
|
|
|
|
if ((ret = write (temp_fd, buffer, BLK_SIZE)) != BLK_SIZE)
|
|
FAIL_EXIT1 ("write returned %zd different than expected %d",
|
|
ret, BLK_SIZE);
|
|
|
|
if (fsync (temp_fd) != 0)
|
|
FAIL_EXIT1 ("fsync failed");
|
|
|
|
/* Test passing an invalid fd. */
|
|
if (posix_fadvise (-1, 0, 0, POSIX_FADV_NORMAL) != EBADF)
|
|
FAIL_EXIT1 ("posix_fadvise with invalid fd did not return EBADF");
|
|
|
|
/* Test passing an invalid operation. */
|
|
if (posix_fadvise (temp_fd, 0, 0, -1) != EINVAL)
|
|
FAIL_EXIT1 ("posix_fadvise with invalid advise did not return EINVAL");
|
|
|
|
/* Test passing a FIFO fd. */
|
|
if (posix_fadvise (fifofd, 0, 0, POSIX_FADV_NORMAL) != ESPIPE)
|
|
FAIL_EXIT1 ("posix_advise with PIPE fd did not return ESPIPE");
|
|
|
|
/* Default fadvise on all file starting at initial position. */
|
|
if (posix_fadvise (temp_fd, 0, 0, POSIX_FADV_NORMAL) != 0)
|
|
FAIL_EXIT1 ("default posix_fadvise failed");
|
|
|
|
if (posix_fadvise (temp_fd, 0, 2 * BLK_SIZE, POSIX_FADV_NORMAL) != 0)
|
|
FAIL_EXIT1 ("posix_fadvise failed (offset = 0, len = %d) failed",
|
|
BLK_SIZE);
|
|
|
|
if (posix_fadvise (temp_fd, 2 * BLK_SIZE, 0, POSIX_FADV_NORMAL) != 0)
|
|
FAIL_EXIT1 ("posix_fadvise failed (offset = %d, len = 0) failed",
|
|
BLK_SIZE);
|
|
|
|
return 0;
|
|
}
|