Go to file
Alexey Makhalov cebcb9f864 Fix range check in do_tunable_update_val
Current implementation of tunables does not set arena_max and arena_test
values. Any value provided by glibc.malloc.arena_max and
glibc.malloc.arena_test parameters is ignored.

These tunables have minval value set to 1 (see elf/dl-tunables.list file)
and undefined maxval value. In that case default value (which is 0. see
scripts/gen-tunables.awk) is being used to set maxval.

For instance, generated tunable_list[] entry for arena_max is:
(gdb) p *cur
$1 = {name = 0x7ffff7df6217 "glibc.malloc.arena_max",
 type = {type_code = TUNABLE_TYPE_SIZE_T, min = 1, max = 0},
  val = {numval = 0, strval = 0x0}, initialized = false,
   security_level = TUNABLE_SECLEVEL_SXID_IGNORE,
    env_alias = 0x7ffff7df622e "MALLOC_ARENA_MAX"}

As a result, any value of glibc.malloc.arena_max is ignored by
TUNABLE_SET_VAL_IF_VALID_RANGE macro
  __type min = (__cur)->type.min;                    <- initialized to 1
  __type max = (__cur)->type.max;                    <- initialized to 0!
  if (min == max)                                    <- false
    {
      min = __default_min;
      max = __default_max;
    }
  if ((__type) (__val) >= min && (__type) (val) <= max)  <- false
    {
      (__cur)->val.numval = val;
      (__cur)->initialized = true;
    }

Assigning correct min/max values at a build time fixes a problem.
Plus, a bit of optimization: Setting of default min/max values for the
given type at a run time might be eliminated.

	* elf/dl-tunables.c (do_tunable_update_val): Range checking fix.
	* scripts/gen-tunables.awk: Set unspecified minval and/or maxval
	values to correct default value for given type.
2017-09-27 02:44:09 +05:30
argp Remove __need macros from errno.h (__need_Emath, __need_error_t). 2017-06-14 08:14:34 -04:00
assert Fix position of tests-unsupported definition in assert/Makefile. 2017-08-22 00:30:51 +00:00
benchtests Add exp2f and log2f benchmark trace 2017-09-20 10:04:12 +01:00
bits hurd: Fix bits/socket.h conformity 2017-09-24 22:21:41 +02:00
catgets Don't compile non-lib modules as lib modules [BZ #21864] 2017-08-21 05:34:54 -07:00
ChangeLog.old Move all old ChangeLogs to a top-level ChangeLog.old directory. 2017-09-01 09:31:43 -04:00
conform Fix mcontext_t sigcontext namespace (bug 21457). 2017-08-30 22:02:04 +00:00
crypt Remove non-add-on Banner files. 2017-09-21 17:49:51 +00:00
csu Remove Banner mechanism. 2017-09-22 17:43:42 +00:00
ctype Use locale_t, not __locale_t, throughout glibc 2017-06-20 20:30:06 -04:00
debug Enable unwind info in libc-start.c and backtrace.c 2017-09-19 15:07:58 +01:00
dev Rename xlocale.h to bits/types/__locale_t.h. 2017-06-20 20:28:11 -04:00
dirent dirent: Remove internal_function attribute 2017-08-31 16:02:40 +02:00
dlfcn dlfcn: Remove internal_function attribute 2017-08-31 16:12:03 +02:00
elf Fix range check in do_tunable_update_val 2017-09-27 02:44:09 +05:30
gmon gmon: Remove internal_function attribute 2017-08-31 16:16:07 +02:00
gnulib Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
grp Remove compat from DEFAULT_CONFIG lookup strings 2017-09-12 10:21:48 -07:00
gshadow Remove __need macros from stdio.h and wchar.h. 2017-06-08 13:58:17 -04:00
hesiod Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
hurd hurd: fix gethostname(NULL, 0) 2017-09-07 00:51:17 +02:00
iconv iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
iconvdata Add new codepage charmaps/IBM858 [BZ #21084] 2017-09-14 15:50:57 +02:00
include scratch_buffer: use union for internal buffer 2017-09-25 18:04:22 -07:00
inet inet: Remove internal_function attribute 2017-08-31 18:52:00 +02:00
intl iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
io Add missing libc_hidden_weak/def calls 2017-09-17 21:57:39 +02:00
libidn Remove Banner mechanism. 2017-09-22 17:43:42 +00:00
libio Finish change from “Bengali” to “Bangla” 2017-09-09 12:41:54 +02:00
locale Finish change from “Bengali” to “Bangla” 2017-09-09 12:41:54 +02:00
localedata Add new codepage charmaps/IBM858 [BZ #21084] 2017-09-14 15:50:57 +02:00
login Consolidate remaning non cancellable definitions 2017-08-23 10:47:03 -03:00
mach hurd: Remove duplicate symbol version 2017-08-28 14:19:55 +02:00
malloc scratch_buffer: use union for internal buffer 2017-09-25 18:04:22 -07:00
manual Remove Banner mechanism. 2017-09-22 17:43:42 +00:00
math New expf and exp2f version without SVID compat wrapper 2017-09-25 10:45:08 +01:00
mathvec Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
misc hurd: Fix build ot misc/tst-preadvwritev2-common.c 2017-09-03 17:51:15 +02:00
nis Consistently use uintN_t not u_intN_t everywhere. 2017-08-07 19:55:34 +00:00
nptl Remove non-add-on Banner files. 2017-09-21 17:49:51 +00:00
nptl_db Move all old ChangeLogs to a top-level ChangeLog.old directory. 2017-09-01 09:31:43 -04:00
nscd nscd: Release read lock after resetting timeout. 2017-09-25 19:49:36 -04:00
nss Remove compat from DEFAULT_CONFIG lookup strings 2017-09-12 10:21:48 -07:00
po Update translations 2017-09-11 05:50:49 +05:30
posix posix: Add compat glob symbol to not follow dangling symbols 2017-09-25 18:04:16 -07:00
pwd Remove __need macros from stdio.h and wchar.h. 2017-06-08 13:58:17 -04:00
resolv resolv/Makefile: Fix typo in comment 2017-09-26 13:53:17 +02:00
resource Define struct rusage in sys/wait.h when required (bug 21575). 2017-06-19 11:59:19 +00:00
rt aio: Remove internal_function function attribute 2017-08-31 15:59:06 +02:00
scripts Fix range check in do_tunable_update_val 2017-09-27 02:44:09 +05:30
setjmp Remove __need macros from signal.h. 2017-05-20 19:04:43 -04:00
shadow Remove __need macros from stdio.h and wchar.h. 2017-06-08 13:58:17 -04:00
signal Fix sigval namespace (bug 21944). 2017-08-16 20:33:59 +00:00
socket __opensock: Remove internal_function attribute 2017-08-17 10:18:15 +02:00
soft-fp Remove non-add-on Banner files. 2017-09-21 17:49:51 +00:00
stdio-common linux: Implement tmpfile with O_TMPFILE (BZ#21530) 2017-09-01 09:52:47 -03:00
stdlib Reduce total memory required to create all threads to 128MiB. This fixes 2017-09-25 17:51:34 -07:00
streams Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
string string/stratcliff.c: Replace int with size_t [BZ #21982] 2017-08-23 08:23:02 -07:00
sunrpc sunrpc/tst-udp-nonblocking: Fix timeout value 2017-09-10 21:09:28 +02:00
support Revert "resolv_test.c: also cope with CONNREFUSED errors returned by recvfrom" 2017-09-25 20:47:51 +02:00
sysdeps Use generic __ifunc for SPARC. 2017-09-26 19:49:33 +00:00
sysvipc Fix test-sysvsem on some platforms 2017-01-02 18:53:50 -02:00
termios Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
time time: Remove the internal_function attribute 2017-08-31 15:59:07 +02:00
timezone zic: Use PRIdMAX to print line numbers 2017-07-25 12:34:14 +05:30
wcsmbs iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
wctype Use locale_t, not __locale_t, throughout glibc 2017-06-20 20:30:06 -04:00
.gitattributes Assume __NR_openat is always defined 2016-03-23 23:35:08 +01:00
.gitignore Add *.pyc to .gitignore 2015-05-18 15:26:26 +05:30
abi-tags Remove the bulk of the NaCl port. 2017-05-20 08:09:10 -04:00
aclocal.m4 gmon: Add test for basic mcount/gprof functionality 2017-08-15 15:49:45 +02:00
ChangeLog Fix range check in do_tunable_update_val 2017-09-27 02:44:09 +05:30
config.h.in i386: Do not set internal_function 2017-08-14 15:08:48 +02:00
config.make.in gmon: Add test for basic mcount/gprof functionality 2017-08-15 15:49:45 +02:00
configure Update configure.ac for binutils 2.25 2017-09-25 18:01:34 -07:00
configure.ac Update configure.ac for binutils 2.25 2017-09-25 18:01:34 -07:00
COPYING
COPYING.LIB
extra-lib.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
gen-locales.mk
INSTALL Update contributors and latest gcc and binutils versions 2017-08-02 18:22:58 +05:30
libc-abis
libof-iterator.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
LICENSES
MAINTAINERS Add MAINTAINERS 2017-05-11 13:38:30 -04:00
Makeconfig Support mcount/gprof test with GCC defaulting to PIE 2017-08-17 04:56:01 -07:00
Makefile Suppress internal declarations for most of the testsuite. 2017-05-11 19:27:59 -04:00
Makefile.in New make target to only build benchmark binaries 2016-04-20 10:23:28 +05:30
Makerules Place $(elf-objpfx)sofini.os last [BZ #22051] 2017-08-31 06:28:46 -07:00
NEWS Optimized generic expf and exp2f with wrappers 2017-09-25 10:44:39 +01:00
o-iterator.mk
README Require Linux kernel 3.2 or later on x86 / x86_64. 2017-05-08 10:45:20 +00:00
Rules Suppress internal declarations for most of the testsuite. 2017-05-11 19:27:59 -04:00
shlib-versions Extend NSS test suite 2017-07-17 15:52:44 -04:00
test-skeleton.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
version.h Open master for development 2017-08-02 19:23:16 +05:30

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu.  The current
GNU/Hurd support requires out-of-tree patches that will eventually be
incorporated into an official GNU C Library release.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arm-*-linux-gnueabi
	hppa-*-linux-gnu	Not currently functional without patches.
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	ia64-*-linux-gnu
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu
	tilegx-*-linux-gnu
	tilepro-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see http://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at http://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see http://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.