mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-02 09:40:13 +00:00
d0def09ff6
As indicated on libc-help [1] the ec138c67cb commit broke 32-bit
builds when configured with --enable-kernel=5.1 or higher. The
scenario 10 from [2] might also occur in this configuration and
INLINE_VSYSCALL will try to use the vDSO symbol and
HAVE_CLOCK_GETTIME64_VSYSCALL does not set HAVE_VSYSCALL prior its
usage.
Also, there is no easy way to just enable the code to use one
vDSO symbol since the macro INLINE_VSYSCALL is redefined if
HAVE_VSYSCALL is set.
Instead of adding more pre-processor handling and making the code
even more convoluted, this patch removes the requirement of defining
HAVE_VSYSCALL before including sysdep-vdso.h to enable vDSO usage.
The INLINE_VSYSCALL is now expected to be issued inside a
HAVE_*_VSYSCALL check, since it will try to use the internal vDSO
pointers.
Both clock_getres and clock_gettime vDSO code for time64_t were
removed since there is no vDSO setup code for the symbol (an
architecture can not set HAVE_CLOCK_GETTIME64_VSYSCALL).
Checked on i686-linux-gnu (default and with --enable-kernel=5.1),
x86_64-linux-gnu, aarch64-linux-gnu, and powerpc64le-linux-gnu.
I also checked against a build to mips64-linux-gnu and
sparc64-linux-gnu.
[1] https://sourceware.org/ml/libc-help/2019-12/msg00014.html
[2] https://sourceware.org/ml/libc-alpha/2019-12/msg00142.html
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
49 lines
1.3 KiB
C
49 lines
1.3 KiB
C
/* time system call for Linux/PowerPC.
|
|
Copyright (C) 2013-2020 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <time.h>
|
|
#include <sysdep.h>
|
|
#include <sysdep-vdso.h>
|
|
|
|
static time_t
|
|
time_vsyscall (time_t *t)
|
|
{
|
|
return INLINE_VSYSCALL (time, 1, t);
|
|
}
|
|
|
|
#ifdef SHARED
|
|
# include <dl-vdso.h>
|
|
# include <libc-vdso.h>
|
|
|
|
# define INIT_ARCH() \
|
|
void *vdso_time = get_vdso_symbol (HAVE_TIME_VSYSCALL);
|
|
|
|
/* If the vDSO is not available we fall back to the syscall. */
|
|
libc_ifunc (time,
|
|
vdso_time
|
|
? VDSO_IFUNC_RET (vdso_time)
|
|
: (void *) time_vsyscall);
|
|
|
|
#else
|
|
time_t
|
|
time (time_t *t)
|
|
{
|
|
return time_vsyscall (t);
|
|
}
|
|
#endif /* !SHARED */
|