mirror of
https://sourceware.org/git/glibc.git
synced 2024-09-20 00:19:57 +00:00
a312e8fe6d
My glibc bot shows failures building the testsuite with GCC mainline
across all architectures:
tst-vfprintf-width-prec.c: In function 'do_test':
tst-vfprintf-width-prec.c:90:16: error: the comparison will always evaluate as 'false' for the address of 'result' will never be NULL [-Werror=address]
90 | if (result == NULL)
| ^~
tst-vfprintf-width-prec.c:89:13: note: 'result' declared here
89 | wchar_t result[100];
| ^~~~~~
This is clearly a correct warning; the comparison against NULL is
clearly a cut-and-paste mistake from an earlier case in the test that
does use calloc. Thus, remove the unnecessary check for NULL shown up
by the warning.
Similarly, two other tests have bogus comparisons against NULL; remove
those as well:
scanf14a.c:95:13: error: the comparison will always evaluate as 'false' for the address of 'fname' will never be NULL [-Werror=address]
95 | if (fname == NULL)
| ^~
scanf14a.c:93:8: note: 'fname' declared here
93 | char fname[strlen (tmpdir) + sizeof "/tst-scanf14.XXXXXX"];
| ^~~~~
scanf16a.c:125:13: error: the comparison will always evaluate as 'false' for the address of 'fname' will never be NULL [-Werror=address]
125 | if (fname == NULL)
| ^~
scanf16a.c:123:8: note: 'fname' declared here
123 | char fname[strlen (tmpdir) + sizeof "/tst-scanf16.XXXXXX"];
| ^~~~~
Tested with build-many-glibcs.py (GCC mainline) for aarch64-linux-gnu.
142 lines
3.4 KiB
C
142 lines
3.4 KiB
C
/* Copyright (C) 2007-2021 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
/* This test exercises the deprecated GNU %as, %aS, and %a[...] scanf
|
|
modifiers, which are not available to programs compiled as C99
|
|
anymore; therefore, this file is compiled with -std=gnu89 and C99
|
|
syntax must not be used. */
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <wchar.h>
|
|
|
|
#if !__GLIBC_USE_DEPRECATED_SCANF
|
|
# error "This file should be compiled with deprecated scanf"
|
|
#endif
|
|
|
|
|
|
#define FAIL() \
|
|
do { \
|
|
result = 1; \
|
|
printf ("test at line %d failed\n", __LINE__); \
|
|
} while (0)
|
|
|
|
int
|
|
main (void)
|
|
{
|
|
wchar_t *lsp;
|
|
char *sp;
|
|
float f;
|
|
double d;
|
|
char c[8];
|
|
int result = 0;
|
|
|
|
if (sscanf (" 0.25s x", "%e%3c", &f, c) != 2)
|
|
FAIL ();
|
|
else if (f != 0.25 || memcmp (c, "s x", 3) != 0)
|
|
FAIL ();
|
|
if (sscanf (" 1.25s x", "%as%2c", &sp, c) != 2)
|
|
FAIL ();
|
|
else
|
|
{
|
|
if (strcmp (sp, "1.25s") != 0 || memcmp (c, " x", 2) != 0)
|
|
FAIL ();
|
|
memset (sp, 'x', sizeof "1.25s");
|
|
free (sp);
|
|
}
|
|
if (sscanf (" 2.25s x", "%las%2c", &d, c) != 2)
|
|
FAIL ();
|
|
else if (d != 2.25 || memcmp (c, " x", 2) != 0)
|
|
FAIL ();
|
|
if (sscanf (" 3.25S x", "%4aS%3c", &lsp, c) != 2)
|
|
FAIL ();
|
|
else
|
|
{
|
|
if (wcscmp (lsp, L"3.25") != 0 || memcmp (c, "S x", 3) != 0)
|
|
FAIL ();
|
|
memset (lsp, 'x', sizeof L"3.25");
|
|
free (lsp);
|
|
}
|
|
if (sscanf ("4.25[0-9.] x", "%a[0-9.]%8c", &sp, c) != 2)
|
|
FAIL ();
|
|
else
|
|
{
|
|
if (strcmp (sp, "4.25") != 0 || memcmp (c, "[0-9.] x", 8) != 0)
|
|
FAIL ();
|
|
memset (sp, 'x', sizeof "4.25");
|
|
free (sp);
|
|
}
|
|
if (sscanf ("5.25[0-9.] x", "%la[0-9.]%2c", &d, c) != 2)
|
|
FAIL ();
|
|
else if (d != 5.25 || memcmp (c, " x", 2) != 0)
|
|
FAIL ();
|
|
|
|
const char *tmpdir = getenv ("TMPDIR");
|
|
if (tmpdir == NULL || tmpdir[0] == '\0')
|
|
tmpdir = "/tmp";
|
|
|
|
char fname[strlen (tmpdir) + sizeof "/tst-scanf14.XXXXXX"];
|
|
sprintf (fname, "%s/tst-scanf14.XXXXXX", tmpdir);
|
|
|
|
/* Create a temporary file. */
|
|
int fd = mkstemp (fname);
|
|
if (fd == -1)
|
|
FAIL ();
|
|
|
|
FILE *fp = fdopen (fd, "w+");
|
|
if (fp == NULL)
|
|
FAIL ();
|
|
else
|
|
{
|
|
if (fputs (" 1.25s x", fp) == EOF)
|
|
FAIL ();
|
|
if (fseek (fp, 0, SEEK_SET) != 0)
|
|
FAIL ();
|
|
if (fscanf (fp, "%as%2c", &sp, c) != 2)
|
|
FAIL ();
|
|
else
|
|
{
|
|
if (strcmp (sp, "1.25s") != 0 || memcmp (c, " x", 2) != 0)
|
|
FAIL ();
|
|
memset (sp, 'x', sizeof "1.25s");
|
|
free (sp);
|
|
}
|
|
|
|
if (freopen (fname, "r", stdin) == NULL)
|
|
FAIL ();
|
|
else
|
|
{
|
|
if (scanf ("%as%2c", &sp, c) != 2)
|
|
FAIL ();
|
|
else
|
|
{
|
|
if (strcmp (sp, "1.25s") != 0 || memcmp (c, " x", 2) != 0)
|
|
FAIL ();
|
|
memset (sp, 'x', sizeof "1.25s");
|
|
free (sp);
|
|
}
|
|
}
|
|
|
|
fclose (fp);
|
|
}
|
|
|
|
remove (fname);
|
|
|
|
return result;
|
|
}
|