glibc/sysdeps/unix/sysv/linux/nios2/setcontext.S
Carlos O'Donell c92d40c0bc Bug 18125: Call exit after last linked context.
There appears to be a discrepancy among the implementations
of setcontext with regards to the function called once the last
linked-to context has finished executing via setcontext.

The POSIX standard says:
~~~
If the uc_link member of the ucontext_t structure pointed to by
the ucp argument is equal to 0, then this context is the main
context, and the thread will exit when this context returns.
~~~

It says "exit" not "exit immediately" nor "exit without running
functions registered with atexit or on_exit."

Therefore the AArch64, ARM, hppa and NIOS II implementations are
wrong and no test detects it.

It is questionable if this should even be fixed or just documented
that the above 4 targets are wrong. The functions are deprecated
and nobody should be using them, but at the same time it silly to
have cross-target differences that make it hard to port old
applications from say x86_64 to AArch64.

Therefore I will ix the 4 arches, and checkin a regression
test to prevent it from changing again.

https://sourceware.org/ml/libc-alpha/2015-03/msg00720.html
2015-05-08 11:29:38 -04:00

104 lines
2.8 KiB
ArmAsm

/* Set current context.
Copyright (C) 2015 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
#include <sysdep.h>
#include "ucontext_i.h"
/* int setcontext (const ucontext_t *ucp) */
.text
ENTRY(__setcontext)
ldw r5, UCONTEXT_FLAGS(r4)
movi r6, 1
bne r5, r6, .Lsigreturn
mov r10, r4
/* Restore signal mask. */
/* rt_sigprocmask (SIG_SETMASK, NULL, &ucp->uc_sigmask, _NSIG8) */
movi r7, _NSIG8
addi r6, r4, UCONTEXT_SIGMASK
mov r5, zero
movi r4, SIG_SETMASK
movi r2, SYS_ify (rt_sigprocmask)
trap
bne r7, zero, SYSCALL_ERROR_LABEL
/* Restore argument registers, for the makecontext() case. */
ldw r4, (UCONTEXT_MCONTEXT + 4*4)(r10)
ldw r5, (UCONTEXT_MCONTEXT + 5*4)(r10)
ldw r6, (UCONTEXT_MCONTEXT + 6*4)(r10)
ldw r7, (UCONTEXT_MCONTEXT + 7*4)(r10)
ldw r16, (UCONTEXT_MCONTEXT + 16*4)(r10)
ldw r17, (UCONTEXT_MCONTEXT + 17*4)(r10)
ldw r18, (UCONTEXT_MCONTEXT + 18*4)(r10)
ldw r19, (UCONTEXT_MCONTEXT + 19*4)(r10)
ldw r20, (UCONTEXT_MCONTEXT + 20*4)(r10)
ldw r21, (UCONTEXT_MCONTEXT + 21*4)(r10)
ldw r22, (UCONTEXT_MCONTEXT + 22*4)(r10)
ldw ra, (UCONTEXT_MCONTEXT + 24*4)(r10)
ldw fp, (UCONTEXT_MCONTEXT + 25*4)(r10)
ldw gp, (UCONTEXT_MCONTEXT + 26*4)(r10)
/* Load address to continue execution. */
ldw r3, (UCONTEXT_MCONTEXT + 28*4)(r10)
ldw sp, (UCONTEXT_MCONTEXT + 29*4)(r10)
mov r2, zero
jmp r3
.Lsigreturn:
addi sp, sp, -RT_SIGFRAME_SIZE
cfi_adjust_cfa_offset (RT_SIGFRAME_SIZE)
addi r2, sp, RT_SIGFRAME_UCONTEXT
movi r3, UCONTEXT_SIZE-4
1:
add r6, r4, r3
ldw r5, 0(r6)
add r7, r2, r3
addi r3, r3, -4
stw r5, 0(r7)
bgt r3, zero, 1b
movi r2, SYS_ify (rt_sigreturn)
trap
addi sp, sp, RT_SIGFRAME_SIZE
cfi_adjust_cfa_offset (-RT_SIGFRAME_SIZE)
br SYSCALL_ERROR_LABEL
PSEUDO_END (__setcontext)
weak_alias (__setcontext, setcontext)
ENTRY(__startcontext)
mov r4, r16
bne r4, zero, __setcontext
/* If uc_link == zero, call exit. */
#ifdef PIC
nextpc r22
1: movhi r8, %hiadj(_gp_got - 1b)
addi r8, r8, %lo(_gp_got - 1b)
add r22, r22, r8
ldw r8, %call(HIDDEN_JUMPTARGET(exit))(r22)
jmp r8
#else
jmpi exit
#endif
END(__startcontext)