mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-03 18:31:04 +00:00
d59f3e5e0f
As noted in <https://sourceware.org/ml/libc-alpha/2018-09/msg00178.html>, glibc's sys/procfs.h headers for microblaze, mips (n64), nios2 and riscv have incorrect types for the pr_uid and pr_gid members of struct elf_prpsinfo (as does the generic Linux version, but nothing uses that). This patch fixes those headers to use unsigned int. The generic Linux version is also fixed, but I do *not* recommend making new architectures use it yet. Rather, I think it should be reworked to look more like a copy of the AArch64 version, but with a new <bits/procfs.h> header included to provide register set definitions; <bits/procfs.h> would then be architecture-specific while many architectures could use the generic <sys/procfs.h>. This fix is deliberately separate from any reworking to use a generic header more, since it's possible there could be uses for backporting this fix but not for backporting a subsequent cleanup. Tested with build-many-glibcs.py. This of course doesn't provide much validation of the structure layout; if the Linux kernel is fixed so that "#include <linux/elfcore.h>" actually compiles with the headers from "make headers_install" (and if the layout in both headers is meant to be the same, whatever ABI we are building for), I have a test that can be added to glibc to check the layout against that from the Linux kernel. [BZ #23649] * sysdeps/unix/sysv/linux/microblaze/sys/procfs.h (struct elf_prpsinfo): Use unsigned int for pr_uid and pr_gid. * sysdeps/unix/sysv/linux/mips/sys/procfs.h (struct elf_prpsinfo): Likewise. * sysdeps/unix/sysv/linux/nios2/sys/procfs.h (struct elf_prpsinfo): Likewise. * sysdeps/unix/sysv/linux/riscv/sys/procfs.h (struct elf_prpsinfo): Likewise. * sysdeps/unix/sysv/linux/sys/procfs.h (struct elf_prpsinfo): Likewise. |
||
|---|---|---|
| .. | ||
| bits | ||
| rv64 | ||
| sys | ||
| atomic-machine.h | ||
| clone.S | ||
| configure | ||
| configure.ac | ||
| dl-cache.h | ||
| dl-static.c | ||
| flush-icache.c | ||
| getcontext.S | ||
| Implies | ||
| init-first.c | ||
| ipc_priv.h | ||
| kernel-features.h | ||
| ldconfig.h | ||
| ldd-rewrite.sed | ||
| ldsodefs.h | ||
| libc-vdso.h | ||
| localplt.data | ||
| makecontext.c | ||
| Makefile | ||
| profil-counter.h | ||
| pt-vfork.S | ||
| readelflib.c | ||
| register-dump.h | ||
| setcontext.S | ||
| shlib-versions | ||
| sigcontextinfo.h | ||
| swapcontext.S | ||
| syscall.c | ||
| sysdep.h | ||
| sysdep.S | ||
| ucontext_i.sym | ||
| ucontext-macros.h | ||
| Versions | ||
| vfork.S | ||