glibc/benchtests
Adhemerval Zanella 0edbf12301 nptl: Invert the mmap/mprotect logic on allocated stacks (BZ#18988)
Current allocate_stack logic for create stacks is to first mmap all
the required memory with the desirable memory and then mprotect the
guard area with PROT_NONE if required.  Although it works as expected,
it pessimizes the allocation because it requires the kernel to actually
increase commit charge (it counts against the available physical/swap
memory available for the system).

The only issue is to actually check this change since side-effects are
really Linux specific and to actually account them it would require a
kernel specific tests to parse the system wide information.  On the kernel
I checked /proc/self/statm does not show any meaningful difference for
vmm and/or rss before and after thread creation.  I could only see
really meaningful information checking on system wide /proc/meminfo
between thread creation: MemFree, MemAvailable, and Committed_AS shows
large difference without the patch.  I think trying to use these
kind of information on a testcase is fragile.

The BZ#18988 reports shows that the commit pages are easily seen with
mlockall (MCL_FUTURE) (with lock all pages that become mapped in the
process) however a more straighfoward testcase shows that pthread_create
could be faster using this patch:

--
static const int inner_count = 256;
static const int outer_count = 128;

static
void *thread1(void *arg)
{
  return NULL;
}

static
void *sleeper(void *arg)
{
  pthread_t ts[inner_count];
  for (int i = 0; i < inner_count; i++)
    pthread_create (&ts[i], &a, thread1, NULL);
  for (int i = 0; i < inner_count; i++)
    pthread_join (ts[i], NULL);

  return NULL;
}

int main(void)
{
  pthread_attr_init(&a);
  pthread_attr_setguardsize(&a, 1<<20);
  pthread_attr_setstacksize(&a, 1134592);

  pthread_t ts[outer_count];
  for (int i = 0; i < outer_count; i++)
    pthread_create(&ts[i], &a, sleeper, NULL);
  for (int i = 0; i < outer_count; i++)
    pthread_join(ts[i], NULL);
    assert(r == 0);
  }
  return 0;
}

--

On x86_64 (4.4.0-45-generic, gcc 5.4.0) running the small benchtests
I see:

$ time ./test

real	0m3.647s
user	0m0.080s
sys	0m11.836s

While with the patch I see:

$ time ./test

real	0m0.696s
user	0m0.040s
sys	0m1.152s

So I added a pthread_create benchtest (thread_create) which check
the thread creation latency.  As for the simple benchtests, I saw
improvements in thread creation on all architectures I tested the
change.

Checked on x86_64-linux-gnu, i686-linux-gnu, aarch64-linux-gnu,
arm-linux-gnueabihf, powerpc64le-linux-gnu, sparc64-linux-gnu,
and sparcv9-linux-gnu.

	[BZ #18988]
	* benchtests/thread_create-inputs: New file.
	* benchtests/thread_create-source.c: Likewise.
	* support/xpthread_attr_setguardsize.c: Likewise.
	* support/Makefile (libsupport-routines): Add
	xpthread_attr_setguardsize object.
	* support/xthread.h: Add xpthread_attr_setguardsize prototype.
	* benchtests/Makefile (bench-pthread): Add thread_create.
	* nptl/allocatestack.c (allocate_stack): Call mmap with PROT_NONE and
	then mprotect the required area.
2017-06-14 17:22:35 -03:00
..
scripts Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
strcoll-inputs Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
acos-inputs Correct inputs for sin and cos 2014-01-10 09:57:51 +05:30
acosh-inputs benchmark inputs for asinh and acosh 2013-12-31 12:05:16 +05:30
asin-inputs Correct inputs for sin and cos 2014-01-10 09:57:51 +05:30
asinh-inputs benchmark inputs for asinh and acosh 2013-12-31 12:05:16 +05:30
atan-inputs benchmark inputs for atan 2013-12-31 12:11:13 +05:30
atanh-inputs benchmark inputs for tanh and atanh 2013-12-31 12:06:30 +05:30
bench-bcopy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-bzero.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-malloc-thread.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-math-inlines.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-memccpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-memchr.c benchtests: Add more tests for memrchr 2017-06-04 09:45:09 -07:00
bench-memcmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-memcpy-large.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-memcpy-random.c Change TEST_NAME to memcpy to fix IFUNC testing of multiple versions. 2017-03-28 09:07:03 -07:00
bench-memcpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-memmem.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-memmove-large.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-memmove.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-mempcpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-memrchr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-memset-large.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-memset.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-rawmemchr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-skeleton.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-stpcpy_chk.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-stpcpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-stpncpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strcasecmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strcasestr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strcat.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strchr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strchrnul.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strcmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strcoll.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strcpy_chk.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strcpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strcspn.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-string.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strlen.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strncasecmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strncat.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strncmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strncpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strnlen.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strpbrk.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strrchr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strsep.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strspn.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strstr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strtod.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-strtok.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-timing-type.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-timing.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-util.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-util.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcpcpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcpncpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcscat.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcschr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcschrnul.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcscmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcscpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcscspn.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcslen.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcsncat.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcsncmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcsncpy.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcsnlen.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcspbrk.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcsrchr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wcsspn.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wmemchr.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wmemcmp.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
bench-wmemset.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
cos-inputs Benchmark inputs for cos and sin 2013-12-31 12:12:46 +05:30
cosh-inputs benchmark inputs for sinh and cosh 2013-12-31 12:03:44 +05:30
exp2-inputs benchmark inputs for exp2, log2, log and tan 2013-12-12 09:31:53 +05:30
exp-inputs New inputs for exp 2013-10-28 16:35:08 +05:30
ffs-inputs benchtests: Add benchtests for ffs and ffsll 2014-03-31 12:50:41 +01:00
ffsll-inputs benchtests: Add benchtests for ffs and ffsll 2014-03-31 12:50:41 +01:00
fmax-inputs benchtests: Add fmax/fmin benchmarks 2016-12-19 16:04:16 -02:00
fmaxf-inputs benchtests: Add fmaxf/fminf benchmarks 2016-12-19 16:04:16 -02:00
fmin-inputs benchtests: Add fmax/fmin benchmarks 2016-12-19 16:04:16 -02:00
fminf-inputs benchtests: Add fmaxf/fminf benchmarks 2016-12-19 16:04:16 -02:00
json-lib.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
json-lib.h Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
log2-inputs benchmark inputs for exp2, log2, log and tan 2013-12-12 09:31:53 +05:30
log-inputs benchmark inputs for exp2, log2, log and tan 2013-12-12 09:31:53 +05:30
Makefile nptl: Invert the mmap/mprotect logic on allocated stacks (BZ#18988) 2017-06-14 17:22:35 -03:00
modf-inputs [benchtests] Use inputs file for modf 2014-03-29 09:35:50 +05:30
pow-inputs Benchmark inputs for pow 2013-10-28 16:36:46 +05:30
pthread_once-inputs benchtests: Add pthread_once common-case test. 2014-04-10 21:22:28 +02:00
pthread_once-source.c Update copyright dates with scripts/update-copyrights. 2017-01-01 00:14:16 +00:00
README benchtests: Support for cross-building benchmarks 2016-04-20 13:19:01 +05:30
rint-inputs Add more directives to benchmark input files 2013-10-07 11:51:25 +05:30
sin-inputs Benchmark inputs for cos and sin 2013-12-31 12:12:46 +05:30
sincos-inputs benchtests: Add inputs from sin and cos to sincos 2015-12-09 00:10:51 +05:30
sinh-inputs benchmark inputs for sinh and cosh 2013-12-31 12:03:44 +05:30
sprintf-inputs Add sprintf benchmark. 2015-05-21 10:02:52 -04:00
sprintf-source.c Add sprintf benchmark. 2015-05-21 10:02:52 -04:00
sqrt-inputs Benchmark test for sqrt function. 2013-12-02 09:37:18 -08:00
tan-inputs benchmark inputs for exp2, log2, log and tan 2013-12-12 09:31:53 +05:30
tanh-inputs benchmark inputs for tanh and atanh 2013-12-31 12:06:30 +05:30
thread_create-inputs nptl: Invert the mmap/mprotect logic on allocated stacks (BZ#18988) 2017-06-14 17:22:35 -03:00
thread_create-source.c nptl: Invert the mmap/mprotect logic on allocated stacks (BZ#18988) 2017-06-14 17:22:35 -03:00

Using the glibc microbenchmark suite
====================================

The glibc microbenchmark suite automatically generates code for specified
functions, builds and calls them repeatedly for given inputs to give some
basic performance properties of the function.

Running the benchmark:
=====================

The benchmark needs python 2.7 or later in addition to the
dependencies required to build the GNU C Library.  One may run the
benchmark by invoking make as follows:

  $ make bench

This runs each function for 10 seconds and appends its output to
benchtests/bench.out.  To ensure that the tests are rebuilt, one could run:

  $ make bench-clean

The duration of each test can be configured setting the BENCH_DURATION variable
in the call to make.  One should run `make bench-clean' before changing
BENCH_DURATION.

  $ make BENCH_DURATION=1 bench

The benchmark suite does function call measurements using architecture-specific
high precision timing instructions whenever available.  When such support is
not available, it uses clock_gettime (CLOCK_PROCESS_CPUTIME_ID).  One can force
the benchmark to use clock_gettime by invoking make as follows:

  $ make USE_CLOCK_GETTIME=1 bench

Again, one must run `make bench-clean' before changing the measurement method.

Running benchmarks on another target:
====================================

If the target where you want to run benchmarks is not capable of building the
code or you're cross-building, you could build and execute the benchmark in
separate steps.  On the build system run:

  $ make bench-build

and then copy the source and build directories to the target and run the
benchmarks from the build directory as usual:

  $ make bench

make sure the copy preserves timestamps by using either rsync or scp -p
otherwise the above command may try to build the benchmark again.  Benchmarks
that require generated code to be executed during the build are skipped when
cross-building.

Adding a function to benchtests:
===============================

If the name of the function is `foo', then the following procedure should allow
one to add `foo' to the bench tests:

- Append the function name to the bench variable in the Makefile.

- Make a file called `foo-inputs` to provide the definition and input for the
  function.  The file should have some directives telling the parser script
  about the function and then one input per line.  Directives are lines that
  have a special meaning for the parser and they begin with two hashes '##'.
  The following directives are recognized:

  - args: This should be assigned a colon separated list of types of the input
    arguments.  This directive may be skipped if the function does not take any
    inputs.  One may identify output arguments by nesting them in <>.  The
    generator will create variables to get outputs from the calling function.
  - ret: This should be assigned the type that the function returns.  This
    directive may be skipped if the function does not return a value.
  - includes: This should be assigned a comma-separated list of headers that
    need to be included to provide declarations for the function and types it
    may need (specifically, this includes using "#include <header>").
  - include-sources: This should be assigned a comma-separated list of source
    files that need to be included to provide definitions of global variables
    and functions (specifically, this includes using "#include "source").
    See pthread_once-inputs and pthreads_once-source.c for an example of how
    to use this to benchmark a function that needs state across several calls.
  - init: Name of an initializer function to call to initialize the benchtest.
  - name: See following section for instructions on how to use this directive.

  Lines beginning with a single hash '#' are treated as comments.  See
  pow-inputs for an example of an input file.

Multiple execution units per function:
=====================================

Some functions have distinct performance characteristics for different input
domains and it may be necessary to measure those separately.  For example, some
math functions perform computations at different levels of precision (64-bit vs
240-bit vs 768-bit) and mixing them does not give a very useful picture of the
performance of these functions.  One could separate inputs for these domains in
the same file by using the `name' directive that looks something like this:

  ##name: 240bit

See the pow-inputs file for an example of what such a partitioned input file
would look like.

Benchmark Sets:
==============

In addition to standard benchmarking of functions, one may also generate
custom outputs for a set of functions.  This is currently used by string
function benchmarks where the aim is to compare performance between
implementations at various alignments and for various sizes.

To add a benchset for `foo':

- Add `foo' to the benchset variable.
- Write your bench-foo.c that prints out the measurements to stdout.
- On execution, a bench-foo.out is created in $(objpfx) with the contents of
  stdout.