mirror of
https://sourceware.org/git/glibc.git
synced 2025-01-15 05:20:05 +00:00
d9afe48d55
The dbl-64/wordsize-64 remquo implementation follows similar logic to various other implementations, but where that logic computes some absolute values, it wrongly uses a previously computed bit-pattern for the absolute value of the first argument, where actually it needs the absolute value of the first argument mod 8 times the second. This patch fixes it to compute the correct absolute value. The integer quotient result of remquo is only specified mod 8 (including its sign); architecture-specific versions may well vary in what results they give for higher bits of that result (and indeed bug 17569 gives an example correct result from __builtin_remquo giving 9 for that result, where the particular glibc implementation used in that bug report would give 1 after this fix). Thus, this patch adapts the tests of remquo to test that result only mod 8, to allow for such variation when tests with higher quotient are included. Tested for x86_64 and x86. [BZ #17569] * sysdeps/ieee754/dbl-64/wordsize-64/s_remquo.c (__remquo): Compute absolute value of x as modified by fmod, not original value of x. * math/libm-test.inc (RUN_TEST_ffI_f1): Rename to RUN_TEST_ffI_f1_mod8. Check extra return value mod 8. (RUN_TEST_LOOP_ffI_f1): Rename to RUN_TEST_LOOP_ffI_f1_mod8. Call RUN_TEST_ffI_f1_mod8. (remquo_test_data): Add more tests. |
||
|---|---|---|
| .. | ||
| e_acosh.c | ||
| e_cosh.c | ||
| e_fmod.c | ||
| e_log2.c | ||
| e_log10.c | ||
| math_private.h | ||
| s_ceil.c | ||
| s_finite.c | ||
| s_floor.c | ||
| s_frexp.c | ||
| s_isinf_ns.c | ||
| s_isinf.c | ||
| s_isnan.c | ||
| s_issignaling.c | ||
| s_llround.c | ||
| s_logb.c | ||
| s_lround.c | ||
| s_modf.c | ||
| s_nearbyint.c | ||
| s_remquo.c | ||
| s_rint.c | ||
| s_round.c | ||
| s_scalbln.c | ||
| s_scalbn.c | ||
| s_trunc.c | ||