glibc/malloc/tst-mallocalign1.c
Carlos O'Donell 6484ae5b8c malloc: Fix -Wuse-after-free warning in tst-mallocalign1 [BZ #26779]
The test leaks bits from the freed pointer via the return value
in ret, and the compiler correctly identifies this issue.
We switch the test to use TEST_VERIFY and terminate the test
if any of the pointers return an unexpected alignment.

This fixes another -Wuse-after-free error when compiling glibc
with gcc 12.

Tested on x86_64 and i686 without regression.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
(cherry picked from commit 3a7bed5f5a)
2023-01-11 22:13:37 +01:00

74 lines
1.6 KiB
C

/* Verify that MALLOC_ALIGNMENT is honored by malloc.
Copyright (C) 2012-2021 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#include <stdio.h>
#include <stdlib.h>
#include <inttypes.h>
#include <malloc-size.h>
#include <support/check.h>
static void *
test (size_t s)
{
void *p = malloc (s);
printf ("malloc: %zu, %p: %zu\n", s, p,
((uintptr_t) p) & MALLOC_ALIGN_MASK);
return p;
}
#define ALIGNED(p) (((uintptr_t )p & MALLOC_ALIGN_MASK) == 0)
static int
do_test (void)
{
void *p;
p = test (2);
TEST_VERIFY (ALIGNED (p));
free (p);
p = test (8);
TEST_VERIFY (ALIGNED (p));
free (p);
p = test (13);
TEST_VERIFY (ALIGNED (p));
free (p);
p = test (16);
TEST_VERIFY (ALIGNED (p));
free (p);
p = test (23);
TEST_VERIFY (ALIGNED (p));
free (p);
p = test (43);
TEST_VERIFY (ALIGNED (p));
free (p);
p = test (123);
TEST_VERIFY (ALIGNED (p));
free (p);
return 0;
}
#include <support/test-driver.c>