mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-25 04:01:10 +00:00
e02920bc02
In non-default rounding modes, tgamma can be slightly less accurate than permitted by glibc's accuracy goals. Part of the problem is error accumulation, addressed in this patch by setting round-to-nearest for internal computations. However, there was also a bug in the code dealing with computing pow (x + n, x + n) where x + n is not exactly representable, providing another source of error even in round-to-nearest mode; it was necessary to address both bugs to get errors for all testcases within glibc's accuracy goals. Given this second fix, accuracy in round-to-nearest mode is also improved (hence regeneration of ulps for tgamma should be from scratch - truncate libm-test-ulps or at least remove existing tgamma entries - so that the expected ulps can be reduced). Some additional complications also arose. Certain tgamma tests should strictly, according to IEEE semantics, overflow or not depending on the rounding mode; this is beyond the scope of glibc's accuracy goals for any function without exactly-determined results, but gen-auto-libm-tests doesn't handle being lax there as it does for underflow. (libm-test.inc also doesn't handle being lax about whether the result in cases very close to the overflow threshold is infinity or a finite value close to overflow, but that doesn't cause problems in this case though I've seen it cause problems with random test generation for some functions.) Thus, spurious-overflow markings, with a comment, are added to auto-libm-test-in (no bug in Bugzilla because the issue is with the testsuite, not a user-visible bug in glibc). And on x86, after the patch I saw ERANGE issues as previously reported by Carlos (see my commentary in <https://sourceware.org/ml/libc-alpha/2015-01/msg00485.html>), which needed addressing by ensuring excess range and precision were eliminated at various points if FLT_EVAL_METHOD != 0. I also noticed and fixed a cosmetic issue where 1.0f was used in long double functions and should have been 1.0L. This completes the move of all functions to testing in all rounding modes with ALL_RM_TEST, so gen-libm-have-vector-test.sh is updated to remove the workaround for some functions not using ALL_RM_TEST. Tested for x86_64, x86, mips64 and powerpc. [BZ #18613] * sysdeps/ieee754/dbl-64/e_gamma_r.c (gamma_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gamma_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. * sysdeps/ieee754/flt-32/e_gammaf_r.c (gammaf_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammaf_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. * sysdeps/ieee754/ldbl-128/e_gammal_r.c (gammal_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammal_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. Use 1.0L not 1.0f as numerator of division. * sysdeps/ieee754/ldbl-128ibm/e_gammal_r.c (gammal_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammal_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. Use 1.0L not 1.0f as numerator of division. * sysdeps/ieee754/ldbl-96/e_gammal_r.c (gammal_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammal_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. Use 1.0L not 1.0f as numerator of division. * math/libm-test.inc (tgamma_test_data): Remove one test. Moved to auto-libm-test-in. (tgamma_test): Use ALL_RM_TEST. * math/auto-libm-test-in: Add one test of tgamma. Mark some other tests of tgamma with spurious-overflow. * math/auto-libm-test-out: Regenerated. * math/gen-libm-have-vector-test.sh: Do not check for START. * sysdeps/i386/fpu/libm-test-ulps: Update. * sysdeps/x86_64/fpu/libm-test-ulps: Likewise. |
||
|---|---|---|
| .. | ||
| 64 | ||
| bits | ||
| fpu | ||
| multiarch | ||
| nptl | ||
| x32 | ||
| ____longjmp_chk.S | ||
| __longjmp.S | ||
| _mcount.S | ||
| abort-instr.h | ||
| add_n.S | ||
| addmul_1.S | ||
| backtrace.c | ||
| bsd-_setjmp.S | ||
| bsd-setjmp.S | ||
| bzero.S | ||
| cacheinfo.c | ||
| configure | ||
| configure.ac | ||
| crti.S | ||
| crtn.S | ||
| dl-irel.h | ||
| dl-lookupcfg.h | ||
| dl-machine.h | ||
| dl-runtime.c | ||
| dl-tls.h | ||
| dl-tlsdesc.h | ||
| dl-tlsdesc.S | ||
| dl-trampoline.h | ||
| dl-trampoline.S | ||
| ffs.c | ||
| ffsll.c | ||
| hp-timing.h | ||
| htonl.S | ||
| Implies | ||
| jmpbuf-offsets.h | ||
| jmpbuf-unwind.h | ||
| l10nflist.c | ||
| ldbl2mpn.c | ||
| ldsodefs.h | ||
| link-defines.sym | ||
| locale-defines.sym | ||
| lshift.S | ||
| machine-gmon.h | ||
| Makefile | ||
| memchr.S | ||
| memcmp.S | ||
| memcpy_chk.S | ||
| memcpy.S | ||
| memmove.c | ||
| mempcpy_chk.S | ||
| mempcpy.S | ||
| memrchr.S | ||
| memset_chk.S | ||
| memset.S | ||
| memusage.h | ||
| mp_clz_tab.c | ||
| mul_1.S | ||
| preconfigure | ||
| preconfigure.ac | ||
| rawmemchr.S | ||
| rshift.S | ||
| rtld-memcmp.c | ||
| rtld-memset.S | ||
| rtld-strchr.S | ||
| rtld-strlen.S | ||
| sched_cpucount.c | ||
| setjmp.S | ||
| stack-aliasing.h | ||
| stackguard-macros.h | ||
| stackinfo.h | ||
| start.S | ||
| stpcpy_chk.S | ||
| stpcpy.S | ||
| strcasecmp_l-nonascii.c | ||
| strcasecmp_l.S | ||
| strcasecmp.S | ||
| strcat.S | ||
| strchr.S | ||
| strchrnul.S | ||
| strcmp.S | ||
| strcpy_chk.S | ||
| strcpy.S | ||
| strcspn.S | ||
| strlen.S | ||
| strncase_l-nonascii.c | ||
| strncase_l.S | ||
| strncase.S | ||
| strncmp.S | ||
| strnlen.S | ||
| strpbrk.S | ||
| strrchr.S | ||
| strspn.S | ||
| strtok_r.S | ||
| strtok.S | ||
| sub_n.S | ||
| submul_1.S | ||
| sysdep.h | ||
| tls-macros.h | ||
| tlsdesc.c | ||
| tlsdesc.sym | ||
| tst-audit3.c | ||
| tst-audit4.c | ||
| tst-audit5.c | ||
| tst-audit6.c | ||
| tst-audit7.c | ||
| tst-audit10.c | ||
| tst-audit.h | ||
| tst-auditmod3a.c | ||
| tst-auditmod3b.c | ||
| tst-auditmod4a.c | ||
| tst-auditmod4b.c | ||
| tst-auditmod5a.c | ||
| tst-auditmod5b.c | ||
| tst-auditmod6a.c | ||
| tst-auditmod6b.c | ||
| tst-auditmod6c.c | ||
| tst-auditmod7a.c | ||
| tst-auditmod7b.c | ||
| tst-auditmod10a.c | ||
| tst-auditmod10b.c | ||
| tst-mallocalign1.c | ||
| tst-quad1.c | ||
| tst-quad1pie.c | ||
| tst-quad2.c | ||
| tst-quad2pie.c | ||
| tst-quadmod1.S | ||
| tst-quadmod1pie.S | ||
| tst-quadmod2.S | ||
| tst-quadmod2pie.S | ||
| tst-stack-align.h | ||
| Versions | ||
| wcschr.S | ||
| wcscmp.S | ||
| wcslen.S | ||
| wcsrchr.S | ||