mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-13 06:40:09 +00:00
7a887dd537
GCC 11 -Warray-bounds triggers invalid warnings when building Linux timer_create.c: ../sysdeps/unix/sysv/linux/timer_create.c: In function '__timer_create_new': ../sysdeps/unix/sysv/linux/timer_create.c:83:17: warning: array subscript 'struct timer[0]' is partly outside array bounds of 'unsigned char[8]' [-Warray-bounds] 83 | newp->sigev_notify = (evp != NULL | ^~ ../sysdeps/unix/sysv/linux/timer_create.c:59:47: note: referencing an object of size 8 allocated by 'malloc' 59 | struct timer *newp = (struct timer *) malloc (offsetof (struct timer, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 60 | thrfunc)); | ~~~~~~~~~ The struct allocated for !SIGEV_THREAD timers only requires two 'int' fields (sigev_notify and ktimerid) and the offsetof trick tries minimize the memory usage by only allocation the required size. However, although the resulting size is suffice for !SIGEV_THREAD time, accessing the partially allocated object is error-prone and UB. This patch fixes both issues by embedding the information whether the timer if a SIGEV_THREAD in the returned 'timer_t'. For !SIGEV_THREAD, the resulting 'timer_t' is the returned kernel timer identifer (kernel_timer_t), while for SIGEV_THREAD it uses the fact malloc returns at least _Alignof (max_align_t) pointers plus that valid kernel_timer_t are always positive to set MSB bit of the returned 'timer_t' to indicate the timer handles a SIGEV_THREAD. It allows to remove the memory allocation for !SIGEV_THREAD and also remove the 'sigev_notify' field from 'struct timer'. Checked on x86_64-linux-gnu and i686-linux-gnu.
146 lines
4.3 KiB
C
146 lines
4.3 KiB
C
/* Copyright (C) 2003-2020 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Ulrich Drepper <drepper@redhat.com>, 2003.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public License as
|
|
published by the Free Software Foundation; either version 2.1 of the
|
|
License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; see the file COPYING.LIB. If
|
|
not, see <https://www.gnu.org/licenses/>. */
|
|
|
|
#include <errno.h>
|
|
#include <pthread.h>
|
|
#include <signal.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <time.h>
|
|
#include <sysdep.h>
|
|
#include <internaltypes.h>
|
|
#include <nptl/pthreadP.h>
|
|
#include "kernel-posix-timers.h"
|
|
#include "kernel-posix-cpu-timers.h"
|
|
|
|
|
|
#ifdef timer_create_alias
|
|
# define timer_create timer_create_alias
|
|
#endif
|
|
|
|
|
|
int
|
|
timer_create (clockid_t clock_id, struct sigevent *evp, timer_t *timerid)
|
|
{
|
|
#undef timer_create
|
|
{
|
|
clockid_t syscall_clockid = (clock_id == CLOCK_PROCESS_CPUTIME_ID
|
|
? MAKE_PROCESS_CPUCLOCK (0, CPUCLOCK_SCHED)
|
|
: clock_id == CLOCK_THREAD_CPUTIME_ID
|
|
? MAKE_THREAD_CPUCLOCK (0, CPUCLOCK_SCHED)
|
|
: clock_id);
|
|
|
|
/* If the user wants notification via a thread we need to handle
|
|
this special. */
|
|
if (evp == NULL
|
|
|| __builtin_expect (evp->sigev_notify != SIGEV_THREAD, 1))
|
|
{
|
|
struct sigevent local_evp;
|
|
|
|
if (evp == NULL)
|
|
{
|
|
/* The kernel has to pass up the timer ID which is a
|
|
userlevel object. Therefore we cannot leave it up to
|
|
the kernel to determine it. */
|
|
local_evp.sigev_notify = SIGEV_SIGNAL;
|
|
local_evp.sigev_signo = SIGALRM;
|
|
local_evp.sigev_value.sival_ptr = NULL;
|
|
|
|
evp = &local_evp;
|
|
}
|
|
|
|
kernel_timer_t ktimerid;
|
|
if (INLINE_SYSCALL_CALL (timer_create, syscall_clockid, evp,
|
|
&ktimerid) == -1)
|
|
return -1;
|
|
|
|
*timerid = kernel_timer_to_timerid (ktimerid);
|
|
}
|
|
else
|
|
{
|
|
/* Create the helper thread. */
|
|
pthread_once (&__helper_once, __start_helper_thread);
|
|
if (__helper_tid == 0)
|
|
{
|
|
/* No resources to start the helper thread. */
|
|
__set_errno (EAGAIN);
|
|
return -1;
|
|
}
|
|
|
|
struct timer *newp = malloc (sizeof (struct timer));
|
|
if (newp == NULL)
|
|
return -1;
|
|
|
|
/* Copy the thread parameters the user provided. */
|
|
newp->sival = evp->sigev_value;
|
|
newp->thrfunc = evp->sigev_notify_function;
|
|
|
|
/* We cannot simply copy the thread attributes since the
|
|
implementation might keep internal information for
|
|
each instance. */
|
|
pthread_attr_init (&newp->attr);
|
|
if (evp->sigev_notify_attributes != NULL)
|
|
{
|
|
struct pthread_attr *nattr;
|
|
struct pthread_attr *oattr;
|
|
|
|
nattr = (struct pthread_attr *) &newp->attr;
|
|
oattr = (struct pthread_attr *) evp->sigev_notify_attributes;
|
|
|
|
nattr->schedparam = oattr->schedparam;
|
|
nattr->schedpolicy = oattr->schedpolicy;
|
|
nattr->flags = oattr->flags;
|
|
nattr->guardsize = oattr->guardsize;
|
|
nattr->stackaddr = oattr->stackaddr;
|
|
nattr->stacksize = oattr->stacksize;
|
|
}
|
|
|
|
/* In any case set the detach flag. */
|
|
pthread_attr_setdetachstate (&newp->attr, PTHREAD_CREATE_DETACHED);
|
|
|
|
/* Create the event structure for the kernel timer. */
|
|
struct sigevent sev =
|
|
{ .sigev_value.sival_ptr = newp,
|
|
.sigev_signo = SIGTIMER,
|
|
.sigev_notify = SIGEV_SIGNAL | SIGEV_THREAD_ID,
|
|
._sigev_un = { ._pad = { [0] = __helper_tid } } };
|
|
|
|
/* Create the timer. */
|
|
int res;
|
|
res = INTERNAL_SYSCALL_CALL (timer_create, syscall_clockid, &sev,
|
|
&newp->ktimerid);
|
|
if (INTERNAL_SYSCALL_ERROR_P (res))
|
|
{
|
|
free (newp);
|
|
__set_errno (INTERNAL_SYSCALL_ERRNO (res));
|
|
return -1;
|
|
}
|
|
|
|
/* Add to the queue of active timers with thread delivery. */
|
|
pthread_mutex_lock (&__active_timer_sigev_thread_lock);
|
|
newp->next = __active_timer_sigev_thread;
|
|
__active_timer_sigev_thread = newp;
|
|
pthread_mutex_unlock (&__active_timer_sigev_thread_lock);
|
|
|
|
*timerid = timer_to_timerid (newp);
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|