mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-19 17:30:08 +00:00
7cbeabac0f
This patch removes the vsyscall usage for x86_64 port. As indicated by kernel code comments [1], vsyscalls are a legacy ABI and its concept is problematic: - It interferes with ASLR. - It's awkward to write code that lives in kernel addresses but is callable by userspace at fixed addresses. - The whole concept is impossible for 32-bit compat userspace. - UML cannot easily virtualize a vsyscall. The VDSO is a better approach for such functionality. Tested on i686, x86_64, and x32. * sysdeps/unix/sysv/linux/i386/gettimeofday.c (__gettimeofday_syscall): Remove vsyscall fallback. * sysdeps/unix/sysv/linux/i386/time.c (__time_syscall): Likewise. * sysdeps/unix/sysv/linux/x86/gettimeofday.c (__gettimeofday_syscall): Add syscall fallback function. (gettimeofday_ifunc): Use __gettimeofday_syscall as fallback mechanism if vDSO is not present. * sysdeps/unix/sysv/linux/x86/time.c (__time_syscall): Add syscall fallback function. (time_ifunc): Use __time_syscall as fallback mechanism if vDSO is not present. * sysdeps/unix/sysv/linux/x86_64/gettimeofday.c: Remove file. * sysdeps/unix/sysv/linux/x86_64/time.c: Likewise. [1] arch/x86/kernel/vsyscall_64.c
60 lines
1.5 KiB
C
60 lines
1.5 KiB
C
/* time -- Get number of seconds since Epoch. Linux/x86 version.
|
|
Copyright (C) 2015 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <time.h>
|
|
|
|
#ifdef SHARED
|
|
|
|
#include <dl-vdso.h>
|
|
#include <errno.h>
|
|
|
|
static time_t
|
|
__time_syscall (time_t *t)
|
|
{
|
|
INTERNAL_SYSCALL_DECL (err);
|
|
return INTERNAL_SYSCALL (time, err, 1, t);
|
|
}
|
|
|
|
void *time_ifunc (void) __asm__ ("time");
|
|
|
|
void *
|
|
time_ifunc (void)
|
|
{
|
|
PREPARE_VERSION_KNOWN (linux26, LINUX_2_6);
|
|
|
|
/* If the vDSO is not available we fall back on the syscall. */
|
|
return _dl_vdso_vsym ("__vdso_time", &linux26)
|
|
?: (void*) &__time_syscall;
|
|
}
|
|
asm (".type time, %gnu_indirect_function");
|
|
|
|
libc_ifunc_hidden_def(time)
|
|
|
|
#else
|
|
|
|
# include <sysdep.h>
|
|
|
|
time_t
|
|
time (time_t *t)
|
|
{
|
|
INTERNAL_SYSCALL_DECL (err);
|
|
return INTERNAL_SYSCALL (time, err, 1, t);
|
|
}
|
|
|
|
#endif
|