mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-23 13:30:06 +00:00
a5f891ac8d
In <https://sourceware.org/ml/libc-alpha/2014-01/msg00196.html> I noted it was necessary to add includes of Makeconfig early in various subdirectory makefiles for the tests-special variable settings added by that patch to be conditional on configuration information. No-one commented on the general question there of whether Makeconfig should always be included immediately after the definition of subdir. This patch implements that early inclusion of Makeconfig in each directory (which is a lot easier than consistent placement of includes of Rules). Includes are added if needed, or moved up if already present. Subdirectory "all:" targets are removed, since Makeconfig provides one. There is potential for further cleanups I haven't done. Rules and Makerules have code such as ifneq "$(findstring env,$(origin headers))" "" headers := endif to override to empty any value of various variables that came from the environment. I think there is a case for Makeconfig setting all the subdirectory variables (other than subdir) to empty to ensure no outside value is going to take effect if a subdirectory fails to define a variable. (A list of such variables, possibly out of date and incomplete, is in manual/maint.texi.) Rules and Makerules would give errors if Makeconfig hadn't already been included, instead of including it themselves. The special code to override values coming from the environment would then be obsolete and could be removed. Tested x86_64, including that installed binaries are identical before and after the patch. * argp/Makefile: Include Makeconfig immediately after defining subdir. * assert/Makefile: Likewise. * benchtests/Makefile: Likewise. * catgets/Makefile: Likewise. * conform/Makefile: Likewise. * crypt/Makefile: Likewise. * csu/Makefile: Likewise. (all): Remove target. * ctype/Makefile: Include Makeconfig immediately after defining subdir. * debug/Makefile: Likewise. * dirent/Makefile: Likewise. * dlfcn/Makefile: Likewise. * gmon/Makefile: Likewise. * gnulib/Makefile: Likewise. * grp/Makefile: Likewise. * gshadow/Makefile: Likewise. * hesiod/Makefile: Likewise. * hurd/Makefile: Likewise. (all): Remove target. * iconvdata/Makefile: Include Makeconfig immediately after defining subdir. * inet/Makefile: Likewise. * intl/Makefile: Likewise. * io/Makefile: Likewise. * libio/Makefile: Likewise. (all): Remove target. * locale/Makefile: Include Makeconfig immediately after defining subdir. * login/Makefile: Likewise. * mach/Makefile: Likewise. (all): Remove target. * malloc/Makefile: Include Makeconfig immediately after defining subdir. (all): Remove target. * manual/Makefile: Include Makeconfig immediately after defining subdir. * math/Makefile: Likewise. * misc/Makefile: Likewise. * nis/Makefile: Likewise. * nss/Makefile: Likewise. * po/Makefile: Likewise. (all): Remove target. * posix/Makefile: Include Makeconfig immediately after defining subdir. * pwd/Makefile: Likewise. * resolv/Makefile: Likewise. * resource/Makefile: Likewise. * rt/Makefile: Likewise. * setjmp/Makefile: Likewise. * shadow/Makefile: Likewise. * signal/Makefile: Likewise. * socket/Makefile: Likewise. * soft-fp/Makefile: Likewise. * stdio-common/Makefile: Likewise. * stdlib/Makefile: Likewise. * streams/Makefile: Likewise. * string/Makefile: Likewise. * sunrpc/Makefile: Likewise. (all): Remove target. * sysvipc/Makefile: Include Makeconfig immediately after defining subdir. * termios/Makefile: Likewise. * time/Makefile: Likewise. * timezone/Makefile: Likewise. (all): Remove target. * wcsmbs/Makefile: Include Makeconfig immediately after defining subdir. * wctype/Makefile: Likewise. libidn/ChangeLog: * Makefile: Include Makeconfig immediately after defining subdir. localedata/ChangeLog: * Makefile: Include Makeconfig immediately after defining subdir. (all): Remove target. nptl/ChangeLog: * Makefile: Include Makeconfig immediately after defining subdir. nptl_db/ChangeLog: * Makefile: Include Makeconfig immediately after defining subdir. |
||
|---|---|---|
| .. | ||
| nss_compat | ||
| nss_nis | ||
| nss_nisplus | ||
| rpcsvc | ||
| Depend | ||
| libnsl.h | ||
| Makefile | ||
| nis_add.c | ||
| nis_addmember.c | ||
| nis_call.c | ||
| nis_callback.c | ||
| nis_checkpoint.c | ||
| nis_clone_dir.c | ||
| nis_clone_obj.c | ||
| nis_clone_res.c | ||
| nis_creategroup.c | ||
| nis_defaults.c | ||
| nis_destroygroup.c | ||
| nis_domain_of_r.c | ||
| nis_domain_of.c | ||
| nis_error.c | ||
| nis_error.h | ||
| nis_file.c | ||
| nis_findserv.c | ||
| nis_free.c | ||
| nis_getservlist.c | ||
| nis_hash.c | ||
| nis_intern.h | ||
| nis_ismember.c | ||
| nis_local_names.c | ||
| nis_lookup.c | ||
| nis_mkdir.c | ||
| nis_modify.c | ||
| nis_ping.c | ||
| nis_print_group_entry.c | ||
| nis_print.c | ||
| nis_remove.c | ||
| nis_removemember.c | ||
| nis_rmdir.c | ||
| nis_server.c | ||
| nis_subr.c | ||
| nis_table.c | ||
| nis_util.c | ||
| nis_verifygroup.c | ||
| nis_xdr.c | ||
| nis_xdr.h | ||
| nisplus-parser.h | ||
| nss | ||
| nss-default.c | ||
| nss-nis.c | ||
| nss-nis.h | ||
| nss-nisplus.c | ||
| nss-nisplus.h | ||
| Versions | ||
| yp_xdr.c | ||
| ypclnt.c | ||
| ypupdate_xdr.c | ||