mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-11 13:50:06 +00:00
f0458cf4f9
Linux from 3.9 through 4.2 does not abort HTM transaction on syscalls, instead it suspend and resume it when leaving the kernel. The side-effects of the syscall will always remain visible, even if the transaction is aborted. This is an issue when transaction is used along with futex syscall, on pthread_cond_wait for instance, where the futex call might succeed but the transaction is rolled back leading the pthread_cond object in an inconsistent state. Glibc used to prevent it by always aborting a transaction before issuing a syscall. Linux 4.2 also decided to abort active transaction in syscalls which makes the glibc workaround superfluous. Worse, glibc transaction abortion leads to a performance issue on recent kernels where the HTM state is saved/restore lazily (v4.9). By aborting a transaction on every syscalls, regardless whether a transaction has being initiated before, GLIBS makes the kernel always save/restore HTM state (it can not even lazily disable it after a certain number of syscall iterations). Because of this shortcoming, Transactional Lock Elision is just enabled when it has been explicitly set (either by tunables of by a configure switch) and if kernel aborts HTM transactions on syscalls (PPC_FEATURE2_HTM_NOSC). It is reported that using simple benchmark [1], the context-switch is about 5% faster by not issuing a tabort in every syscall in newer kernels. Checked on powerpc64le-linux-gnu with 4.4.0 kernel (Ubuntu 16.04). * NEWS: Add note about new TLE support on powerpc64le. * sysdeps/powerpc/nptl/tcb-offsets.sym (TM_CAPABLE): Remove. * sysdeps/powerpc/nptl/tls.h (tcbhead_t): Rename tm_capable to __ununsed1. (TLS_INIT_TP, TLS_DEFINE_INIT_TP): Remove tm_capable setup. (THREAD_GET_TM_CAPABLE, THREAD_SET_TM_CAPABLE): Remove macros. * sysdeps/powerpc/powerpc32/sysdep.h, sysdeps/powerpc/powerpc64/sysdep.h (ABORT_TRANSACTION_IMPL, ABORT_TRANSACTION): Remove macros. * sysdeps/powerpc/sysdep.h (ABORT_TRANSACTION): Likewise. * sysdeps/unix/sysv/linux/powerpc/elision-conf.c (elision_init): Set __pthread_force_elision iff PPC_FEATURE2_HTM_NOSC is set. * sysdeps/unix/sysv/linux/powerpc/powerpc32/sysdep.h, sysdeps/unix/sysv/linux/powerpc/powerpc64/sysdep.h sysdeps/unix/sysv/linux/powerpc/syscall.S (ABORT_TRANSACTION): Remove usage. * sysdeps/unix/sysv/linux/powerpc/not-errno.h: Remove file. Reported-by: Breno Leitão <leitao@debian.org>
167 lines
6.3 KiB
C
167 lines
6.3 KiB
C
/* elision-conf.c: Lock elision tunable parameters.
|
|
Copyright (C) 2015-2018 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include "config.h"
|
|
#include <pthreadP.h>
|
|
#include <elision-conf.h>
|
|
#include <unistd.h>
|
|
#include <dl-procinfo.h>
|
|
|
|
#if HAVE_TUNABLES
|
|
# define TUNABLE_NAMESPACE elision
|
|
#endif
|
|
#include <elf/dl-tunables.h>
|
|
|
|
/* Reasonable initial tuning values, may be revised in the future.
|
|
This is a conservative initial value. */
|
|
|
|
struct elision_config __elision_aconf =
|
|
{
|
|
/* How many times to use a non-transactional lock after a transactional
|
|
failure has occurred because the lock is already acquired. Expressed
|
|
in number of lock acquisition attempts. */
|
|
.skip_lock_busy = 3,
|
|
/* How often to not attempt to use elision if a transaction aborted due
|
|
to reasons other than other threads' memory accesses. Expressed in
|
|
number of lock acquisition attempts. */
|
|
.skip_lock_internal_abort = 3,
|
|
/* How often to not attempt to use elision if a lock used up all retries
|
|
without success. Expressed in number of lock acquisition attempts. */
|
|
.skip_lock_out_of_tbegin_retries = 3,
|
|
/* How often we retry using elision if there is chance for the transaction
|
|
to finish execution (e.g., it wasn't aborted due to the lock being
|
|
already acquired. */
|
|
.try_tbegin = 3,
|
|
/* Same as SKIP_LOCK_INTERNAL_ABORT but for trylock. */
|
|
.skip_trylock_internal_abort = 3,
|
|
};
|
|
|
|
/* Force elision for all new locks. This is used to decide whether existing
|
|
DEFAULT locks should be automatically use elision in pthread_mutex_lock().
|
|
Disabled for suid programs. Only used when elision is available. */
|
|
|
|
int __pthread_force_elision attribute_hidden = 0;
|
|
|
|
#if HAVE_TUNABLES
|
|
static inline void
|
|
__always_inline
|
|
do_set_elision_enable (int32_t elision_enable)
|
|
{
|
|
/* Enable elision if it's avaliable in hardware. It's not necessary to check
|
|
if __libc_enable_secure isn't enabled since elision_enable will be set
|
|
according to the default, which is disabled. */
|
|
if (elision_enable == 1)
|
|
__pthread_force_elision = (GLRO (dl_hwcap2)
|
|
& PPC_FEATURE2_HAS_HTM) ? 1 : 0;
|
|
}
|
|
|
|
/* The pthread->elision_enable tunable is 0 or 1 indicating that elision
|
|
should be disabled or enabled respectively. The feature will only be used
|
|
if it's supported by the hardware. */
|
|
|
|
void
|
|
TUNABLE_CALLBACK (set_elision_enable) (tunable_val_t *valp)
|
|
{
|
|
int32_t elision_enable = (int32_t) valp->numval;
|
|
do_set_elision_enable (elision_enable);
|
|
}
|
|
|
|
#define TUNABLE_CALLBACK_FNDECL(__name, __type) \
|
|
static inline void \
|
|
__always_inline \
|
|
do_set_elision_ ## __name (__type value) \
|
|
{ \
|
|
__elision_aconf.__name = value; \
|
|
} \
|
|
void \
|
|
TUNABLE_CALLBACK (set_elision_ ## __name) (tunable_val_t *valp) \
|
|
{ \
|
|
__type value = (__type) (valp)->numval; \
|
|
do_set_elision_ ## __name (value); \
|
|
}
|
|
|
|
TUNABLE_CALLBACK_FNDECL (skip_lock_busy, int32_t);
|
|
TUNABLE_CALLBACK_FNDECL (skip_lock_internal_abort, int32_t);
|
|
TUNABLE_CALLBACK_FNDECL (skip_lock_out_of_tbegin_retries, int32_t);
|
|
TUNABLE_CALLBACK_FNDECL (try_tbegin, int32_t);
|
|
TUNABLE_CALLBACK_FNDECL (skip_trylock_internal_abort, int32_t);
|
|
#endif
|
|
|
|
/* Initialize elision. */
|
|
|
|
static void
|
|
elision_init (int argc __attribute__ ((unused)),
|
|
char **argv __attribute__ ((unused)),
|
|
char **environ)
|
|
{
|
|
#if HAVE_TUNABLES
|
|
/* Elision depends on tunables and must be explicitly turned on by setting
|
|
the appropriate tunable on a supported platform. */
|
|
|
|
TUNABLE_GET (enable, int32_t,
|
|
TUNABLE_CALLBACK (set_elision_enable));
|
|
TUNABLE_GET (skip_lock_busy, int32_t,
|
|
TUNABLE_CALLBACK (set_elision_skip_lock_busy));
|
|
TUNABLE_GET (skip_lock_internal_abort, int32_t,
|
|
TUNABLE_CALLBACK (set_elision_skip_lock_internal_abort));
|
|
TUNABLE_GET (skip_lock_after_retries, int32_t,
|
|
TUNABLE_CALLBACK (set_elision_skip_lock_out_of_tbegin_retries));
|
|
TUNABLE_GET (tries, int32_t,
|
|
TUNABLE_CALLBACK (set_elision_try_tbegin));
|
|
TUNABLE_GET (skip_trylock_internal_abort, int32_t,
|
|
TUNABLE_CALLBACK (set_elision_skip_trylock_internal_abort));
|
|
#endif
|
|
|
|
/* Linux from 3.9 through 4.2 do not abort HTM transaction on syscalls,
|
|
instead it suspends the transaction and resumes it when returning to
|
|
usercode. The side-effects of the syscall will always remain visible,
|
|
even if the transaction is aborted. This is an issue when a transaction
|
|
is used along with futex syscall, on pthread_cond_wait for instance,
|
|
where futex might succeed but the transaction is rolled back leading
|
|
the condition variable object in an inconsistent state.
|
|
|
|
Glibc used to prevent it by always aborting a transaction before issuing
|
|
a syscall. Linux 4.2 also decided to abort active transaction in
|
|
syscalls which makes the glibc workaround superflours. Worse, glibc
|
|
transaction abortions leads to a performance issues on recent kernels.
|
|
|
|
So Lock Elision is just enabled when it has been explict set (either
|
|
by tunables of by a configure switch) and if kernel aborts HTM
|
|
transactions on syscalls (PPC_FEATURE2_HTM_NOSC) */
|
|
|
|
__pthread_force_elision = (__pthread_force_elision
|
|
&& GLRO (dl_hwcap2) & PPC_FEATURE2_HTM_NOSC);
|
|
|
|
if (!__pthread_force_elision)
|
|
__elision_aconf.try_tbegin = 0; /* Disable elision on rwlocks. */
|
|
}
|
|
|
|
#ifdef SHARED
|
|
# define INIT_SECTION ".init_array"
|
|
# define MAYBE_CONST
|
|
#else
|
|
# define INIT_SECTION ".preinit_array"
|
|
# define MAYBE_CONST const
|
|
#endif
|
|
|
|
void (*MAYBE_CONST __pthread_init_array []) (int, char **, char **)
|
|
__attribute__ ((section (INIT_SECTION), aligned (sizeof (void *)))) =
|
|
{
|
|
&elision_init
|
|
};
|