mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-29 00:01:12 +00:00
b0969fa53a
Previous implementation was adjusting length (rsi) to match bytes (eax), but since there is no bound to length this can cause overflow. Fix is to just convert the byte-count (eax) to length by dividing by sizeof (wchar_t) before the comparison. Full check passes on x86-64 and build succeeds w/ and w/o multiarch.
339 lines
8.9 KiB
C
339 lines
8.9 KiB
C
/* Test strlen functions.
|
|
Copyright (C) 1999-2022 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#define TEST_MAIN
|
|
#ifndef WIDE
|
|
# define TEST_NAME "strnlen"
|
|
#else
|
|
# define TEST_NAME "wcsnlen"
|
|
#endif /* !WIDE */
|
|
#include "test-string.h"
|
|
|
|
#ifndef WIDE
|
|
# define STRNLEN strnlen
|
|
# define MEMSET memset
|
|
# define CHAR char
|
|
# define BIG_CHAR CHAR_MAX
|
|
# define MIDDLE_CHAR 127
|
|
# define SIMPLE_STRNLEN simple_strnlen
|
|
#else
|
|
# include <wchar.h>
|
|
# define STRNLEN wcsnlen
|
|
# define MEMSET wmemset
|
|
# define CHAR wchar_t
|
|
# define BIG_CHAR WCHAR_MAX
|
|
# define MIDDLE_CHAR 1121
|
|
# define SIMPLE_STRNLEN simple_wcsnlen
|
|
#endif /* !WIDE */
|
|
|
|
typedef size_t (*proto_t) (const CHAR *, size_t);
|
|
|
|
IMPL (STRNLEN, 1)
|
|
|
|
/* Naive implementation to verify results. */
|
|
size_t
|
|
SIMPLE_STRNLEN (const CHAR *s, size_t maxlen)
|
|
{
|
|
size_t i;
|
|
|
|
for (i = 0; i < maxlen && s[i]; ++i);
|
|
return i;
|
|
}
|
|
|
|
static void
|
|
do_one_test (impl_t *impl, const CHAR *s, size_t maxlen, size_t exp_len)
|
|
{
|
|
size_t len = CALL (impl, s, maxlen);
|
|
if (len != exp_len)
|
|
{
|
|
error (0, 0, "Wrong result in function %s %zd %zd", impl->name,
|
|
len, exp_len);
|
|
ret = 1;
|
|
return;
|
|
}
|
|
}
|
|
|
|
static void
|
|
do_test (size_t align, size_t len, size_t maxlen, int max_char)
|
|
{
|
|
size_t i;
|
|
|
|
align &= (getpagesize () / sizeof (CHAR) - 1);
|
|
if ((align + len) * sizeof (CHAR) >= page_size)
|
|
return;
|
|
|
|
CHAR *buf = (CHAR *) (buf1);
|
|
|
|
for (i = 0; i < len; ++i)
|
|
buf[align + i] = 1 + 11111 * i % max_char;
|
|
buf[align + len] = 0;
|
|
|
|
FOR_EACH_IMPL (impl, 0)
|
|
do_one_test (impl, (CHAR *) (buf + align), maxlen, MIN (len, maxlen));
|
|
}
|
|
|
|
static void
|
|
do_overflow_tests (void)
|
|
{
|
|
size_t i, j, al_idx, repeats, len;
|
|
const size_t one = 1;
|
|
uintptr_t buf_addr = (uintptr_t) buf1;
|
|
const size_t alignments[] = { 0, 1, 7, 9, 31, 33, 63, 65, 95, 97, 127, 129 };
|
|
|
|
for (al_idx = 0; al_idx < sizeof (alignments) / sizeof (alignments[0]);
|
|
al_idx++)
|
|
{
|
|
for (repeats = 0; repeats < 2; ++repeats)
|
|
{
|
|
size_t align = repeats ? (getpagesize () - alignments[al_idx])
|
|
: alignments[al_idx];
|
|
align /= sizeof (CHAR);
|
|
for (i = 0; i < 750; ++i)
|
|
{
|
|
do_test (align, i, SIZE_MAX, BIG_CHAR);
|
|
|
|
do_test (align, i, SIZE_MAX - i, BIG_CHAR);
|
|
do_test (align, i, i - buf_addr, BIG_CHAR);
|
|
do_test (align, i, -buf_addr - i, BIG_CHAR);
|
|
do_test (align, i, SIZE_MAX - buf_addr - i, BIG_CHAR);
|
|
do_test (align, i, SIZE_MAX - buf_addr + i, BIG_CHAR);
|
|
|
|
len = 0;
|
|
for (j = 8 * sizeof (size_t) - 1; j; --j)
|
|
{
|
|
len |= one << j;
|
|
do_test (align, i, len, BIG_CHAR);
|
|
do_test (align, i, len - i, BIG_CHAR);
|
|
do_test (align, i, len + i, BIG_CHAR);
|
|
do_test (align, i, len - buf_addr - i, BIG_CHAR);
|
|
do_test (align, i, len - buf_addr + i, BIG_CHAR);
|
|
|
|
do_test (align, i, ~len - i, BIG_CHAR);
|
|
do_test (align, i, ~len + i, BIG_CHAR);
|
|
do_test (align, i, ~len - buf_addr - i, BIG_CHAR);
|
|
do_test (align, i, ~len - buf_addr + i, BIG_CHAR);
|
|
|
|
do_test (align, i, -buf_addr, BIG_CHAR);
|
|
do_test (align, i, j - buf_addr, BIG_CHAR);
|
|
do_test (align, i, -buf_addr - j, BIG_CHAR);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
static void
|
|
do_random_tests (void)
|
|
{
|
|
size_t i, j, n, align, len;
|
|
CHAR *p = (CHAR *) (buf1 + page_size - 512 * sizeof (CHAR));
|
|
|
|
for (n = 0; n < ITERATIONS; n++)
|
|
{
|
|
align = random () & 15;
|
|
len = random () & 511;
|
|
if (len + align > 510)
|
|
len = 511 - align - (random () & 7);
|
|
j = len + align + 64;
|
|
if (j > 512)
|
|
j = 512;
|
|
|
|
for (i = 0; i < j; i++)
|
|
{
|
|
if (i == len + align)
|
|
p[i] = 0;
|
|
else
|
|
{
|
|
p[i] = random () & 255;
|
|
if (i >= align && i < len + align && !p[i])
|
|
p[i] = (random () & 127) + 1;
|
|
}
|
|
}
|
|
|
|
FOR_EACH_IMPL (impl, 1)
|
|
{
|
|
if (len > 0
|
|
&& CALL (impl, (CHAR *) (p + align), len - 1) != len - 1)
|
|
{
|
|
error (0, 0, "Iteration %zd (limited) - wrong result in function %s (%zd) %zd != %zd, p %p",
|
|
n, impl->name, align,
|
|
CALL (impl, (CHAR *) (p + align), len - 1), len - 1, p);
|
|
ret = 1;
|
|
}
|
|
if (CALL (impl, (CHAR *) (p + align), len) != len)
|
|
{
|
|
error (0, 0, "Iteration %zd (exact) - wrong result in function %s (%zd) %zd != %zd, p %p",
|
|
n, impl->name, align,
|
|
CALL (impl, (CHAR *) (p + align), len), len, p);
|
|
ret = 1;
|
|
}
|
|
if (CALL (impl, (CHAR *) (p + align), len + 1) != len)
|
|
{
|
|
error (0, 0, "Iteration %zd (long) - wrong result in function %s (%zd) %zd != %zd, p %p",
|
|
n, impl->name, align,
|
|
CALL (impl, (CHAR *) (p + align), len + 1), len, p);
|
|
ret = 1;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Tests meant to unveil fail on implementation that does not access bytes
|
|
around the page boundary accordingly. */
|
|
static void
|
|
do_page_tests (void)
|
|
{
|
|
size_t i, exp_len, start_offset, offset;
|
|
/* Calculate the null character offset. */
|
|
size_t last_offset = (page_size / sizeof (CHAR)) - 1;
|
|
|
|
CHAR *s = (CHAR *) buf2;
|
|
MEMSET (s, 65, (last_offset - 1));
|
|
s[last_offset] = 0;
|
|
|
|
/* Place short strings ending at page boundary. */
|
|
offset = last_offset;
|
|
for (i = 0; i < 128; i++)
|
|
{
|
|
/* Decrease offset to stress several sizes and alignments. */
|
|
offset--;
|
|
exp_len = last_offset - offset;
|
|
FOR_EACH_IMPL (impl, 0)
|
|
{
|
|
/* Varies maxlen value to cover the cases where it is:
|
|
- larger than length;
|
|
- slightly greater than length;
|
|
- equal to length;
|
|
- slightly less than length. */
|
|
do_one_test (impl, (CHAR *) (s + offset), page_size, exp_len);
|
|
do_one_test (impl, (CHAR *) (s + offset), exp_len + 1, exp_len);
|
|
do_one_test (impl, (CHAR *) (s + offset), exp_len, exp_len);
|
|
if (exp_len > 0)
|
|
do_one_test (impl, (CHAR *) (s + offset), exp_len - 1, exp_len - 1);
|
|
}
|
|
}
|
|
|
|
/* Place long strings ending at page boundary. */
|
|
start_offset = (last_offset + 1) / 2;
|
|
for (i = 0; i < 64; ++i)
|
|
{
|
|
/* Increase offset to stress several alignments. */
|
|
offset = start_offset + i;
|
|
if (offset >= (last_offset + 1))
|
|
break;
|
|
exp_len = last_offset - offset;
|
|
FOR_EACH_IMPL (impl, 0)
|
|
{
|
|
/* Checks only for maxlen much larger than length because smaller
|
|
values are already covered in do_random_tests function. */
|
|
do_one_test (impl, (CHAR *) (s + offset), page_size, exp_len);
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Tests meant to unveil fail on implementations that access bytes
|
|
beyond the maxium length. */
|
|
|
|
static void
|
|
do_page_2_tests (void)
|
|
{
|
|
size_t i, exp_len, offset;
|
|
size_t last_offset = page_size / sizeof (CHAR);
|
|
|
|
CHAR *s = (CHAR *) buf2;
|
|
MEMSET (s, 65, last_offset);
|
|
|
|
/* Place short strings ending at page boundary without the null
|
|
byte. */
|
|
offset = last_offset;
|
|
for (i = 0; i < 128; i++)
|
|
{
|
|
/* Decrease offset to stress several sizes and alignments. */
|
|
offset--;
|
|
exp_len = last_offset - offset;
|
|
FOR_EACH_IMPL (impl, 0)
|
|
{
|
|
/* If an implementation goes beyond EXP_LEN, it will trigger
|
|
the segfault. */
|
|
do_one_test (impl, (CHAR *) (s + offset), exp_len, exp_len);
|
|
}
|
|
}
|
|
}
|
|
|
|
int
|
|
test_main (void)
|
|
{
|
|
size_t i, length, char_per_page;
|
|
|
|
test_init ();
|
|
|
|
printf ("%20s", "");
|
|
FOR_EACH_IMPL (impl, 0)
|
|
printf ("\t%s", impl->name);
|
|
putchar ('\n');
|
|
|
|
for (i = 1; i < 8; ++i)
|
|
{
|
|
do_test (0, i, i - 1, MIDDLE_CHAR);
|
|
do_test (0, i, i, MIDDLE_CHAR);
|
|
do_test (0, i, i + 1, MIDDLE_CHAR);
|
|
}
|
|
|
|
for (i = 1; i < 8; ++i)
|
|
{
|
|
do_test (i, i, i - 1, MIDDLE_CHAR);
|
|
do_test (i, i, i, MIDDLE_CHAR);
|
|
do_test (i, i, i + 1, MIDDLE_CHAR);
|
|
}
|
|
|
|
for (i = 2; i <= 10; ++i)
|
|
{
|
|
do_test (0, 1 << i, 5000, MIDDLE_CHAR);
|
|
do_test (1, 1 << i, 5000, MIDDLE_CHAR);
|
|
}
|
|
|
|
for (i = 1; i < 8; ++i)
|
|
do_test (0, i, 5000, BIG_CHAR);
|
|
|
|
for (i = 1; i < 8; ++i)
|
|
do_test (i, i, 5000, BIG_CHAR);
|
|
|
|
for (i = 2; i <= 10; ++i)
|
|
{
|
|
do_test (0, 1 << i, 5000, BIG_CHAR);
|
|
do_test (1, 1 << i, 5000, BIG_CHAR);
|
|
}
|
|
|
|
char_per_page = getpagesize () / sizeof (CHAR);
|
|
|
|
for (i = 0; i <= 127; i++)
|
|
for (length = i; length <= 512; length++)
|
|
{
|
|
do_test (i, length, 512, BIG_CHAR);
|
|
do_test (char_per_page - i, length, 512, BIG_CHAR);
|
|
}
|
|
|
|
do_random_tests ();
|
|
do_page_tests ();
|
|
do_page_2_tests ();
|
|
do_overflow_tests ();
|
|
return ret;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|