Siddhesh Poyarekar e938c02748 Don't add access size hints to fortifiable functions ... In the context of a function definition, the size hints imply that the size of an object pointed to by one parameter is another parameter. This doesn't make sense for the fortified versions of the functions since that's the bit it's trying to validate. This is harmless with __builtin_object_size since it has fairly simple semantics when it comes to objects passed as function parameters. With __builtin_dynamic_object_size we could (as my patchset for gcc[1] already does) use the access attribute to determine the object size in the general case but it misleads the fortified functions. Basically the problem occurs when access attributes are present on regular functions that have inline fortified definitions to generate _chk variants; the attributes get inherited by these definitions, causing problems when analyzing them. For example with poll(fds, nfds, timeout), nfds is hinted using the __attr_access as being the size of fds. Now, when analyzing the inline function definition in bits/poll2.h, the compiler sees that nfds is the size of fds and tries to use that information in the function body. In _FORTIFY_SOURCE=3 case, where the object size could be a non-constant expression, this information results in the conclusion that nfds is the size of fds, which defeats the purpose of the implementation because we're trying to check here if nfds does indeed represent the size of fds. Hence for this case, it is best to not have the access attribute. With the attributes gone, the expression evaluation should get delayed until the function is actually inlined into its destinations. Disable the access attribute for fortified function inline functions when building at _FORTIFY_SOURCE=3 to make this work better. The access attributes remain for the _chk variants since they can be used by the compiler to warn when the caller is passing invalid arguments. [1] https://gcc.gnu.org/pipermail/gcc-patches/2021-October/581125.html Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>		2021-10-20 08:33:31 +05:30
..
bits	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
sys	Don't add access size hints to fortifiable functions	2021-10-20 08:33:31 +05:30
acct.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
allocate_once.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ar.h	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
brk.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
bug18240.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
bug-hsearch1.c	..	2009-01-23 20:41:36 +00:00
chflags.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
chroot.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
daemon.c	Remove internal usage of extensible stat functions	2020-09-11 14:35:32 -03:00
dirname.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
efgcvt_r-template.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
efgcvt_r.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
efgcvt-dbl-macros.h	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
efgcvt-ldbl-macros.h	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
efgcvt-template.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
efgcvt.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
err.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
err.h	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
error.c	nptl: Move pthread_setcancelstate into libc	2021-04-21 19:49:50 +02:00
error.h	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fchflags.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fd_to_filename.c	misc: use _fitoa_word to implement __fd_to_filename.	2021-05-07 13:54:36 -03:00
fdatasync.c	Add hidden prototypes for fsync, fdatasync	2021-06-22 09:51:14 +02:00
fgetxattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
flistxattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fremovexattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fsetxattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fstab.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fstab.h	Remove pre-ISO C support	2012-01-07 23:57:22 -05:00
fsync.c	Add hidden prototypes for fsync, fdatasync	2021-06-22 09:51:14 +02:00
ftruncate64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ftruncate.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
futimes.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
futimesat.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getauxval.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getclktck.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getdomain.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getdtsz.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
gethostid.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
gethostname.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getloadavg.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getpagesize.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getpass.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getsysstats.c	misc: Add __get_nprocs_sched	2021-09-27 09:13:06 -03:00
getttyent.c	Fix -Os getc_unlocked linknamespace, localplt issues (bug 15105, bug 19463).	2018-02-21 18:01:11 +00:00
getusershell.c	Remove internal usage of extensible stat functions	2020-09-11 14:35:32 -03:00
getxattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
gtty.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
hsearch_r.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
hsearch.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
ifunc-impl-list.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
init-misc.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
insremque.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ioctl.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
lgetxattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
libgen.h	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
listxattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
llistxattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
lremovexattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
lsearch.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
lsetxattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
lutimes.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
madvise.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
makedev.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
Makefile	Move malloc hooks into a compat DSO	2021-07-22 18:37:59 +05:30
mincore.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mkdtemp.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mkostemp64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mkostemp.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mkostemps64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mkostemps.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mkstemp64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mkstemp.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mkstemps64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mkstemps.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mktemp.c	nptl: Move sem_close, sem_open into libc	2021-05-05 17:19:38 +02:00
mlock.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mlockall.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mmap64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mmap.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mntent_r.c	mntent: Use __putc_unlocked instead of fputc_unlocked	2021-01-08 21:02:12 +05:30
mntent.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mntent.h	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
mprotect.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
msync.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
munlock.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
munlockall.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
munmap.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
preadv2.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
preadv64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
preadv64v2.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
preadv.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
pselect.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
ptrace.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
pwritev2.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
pwritev64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
pwritev64v2.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
pwritev.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
qefgcvt_r.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
qefgcvt.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
readv.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
reboot.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
regexp.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
regexp.h	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
remap_file_pages.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
removexattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
revoke.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
sbrk.c	Use hidden visibility for early static PIE code	2021-01-21 15:55:01 +00:00
search.h	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
select.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
setdomain.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
setegid.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
seteuid.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
sethostid.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
sethostname.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
setregid.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
setreuid.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
setxattr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
sgtty.h	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
single_threaded.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
sstk.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
stab.h	Update.	1997-06-21 02:59:26 +00:00
stty.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
swapoff.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
swapon.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
sync.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
syncfs.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
syscall.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
syscall.h	update from main archive 960107	1997-01-07 23:29:44 +00:00
sysexits.h	Update.	1999-06-09 13:08:30 +00:00
syslog.c	misc: syslog: Use static const for AF_UNIX address	2021-04-15 11:32:40 -03:00
syslog.h	initial import	1995-02-18 01:27:10 +00:00
truncate64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
truncate.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tsearch.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst-allocate_once.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-atomic-long.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst-atomic.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst-dbl-efgcvt.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-dirname.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst-efgcvt-template.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-empty.c	Move all tests out of the csu subdirectory	2016-12-21 11:52:19 +01:00
tst-error1.c	Split DIAG_* macros to new header libc-diag.h.	2017-02-25 09:59:46 -05:00
tst-fd_to_filename.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-fdset.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst-gethostid.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-hsearch.c	Modify several tests to use test-skeleton.c	2014-11-05 15:24:08 +05:30
tst-insremque.c	[BZ #2766]	2006-06-17 17:01:42 +00:00
tst-ioctl-time64.c	misc: Add time64 alias for ioctl	2021-07-21 11:58:09 +02:00
tst-ioctl.c	misc: Add time64 alias for ioctl	2021-07-21 11:58:09 +02:00
tst-ldbl-efgcvt.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-ldbl-error.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-ldbl-warn.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-makedev.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-mntent2.c	Fix warning in misc/tst-mntent2.c.	2014-12-16 10:27:16 +01:00
tst-mntent-autofs.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-mntent-blank-corrupt.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-mntent-blank-passno.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-mntent-escape.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-mntent.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst-preadvwritev2-common.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-preadvwritev2.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-preadvwritev64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-preadvwritev64v2.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-preadvwritev-common.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-preadvwritev.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-pselect-time64.c	y2038: Add test coverage	2021-06-15 10:42:11 -03:00
tst-pselect.c	linux: Only use 64-bit syscall if required for pselect	2021-06-22 12:09:52 -03:00
tst-select-time64.c	y2038: Add test coverage	2021-06-15 10:42:11 -03:00
tst-select.c	linux: Only use 64-bit syscall if required for select	2021-06-22 12:09:52 -03:00
tst-syscalls.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-tsearch.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-warn-wide.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ttyent.h	Remove pre-ISO C support	2012-01-07 23:57:22 -05:00
ttyslot.c	As a minor cleanup remove the (r)index defines from include/string.h as	2017-02-06 18:15:18 +00:00
ualarm.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
unwind-link.c	Implement <unwind-link.h> for dynamically loading the libgcc_s unwinder	2021-03-01 15:58:01 +01:00
usleep.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ustat.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
utimes.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
Versions	Implement <unwind-link.h> for dynamically loading the libgcc_s unwinder	2021-03-01 15:58:01 +01:00
vhangup.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
writev.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00