mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-22 21:10:07 +00:00
ea41469b7a
On ARM, where profil_counter is not static, it is brought in by references to various standard functions, as noted in <https://sourceware.org/ml/libc-alpha/2014-11/msg00890.html>, although it is not a standard function itself. I don't know if this also causes test failures on SPARC, although I see no reason for it not to do so. This patch fixes this namespace issue. profil_counter is renamed to __profil_counter and made a weak alias on ARM and SPARC. Because of the uses in profil.c / sprofil.c it seems simplest to make the rename globally, including on the other architectures for which profil_counter was static and so the change is of no substance. The variant names profil_counter_* used in sprofil.c are also renamed to start with __ so that undesired function names do not get exported in static libc. As I noted in bug 17726, profil_counter should probably be a compat symbol on ARM and SPARC, so it wouldn't exist at all in static libc even as a weak alias. Since defining a compat symbol still requires an internal name as a target of an alias, this patch still seems reasonable as an intermediate step towards that goal: it wouldn't be possible for the function simply to be static profil_counter on ARM and SPARC with profil_counter also being the exported compat symbol name, so profil.c / sprofil.c would still need to be prepared to call the function under another name (here, __profil_counter). Tested for x86_64 (testsuite, and that stripped installed shared libraries are unchanged by the patch) and ARM (ABI and linknamespace tests - this patch reduces the number of linknamespace failures I see on ARM from 227 to 5, the residue being math.h failures for fe* functions and for j0l/j1n/jnl/y0l/y1l/ynl aliases). 2014-12-17 Joseph Myers <joseph@codesourcery.com> [BZ #17725] * sysdeps/generic/profil-counter.h (profil_counter): Rename to __profil_counter. * sysdeps/unix/sysv/linux/hppa/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/i386/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/ia64/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/sh/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/tile/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/x86_64/profil-counter.h (profil_counter): Likewise. * sysdeps/unix/sysv/linux/arm/profil-counter.h (profil_counter): Likewise. [!__profil_counter] (profil_counter): Define as weak alias of __profil_counter. * sysdeps/unix/sysv/linux/sparc/sparc32/profil-counter.h (profil_counter): Rename to __profil_counter. [!__profil_counter] (profil_counter): Define as weak alias of __profil_counter. * sysdeps/unix/sysv/linux/sparc/sparc64/profil-counter.h (profil_counter): Rename to __profil_counter. [!__profil_counter] (profil_counter): Define as weak alias of __profil_counter. * sysdeps/posix/profil.c: Update comment referring to profil_counter. (__profil): Use __profil_counter instead of profil_counter. * sysdeps/posix/sprofil.c (profil_counter): Rename to __profil_counter. Use __profil_counter_ushort and __profil_counter_uint in definitions. (__sprofil): Use __profil_counter_uint and __profil_counter_ushort instead of profil_counter_uint and profil_counter_ushort.
120 lines
3.4 KiB
C
120 lines
3.4 KiB
C
/* Low-level statistical profiling support function. Mostly POSIX.1 version.
|
|
Copyright (C) 1996-2014 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
#include <errno.h>
|
|
#include <signal.h>
|
|
#include <sys/time.h>
|
|
#include <libc-internal.h>
|
|
|
|
#ifndef SIGPROF
|
|
|
|
#include <gmon/profil.c>
|
|
|
|
#else
|
|
|
|
static u_short *samples;
|
|
static size_t nsamples;
|
|
static size_t pc_offset;
|
|
static u_int pc_scale;
|
|
|
|
static inline void
|
|
profil_count (void *pc)
|
|
{
|
|
size_t i = (pc - pc_offset - (void *) 0) / 2;
|
|
|
|
if (sizeof (unsigned long long int) > sizeof (size_t))
|
|
i = (unsigned long long int) i * pc_scale / 65536;
|
|
else
|
|
i = i / 65536 * pc_scale + i % 65536 * pc_scale / 65536;
|
|
|
|
if (i < nsamples)
|
|
++samples[i];
|
|
}
|
|
|
|
/* Get the machine-dependent definition of `__profil_counter', the signal
|
|
handler for SIGPROF. It calls `profil_count' (above) with the PC of the
|
|
interrupted code. */
|
|
#include "profil-counter.h"
|
|
|
|
/* Enable statistical profiling, writing samples of the PC into at most
|
|
SIZE bytes of SAMPLE_BUFFER; every processor clock tick while profiling
|
|
is enabled, the system examines the user PC and increments
|
|
SAMPLE_BUFFER[((PC - OFFSET) / 2) * SCALE / 65536]. If SCALE is zero,
|
|
disable profiling. Returns zero on success, -1 on error. */
|
|
|
|
int
|
|
__profil (u_short *sample_buffer, size_t size, size_t offset, u_int scale)
|
|
{
|
|
struct sigaction act;
|
|
struct itimerval timer;
|
|
#if !IS_IN (rtld)
|
|
static struct sigaction oact;
|
|
static struct itimerval otimer;
|
|
# define oact_ptr &oact
|
|
# define otimer_ptr &otimer
|
|
|
|
if (sample_buffer == NULL)
|
|
{
|
|
/* Disable profiling. */
|
|
if (samples == NULL)
|
|
/* Wasn't turned on. */
|
|
return 0;
|
|
|
|
if (__setitimer (ITIMER_PROF, &otimer, NULL) < 0)
|
|
return -1;
|
|
samples = NULL;
|
|
return __sigaction (SIGPROF, &oact, NULL);
|
|
}
|
|
|
|
if (samples)
|
|
{
|
|
/* Was already turned on. Restore old timer and signal handler
|
|
first. */
|
|
if (__setitimer (ITIMER_PROF, &otimer, NULL) < 0
|
|
|| __sigaction (SIGPROF, &oact, NULL) < 0)
|
|
return -1;
|
|
}
|
|
#else
|
|
/* In ld.so profiling should never be disabled once it runs. */
|
|
//assert (sample_buffer != NULL);
|
|
# define oact_ptr NULL
|
|
# define otimer_ptr NULL
|
|
#endif
|
|
|
|
samples = sample_buffer;
|
|
nsamples = size / sizeof *samples;
|
|
pc_offset = offset;
|
|
pc_scale = scale;
|
|
|
|
act.sa_handler = (sighandler_t) &__profil_counter;
|
|
act.sa_flags = SA_RESTART;
|
|
__sigfillset (&act.sa_mask);
|
|
if (__sigaction (SIGPROF, &act, oact_ptr) < 0)
|
|
return -1;
|
|
|
|
timer.it_value.tv_sec = 0;
|
|
timer.it_value.tv_usec = 1000000 / __profile_frequency ();
|
|
timer.it_interval = timer.it_value;
|
|
return __setitimer (ITIMER_PROF, &timer, otimer_ptr);
|
|
}
|
|
weak_alias (__profil, profil)
|
|
|
|
#endif
|