mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-11 13:50:06 +00:00
42760d7646
The resolution of C floating-point Clarification Request 25 <http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2397.htm#dr_25> is that the totalorder and totalordermag functions should take pointer arguments, and this has been adopted in C2X (with const added; note that the integration of this change into C2X is present in the C standard git repository but postdates the most recent public PDF draft). This patch updates glibc accordingly. As a defect resolution, the API is changed unconditionally rather than supporting any sort of TS 18661-1 mode for compilation with the old version of the API. There are compat symbols for existing binaries that pass floating-point arguments directly. As a consequence of changing to pointer arguments, there are no longer type-generic macros in tgmath.h for these functions. Because of the fairly complicated logic for creating libm function aliases and determining the set of aliases to create in a given glibc configuration, rather than duplicating all that in individual source files to create the versioned and compat symbols, the source files for the various versions of totalorder functions are set up to redefine weak_alias before using libm_alias_* macros to create the symbols required. In turn, this requires creating a separate alias for each symbol version pointing to the same implementation (see binutils bug <https://sourceware.org/bugzilla/show_bug.cgi?id=23840>), which is done automatically using __COUNTER__. (As I noted in <https://sourceware.org/ml/libc-alpha/2018-10/msg00631.html>, it might well make sense for glibc's symbol versioning macros to do that alias creation with __COUNTER__ themselves, which would somewhat simplify the logic in the totalorder source files.) It is of course desirable to test the compat symbols. I did this with the generic libm-test machinery, but didn't wish to duplicate the actual tables of test inputs and outputs, and thought it risky to attempt to have a single object file refer to both default and compat versions of the same function in order to test them together. Thus, I created libm-test-compat_totalorder.inc and libm-test-compat_totalordermag.inc which include the generated .c files (with the processed version of those tables of inputs) from the non-compat tests, and added appropriate dependencies. I think this provides sufficient test coverage for the compat symbols without also needing to make the special ldbl-96 and ldbl-128ibm tests (of peculiarities relating to the representations of those formats that can't be covered in the generic tests) run for the compat symbols. Tests of compat symbols need to be internal tests, meaning _ISOMAC is not defined. Making some libm-test tests into internal tests showed up two other issues. GCC diagnoses duplicate macro definitions of __STDC_* macros, including __STDC_WANT_IEC_60559_TYPES_EXT__; I added an appropriate conditional and filed <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91451> for this issue. On ia64, include/setjmp.h ends up getting included indirectly from libm-symbols.h, resulting in conflicting definitions of the STR macro (also defined in libm-test-driver.c); I renamed the macros in include/setjmp.h. (It's arguable that we should have common internal headers used everywhere for stringizing and concatenation macros.) Tested for x86_64 and x86, and with build-many-glibcs.py. * math/bits/mathcalls.h [__GLIBC_USE (IEC_60559_BFP_EXT) || __MATH_DECLARING_FLOATN] (totalorder): Take pointer arguments. [__GLIBC_USE (IEC_60559_BFP_EXT) || __MATH_DECLARING_FLOATN] (totalordermag): Likewise. * manual/arith.texi (totalorder): Likewise. (totalorderf): Likewise. (totalorderl): Likewise. (totalorderfN): Likewise. (totalorderfNx): Likewise. (totalordermag): Likewise. (totalordermagf): Likewise. (totalordermagl): Likewise. (totalordermagfN): Likewise. (totalordermagfNx): Likewise. * math/tgmath.h (__TGMATH_BINARY_REAL_RET_ONLY): Remove macro. [__GLIBC_USE (IEC_60559_BFP_EXT)] (totalorder): Likewise. [__GLIBC_USE (IEC_60559_BFP_EXT)] (totalordermag): Likewise. * math/Versions (GLIBC_2.31): Add totalorder, totalorderf, totalorderl, totalordermag, totalordermagf, totalordermagl, totalorderf32, totalorderf64, totalorderf32x, totalordermagf32, totalordermagf64, totalordermagf32x, totalorderf64x, totalordermagf64x, totalorderf128 and totalordermagf128. * math/Makefile (libm-test-funcs-noauto): Add compat_totalorder and compat_totalordermag. (libm-test-funcs-compat): New variable. (libm-tests-compat): Likewise. (tests): Do not include compat tests. (tests-internal): Add compat tests. ($(foreach t,$(libm-tests-base), $(objpfx)$(t)-compat_totalorder.o)): Depend on $(objpfx)libm-test-totalorder.c. ($(foreach t,$(libm-tests-base), $(objpfx)$(t)-compat_totalordermag.o): Depend on $(objpfx)libm-test-totalordermag.c. (tgmath3-macros): Remove totalorder and totalordermag. * math/libm-test-compat_totalorder.inc: New file. * math/libm-test-compat_totalordermag.inc: Likewise. * math/libm-test-driver.c (struct test_ff_i_data): Update comment. (RUN_TEST_fpfp_b): New macro. (RUN_TEST_LOOP_fpfp_b): Likewise. * math/libm-test-totalorder.inc (totalorder_test_data): Use TEST_fpfp_b. (totalorder_test): Condition on [!COMPAT_TEST]. (do_test): Likewise. * math/libm-test-totalordermag.inc (totalordermag_test_data): Use TEST_fpfp_b. (totalordermag_test): Condition on [!COMPAT_TEST]. (do_test): Likewise. * math/gen-tgmath-tests.py (Tests.add_all_tests): Remove totalorder and totalordermag. * math/test-tgmath.c (NCALLS): Change to 132. (F(compile_test)): Do not call totalorder or totalordermag. (F(totalorder)): Remove. (F(totalordermag)): Likewise. * include/float.h (__STDC_WANT_IEC_60559_TYPES_EXT__): Do not define if [__STDC_WANT_IEC_60559_TYPES_EXT__]. * include/setjmp.h [!_ISOMAC] (STR_HELPER): Rename to SJSTR_HELPER. [!_ISOMAC] (STR): Rename to SJSTR. Update call to STR_HELPER. [!_ISOMAC] (TEST_SIZE): Update call to STR. [!_ISOMAC] (TEST_ALIGN): Likewise. [!_ISOMAC] (TEST_OFFSET): Likewise. * sysdeps/ieee754/dbl-64/s_totalorder.c: Include <shlib-compat.h> and <first-versions.h>. (__totalorder): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/dbl-64/s_totalordermag.c: Include <shlib-compat.h> and <first-versions.h>. (__totalordermag): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/dbl-64/wordsize-64/s_totalorder.c: Include <shlib-compat.h> and <first-versions.h>. (__totalorder): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/dbl-64/wordsize-64/s_totalordermag.c: Include <shlib-compat.h> and <first-versions.h>. (__totalordermag): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/float128/float128_private.h (__totalorder_compatl): New macro. (__totalordermag_compatl): Likewise. * sysdeps/ieee754/flt-32/s_totalorderf.c: Include <shlib-compat.h> and <first-versions.h>. (__totalorderf): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/flt-32/s_totalordermagf.c: Include <shlib-compat.h> and <first-versions.h>. (__totalordermagf): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/ldbl-128/s_totalorderl.c: Include <shlib-compat.h> and <first-versions.h>. (__totalorderl): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/ldbl-128/s_totalordermagl.c: Include <shlib-compat.h> and <first-versions.h>. (__totalordermagl): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/ldbl-128ibm/s_totalorderl.c: Include <shlib-compat.h>. (__totalorderl): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/ldbl-128ibm/s_totalordermagl.c: Include <shlib-compat.h>. (__totalordermagl): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/ldbl-96/s_totalorderl.c: Include <shlib-compat.h> and <first-versions.h>. (__totalorderl): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/ldbl-96/s_totalordermagl.c: Include <shlib-compat.h> and <first-versions.h>. (__totalordermagl): Take pointer arguments. Add symbol versions and compat symbols. * sysdeps/ieee754/ldbl-opt/nldbl-totalorder.c (totalorderl): Take pointer arguments. * sysdeps/ieee754/ldbl-opt/nldbl-totalordermag.c (totalordermagl): Likewise. * sysdeps/ieee754/ldbl-128ibm/test-totalorderl-ldbl-128ibm.c (do_test): Update calls to totalorderl and totalordermagl. * sysdeps/ieee754/ldbl-96/test-totalorderl-ldbl-96.c (do_test): Update calls to totalorderl and totalordermagl. * sysdeps/mach/hurd/i386/libm.abilist: Update. * sysdeps/unix/sysv/linux/aarch64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/alpha/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/arm/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/csky/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/hppa/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/i386/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/ia64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/m68k/coldfire/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/m68k/m680x0/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/microblaze/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/mips/mips32/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/mips/mips64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/nios2/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/riscv/rv64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/sh/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/x86_64/64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/x86_64/x32/libm.abilist: Likewise.
116 lines
3.6 KiB
C
116 lines
3.6 KiB
C
#ifndef _LIBC_FLOAT_H
|
|
#define _LIBC_FLOAT_H
|
|
|
|
#define __GLIBC_INTERNAL_STARTING_HEADER_IMPLEMENTATION
|
|
#include <bits/libc-header-start.h>
|
|
|
|
/* Some tests also define this macro, requiring a check here to avoid
|
|
errors for duplicate definitions (see GCC bug 91451). */
|
|
#if !defined _ISOMAC && !defined __STDC_WANT_IEC_60559_TYPES_EXT__
|
|
# define __STDC_WANT_IEC_60559_TYPES_EXT__
|
|
#endif
|
|
|
|
#include_next <float.h>
|
|
|
|
/* Supplement float.h macros for _FloatN and _FloatNx for older
|
|
compilers which do not yet support the type. These are described
|
|
in TS 18661-3. */
|
|
#include <features.h>
|
|
#include <bits/floatn.h>
|
|
#if !__GNUC_PREREQ (7, 0) && __GLIBC_USE (IEC_60559_TYPES_EXT)
|
|
|
|
# if __HAVE_FLOAT128
|
|
# define FLT128_MANT_DIG 113
|
|
# define FLT128_DECIMAL_DIG 36
|
|
# define FLT128_DIG 33
|
|
# define FLT128_MIN_EXP (-16381)
|
|
# define FLT128_MIN_10_EXP (-4931)
|
|
# define FLT128_MAX_EXP 16384
|
|
# define FLT128_MAX_10_EXP 4932
|
|
# define FLT128_MAX \
|
|
__f128 (1.18973149535723176508575932662800702e+4932)
|
|
# define FLT128_EPSILON \
|
|
__f128 (1.92592994438723585305597794258492732e-34)
|
|
# define FLT128_MIN \
|
|
__f128 (3.36210314311209350626267781732175260e-4932)
|
|
# define FLT128_TRUE_MIN \
|
|
__f128 (6.47517511943802511092443895822764655e-4966)
|
|
# endif
|
|
|
|
/* Types other than _Float128 are typedefs for other types with old
|
|
compilers. */
|
|
|
|
# if __HAVE_FLOAT32
|
|
# define FLT32_MANT_DIG FLT_MANT_DIG
|
|
# define FLT32_DECIMAL_DIG FLT_DECIMAL_DIG
|
|
# define FLT32_DIG FLT_DIG
|
|
# define FLT32_MIN_EXP FLT_MIN_EXP
|
|
# define FLT32_MIN_10_EXP FLT_MIN_10_EXP
|
|
# define FLT32_MAX_EXP FLT_MAX_EXP
|
|
# define FLT32_MAX_10_EXP FLT_MAX_10_EXP
|
|
# define FLT32_MAX FLT_MAX
|
|
# define FLT32_EPSILON FLT_EPSILON
|
|
# define FLT32_MIN FLT_MIN
|
|
# define FLT32_TRUE_MIN FLT_TRUE_MIN
|
|
# endif
|
|
|
|
# if __HAVE_FLOAT64
|
|
# define FLT64_MANT_DIG DBL_MANT_DIG
|
|
# define FLT64_DECIMAL_DIG DBL_DECIMAL_DIG
|
|
# define FLT64_DIG DBL_DIG
|
|
# define FLT64_MIN_EXP DBL_MIN_EXP
|
|
# define FLT64_MIN_10_EXP DBL_MIN_10_EXP
|
|
# define FLT64_MAX_EXP DBL_MAX_EXP
|
|
# define FLT64_MAX_10_EXP DBL_MAX_10_EXP
|
|
# define FLT64_MAX DBL_MAX
|
|
# define FLT64_EPSILON DBL_EPSILON
|
|
# define FLT64_MIN DBL_MIN
|
|
# define FLT64_TRUE_MIN DBL_TRUE_MIN
|
|
# endif
|
|
|
|
# if __HAVE_FLOAT32X
|
|
# define FLT32X_MANT_DIG DBL_MANT_DIG
|
|
# define FLT32X_DECIMAL_DIG DBL_DECIMAL_DIG
|
|
# define FLT32X_DIG DBL_DIG
|
|
# define FLT32X_MIN_EXP DBL_MIN_EXP
|
|
# define FLT32X_MIN_10_EXP DBL_MIN_10_EXP
|
|
# define FLT32X_MAX_EXP DBL_MAX_EXP
|
|
# define FLT32X_MAX_10_EXP DBL_MAX_10_EXP
|
|
# define FLT32X_MAX DBL_MAX
|
|
# define FLT32X_EPSILON DBL_EPSILON
|
|
# define FLT32X_MIN DBL_MIN
|
|
# define FLT32X_TRUE_MIN DBL_TRUE_MIN
|
|
# endif
|
|
|
|
# if __HAVE_FLOAT64X
|
|
# if __HAVE_FLOAT64X_LONG_DOUBLE
|
|
# define FLT64X_MANT_DIG LDBL_MANT_DIG
|
|
# define FLT64X_DECIMAL_DIG LDBL_DECIMAL_DIG
|
|
# define FLT64X_DIG LDBL_DIG
|
|
# define FLT64X_MIN_EXP LDBL_MIN_EXP
|
|
# define FLT64X_MIN_10_EXP LDBL_MIN_10_EXP
|
|
# define FLT64X_MAX_EXP LDBL_MAX_EXP
|
|
# define FLT64X_MAX_10_EXP LDBL_MAX_10_EXP
|
|
# define FLT64X_MAX LDBL_MAX
|
|
# define FLT64X_EPSILON LDBL_EPSILON
|
|
# define FLT64X_MIN LDBL_MIN
|
|
# define FLT64X_TRUE_MIN LDBL_TRUE_MIN
|
|
# else
|
|
# define FLT64X_MANT_DIG FLT128_MANT_DIG
|
|
# define FLT64X_DECIMAL_DIG FLT128_DECIMAL_DIG
|
|
# define FLT64X_DIG FLT128_DIG
|
|
# define FLT64X_MIN_EXP FLT128_MIN_EXP
|
|
# define FLT64X_MIN_10_EXP FLT128_MIN_10_EXP
|
|
# define FLT64X_MAX_EXP FLT128_MAX_EXP
|
|
# define FLT64X_MAX_10_EXP FLT128_MAX_10_EXP
|
|
# define FLT64X_MAX FLT128_MAX
|
|
# define FLT64X_EPSILON FLT128_EPSILON
|
|
# define FLT64X_MIN FLT128_MIN
|
|
# define FLT64X_TRUE_MIN FLT128_TRUE_MIN
|
|
# endif
|
|
# endif
|
|
|
|
#endif
|
|
|
|
#endif /* _LIBC_FLOAT_H */
|