Go to file
Adhemerval Zanella eb76e5b465 nptl: Reinstate pthread_timedjoin_np as a cancellation point (BZ#24215)
Patch ce7eb0e903 ("nptl: Cleanup cancellation macros") changed the
join sequence for internal common __pthread_timedjoin_ex to use the
new macro lll_wait_tid.  The idea was this macro would issue the
cancellable futex operation depending whether the timeout is used or
not.  However if a timeout is used, __lll_timedwait_tid is called and
it is not a cancellable entrypoint.

This patch fixes it by simplifying the code in various ways:

  - Instead of adding the cancellation handling on __lll_timedwait_tid,
    it moves the generic implementation to pthread_join_common.c (called
    now timedwait_tid with some fixes to use the correct type for pid).

  - The llvm_wait_tid macro is removed, along with its replication on
    x86_64, i686, and sparc arch-specific lowlevellock.h.

  - sparc32 __lll_timedwait_tid is also removed, since the code is similar
    to generic one.

  - x86_64 and i386 provides arch-specific __lll_timedwait_tid which is
    also removed since they are similar in functionality to generic C code
    and there is no indication it is better than compiler generated code.

New tests, tst-join8 and tst-join9, are provided to check if
pthread_timedjoin_np acts as a cancellation point.

Checked on x86_64-linux-gnu, i686-linux-gnu, sparcv9-linux-gnu, and
aarch64-linux-gnu.

	[BZ #24215]
	* nptl/Makefile (lpthread-routines): Remove lll_timedwait_tid.
	(tests): Add tst-join8 tst-join9.
	* nptl/lll_timedwait_tid.c: Remove file.
	* sysdeps/sparc/sparc32/lll_timedwait_tid.c: Likewise.
	* sysdeps/unix/sysv/linux/i386/lll_timedwait_tid.c: Likewise.
	* sysdeps/sysv/linux/x86_64/lll_timedwait_tid.c: Likewise.
	* nptl/pthread_join_common.c (timedwait_tid): New function.
	(__pthread_timedjoin_ex): Act as cancellation entrypoint is block
	is set.
	* nptl/tst-join5.c (thread_join): New function.
	(tf1, tf2, do_test): Use libsupport and add pthread_timedjoin_np
	check.
	* nptl/tst-join8.c: New file.
	* nptl/tst-join9.c: Likewise.
	* sysdeps/nptl/lowlevellock-futex.h (lll_futex_wait_cancel,
	lll_futex_timed_wait_cancel): Add generic macros.
	* sysdeps/nptl/lowlevellock.h (__lll_timedwait_tid, lll_wait_tid):
	Remove definitions.
	* sysdeps/unix/sysv/linux/i386/lowlevellock.h: Likewise.
	* sysdeps/unix/sysv/linux/sparc/lowlevellock.h: Likewise.
	* sysdeps/unix/sysv/linux/x86_64/lowlevellock.h: Likewise.
	* sysdeps/sparc/sparc32/lowlevellock.c (__lll_timedwait_tid):
	Remove function.
	* sysdeps/unix/sysv/linux/i386/lowlevellock.S (__lll_timedwait_tid):
	Likewise.
	* sysdeps/unix/sysv/linux/x86_64/lowlevellock.S: Likewise.
	* sysdeps/unix/sysv/linux/lowlevellock-futex.h
	(lll_futex_timed_wait_cancel): New macro.
2019-02-14 18:11:15 -02:00
argp Fix a few typos in comments 2019-01-12 13:44:51 +00:00
assert Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
benchtests Add missing bench-malloc-simple.c file. 2019-02-14 17:10:47 +00:00
bits math: Enable <bits/math-finite.h> sysdeps override 2019-02-08 21:06:51 +01:00
catgets Fix -Wempty-body warnings in glibc. 2019-02-13 13:50:13 +00:00
ChangeLog.old Add missing reference to bug 21654 2017-10-07 13:14:36 +02:00
conform Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
crypt Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
csu Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
ctype Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
debug libio: Use stdin consistently for input functions [BZ #24153] 2019-02-03 09:38:24 +01:00
dirent Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
dlfcn Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
elf RISC-V: Fix elfutils testsuite unwind failures. 2019-02-13 14:25:00 -08:00
gmon Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
gnulib Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
grp Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
gshadow Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
hesiod Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
htl Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
hurd hurd: Fix initial sigaltstack state 2019-01-24 19:27:00 +01:00
iconv Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
iconvdata Adjust wording of two fall-through comments. 2019-02-13 18:37:54 +00:00
include Fix -Wempty-body warnings in glibc. 2019-02-13 13:50:13 +00:00
inet Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
intl intl: Do not return NULL on asprintf failure in gettext [BZ #24018] 2019-01-02 16:26:58 +01:00
io nptl: Remove tst-cancel-wrappers test and related macros 2019-01-03 18:38:08 -02:00
libio Fix -Wempty-body warnings in glibc. 2019-02-13 13:50:13 +00:00
locale Add fall-through comments. 2019-02-12 10:30:34 +00:00
localedata en_US: define date_fmt (bug 24046) 2019-01-07 14:51:13 +01:00
login Update copyright dates not handled by scripts/update-copyrights. 2019-01-01 00:15:13 +00:00
mach Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
malloc Avoid "inline" after return type in function definitions. 2019-02-06 17:16:43 +00:00
manual Linux: Add gettid system call wrapper [BZ #6399] 2019-02-08 11:27:55 +01:00
math math: Enable <bits/math-finite.h> sysdeps override 2019-02-08 21:06:51 +01:00
mathvec Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
misc Add fall-through comments. 2019-02-12 10:30:34 +00:00
nis Adjust wording of two fall-through comments. 2019-02-13 18:37:54 +00:00
nptl nptl: Reinstate pthread_timedjoin_np as a cancellation point (BZ#24215) 2019-02-14 18:11:15 -02:00
nptl_db Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
nscd Remove duplicate initialization of field in nscd. 2019-02-04 14:49:37 +00:00
nss nss: getent: Print IPv6 scope ID for ahosts/ahostsv6 if available 2019-02-12 14:26:20 +01:00
po Update translations 2019-01-25 22:05:42 +05:30
posix Add fall-through comments. 2019-02-12 10:30:34 +00:00
pwd Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
resolv Add fall-through comments. 2019-02-12 10:30:34 +00:00
resource Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
rt rt: Turn forwards from librt to libc into compat symbols [BZ #24194] 2019-02-08 10:43:17 +01:00
scripts Use MPFR 4.0.2 in build-many-glibcs.py. 2019-02-01 00:11:37 +00:00
setjmp Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
shadow Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
signal Disable lazy binding on tests for minimal signal handler 2019-01-18 08:56:51 -08:00
socket Fix a few typos in comments 2019-01-12 13:44:51 +00:00
soft-fp soft-fp: Properly check _FP_W_TYPE_SIZE [BZ #24066] 2019-01-07 09:04:39 -08:00
stdio-common Use C99-compliant scanf under _GNU_SOURCE with modern compilers. 2019-01-03 11:12:39 -05:00
stdlib testsuite: stdlib/isomac.c: add missing include 2019-02-03 15:17:18 +01:00
streams Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
string Only build libm with -fno-math-errno (bug 24024) 2019-01-07 14:59:07 +01:00
sunrpc Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
support Avoid fall-through in test-container if execlp fails. 2019-02-13 13:34:24 +00:00
sysdeps nptl: Reinstate pthread_timedjoin_np as a cancellation point (BZ#24215) 2019-02-14 18:11:15 -02:00
sysvipc Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
termios Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
time Fix a few whitespace arrangement inconsistencies in time/strftime_l.c 2019-02-11 12:13:55 +09:00
timezone Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
wcsmbs Fix handling of collating elements in fnmatch (bug 17396, bug 16976) 2019-02-04 15:45:02 +01:00
wctype Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
.gitattributes Assume __NR_openat is always defined 2016-03-23 23:35:08 +01:00
.gitignore Add *.pyc to .gitignore 2015-05-18 15:26:26 +05:30
abi-tags Remove the bulk of the NaCl port. 2017-05-20 08:09:10 -04:00
aclocal.m4 LIBC_SLIBDIR_RTLDDIR: substitute arguments in single quotes 2018-01-25 17:20:28 +01:00
ChangeLog nptl: Reinstate pthread_timedjoin_np as a cancellation point (BZ#24215) 2019-02-14 18:11:15 -02:00
config.h.in Add C-SKY port 2018-12-21 09:48:04 +08:00
config.make.in Fix ifunc support with DT_TEXTREL segments (BZ#20480) 2018-09-25 16:27:50 -03:00
configure Require GCC 6.2 or later to build glibc. 2019-02-01 16:27:44 +00:00
configure.ac Require GCC 6.2 or later to build glibc. 2019-02-01 16:27:44 +00:00
COPYING
COPYING.LIB
extra-lib.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
gen-locales.mk Improve gen-locales.mk and gen-locale.sh to make test files with @ options work 2018-02-27 17:01:57 +01:00
INSTALL Require GCC 6.2 or later to build glibc. 2019-02-01 16:27:44 +00:00
libc-abis libc-abis: Define ABSOLUTE ABI [BZ #19818][BZ #23307] 2018-07-05 18:06:43 +01:00
libof-iterator.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
LICENSES stdio-common/tst-printf.c: Remove part under a non-free license [BZ #23363] 2018-07-03 18:29:16 +02:00
MAINTAINERS Add MAINTAINERS 2017-05-11 13:38:30 -04:00
Makeconfig Only build libm with -fno-math-errno (bug 24024) 2019-01-07 14:59:07 +01:00
Makefile testrun.sh: Exit in case of incorrect argument 2019-02-04 13:06:15 +01:00
Makefile.in New make target to only build benchmark binaries 2016-04-20 10:23:28 +05:30
Makerules Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
NEWS Linux: Add gettid system call wrapper [BZ #6399] 2019-02-08 11:27:55 +01:00
o-iterator.mk
README Add C-SKY port 2018-12-21 09:48:04 +08:00
Rules Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
shlib-versions Extend NSS test suite 2017-07-17 15:52:44 -04:00
test-skeleton.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
version.h Open master for 2.30 development 2019-01-31 22:39:14 +05:30

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arm-*-linux-gnueabi
	csky-*-linux-gnuabiv2
	hppa-*-linux-gnu
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	ia64-*-linux-gnu
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	riscv64-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see http://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at http://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see http://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.