mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-25 22:40:05 +00:00
34a5a1460e
The GNU Coding Standards specify that line breaks in expressions should go before an operator, not after one. This patch fixes various code to do this. It only changes code that appears to be mostly following GNU style anyway, not files and directories with substantially different formatting. It is not exhaustive even for files using GNU style (for example, changes to sysdeps files are deferred for subsequent cleanups). Some files changed are shared with gnulib, but most are specific to glibc. Changes were made manually, with places to change found by grep (so some cases, e.g. where the operator was followed by a comment at end of line, are particularly liable to have been missed by grep, but I did include cases where the operator was followed by backslash-newline). This patch generally does not attempt to address other coding style issues in the expressions changed (for example, missing spaces before '(', or lack of parentheses to ensure indentation of continuation lines properly reflects operator precedence). Tested for x86_64, and with build-many-glibcs.py. * benchtests/bench-memmem.c (simple_memmem): Break lines before rather than after operators. * benchtests/bench-skeleton.c (TIMESPEC_AFTER): Likewise. * crypt/md5.c (md5_finish_ctx): Likewise. * crypt/sha256.c (__sha256_finish_ctx): Likewise. * crypt/sha512.c (__sha512_finish_ctx): Likewise. * elf/cache.c (load_aux_cache): Likewise. * elf/dl-load.c (open_verify): Likewise. * elf/get-dynamic-info.h (elf_get_dynamic_info): Likewise. * elf/readelflib.c (process_elf_file): Likewise. * elf/rtld.c (dl_main): Likewise. * elf/sprof.c (generate_call_graph): Likewise. * hurd/ctty-input.c (_hurd_ctty_input): Likewise. * hurd/ctty-output.c (_hurd_ctty_output): Likewise. * hurd/dtable.c (reauth_dtable): Likewise. * hurd/getdport.c (__getdport): Likewise. * hurd/hurd/signal.h (_hurd_interrupted_rpc_timeout): Likewise. * hurd/hurd/sigpreempt.h (HURD_PREEMPT_SIGNAL_P): Likewise. * hurd/hurdfault.c (_hurdsig_fault_catch_exception_raise): Likewise. * hurd/hurdioctl.c (fioctl): Likewise. * hurd/hurdselect.c (_hurd_select): Likewise. * hurd/hurdsig.c (_hurdsig_abort_rpcs): Likewise. (STOPSIGS): Likewise. * hurd/hurdstartup.c (_hurd_startup): Likewise. * hurd/intr-msg.c (_hurd_intr_rpc_mach_msg): Likewise. * hurd/lookup-retry.c (__hurd_file_name_lookup_retry): Likewise. * hurd/msgportdemux.c (msgport_server): Likewise. * hurd/setauth.c (_hurd_setauth): Likewise. * include/features.h (__GLIBC_USE_DEPRECATED_SCANF): Likewise. * libio/libioP.h [IO_DEBUG] (CHECK_FILE): Likewise. * locale/programs/ld-ctype.c (set_class_defaults): Likewise. * localedata/tests-mbwc/tst_swscanf.c (tst_swscanf): Likewise. * login/tst-utmp.c (do_check): Likewise. (simulate_login): Likewise. * mach/lowlevellock.h (lll_lock): Likewise. (lll_trylock): Likewise. * math/test-fenv.c (ALL_EXC): Likewise. * math/test-fenvinline.c (ALL_EXC): Likewise. * misc/sys/cdefs.h (__attribute_deprecated_msg__): Likewise. * nis/nis_call.c (__do_niscall3): Likewise. * nis/nis_callback.c (cb_prog_1): Likewise. * nis/nis_defaults.c (searchaccess): Likewise. * nis/nis_findserv.c (__nis_findfastest_with_timeout): Likewise. * nis/nis_ismember.c (internal_ismember): Likewise. * nis/nis_local_names.c (nis_local_principal): Likewise. * nis/nss_nis/nis-rpc.c (_nss_nis_getrpcbyname_r): Likewise. * nis/nss_nisplus/nisplus-netgrp.c (_nss_nisplus_getnetgrent_r): Likewise. * nis/ypclnt.c (yp_match): Likewise. (yp_first): Likewise. (yp_next): Likewise. (yp_master): Likewise. (yp_order): Likewise. * nscd/hstcache.c (cache_addhst): Likewise. * nscd/initgrcache.c (addinitgroupsX): Likewise. * nss/nss_compat/compat-pwd.c (copy_pwd_changes): Likewise. (internal_getpwuid_r): Likewise. * nss/nss_compat/compat-spwd.c (copy_spwd_changes): Likewise. * posix/glob.h (__GLOB_FLAGS): Likewise. * posix/regcomp.c (peek_token): Likewise. (peek_token_bracket): Likewise. (parse_expression): Likewise. * posix/regexec.c (sift_states_iter_mb): Likewise. (check_node_accept_bytes): Likewise. * posix/tst-spawn3.c (do_test): Likewise. * posix/wordexp-test.c (testit): Likewise. * posix/wordexp.c (parse_tilde): Likewise. (exec_comm): Likewise. * posix/wordexp.h (__WRDE_FLAGS): Likewise. * resource/vtimes.c (TIMEVAL_TO_VTIMES): Likewise. * setjmp/sigjmp.c (__sigjmp_save): Likewise. * stdio-common/printf_fp.c (__printf_fp_l): Likewise. * stdio-common/tst-fileno.c (do_test): Likewise. * stdio-common/vfprintf-internal.c (vfprintf): Likewise. * stdlib/strfmon_l.c (__vstrfmon_l_internal): Likewise. * stdlib/strtod_l.c (round_and_return): Likewise. (____STRTOF_INTERNAL): Likewise. * stdlib/tst-strfrom.h (TEST_STRFROM): Likewise. * string/strcspn.c (STRCSPN): Likewise. * string/test-memmem.c (simple_memmem): Likewise. * termios/tcsetattr.c (tcsetattr): Likewise. * time/alt_digit.c (_nl_parse_alt_digit): Likewise. * time/asctime.c (asctime_internal): Likewise. * time/strptime_l.c (__strptime_internal): Likewise. * time/sys/time.h (timercmp): Likewise. * time/tzfile.c (__tzfile_compute): Likewise.
122 lines
3.6 KiB
C
122 lines
3.6 KiB
C
/* Copyright (C) 1991-2019 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <hurd.h>
|
|
#include <hurd/port.h>
|
|
#include <hurd/id.h>
|
|
#include <hurdlock.h>
|
|
#include "set-hooks.h"
|
|
|
|
/* Things in the library which want to be run when the auth port changes. */
|
|
DEFINE_HOOK (_hurd_reauth_hook, (auth_t new_auth));
|
|
|
|
static unsigned int reauth_lock = LLL_INITIALIZER;
|
|
|
|
/* Set the auth port to NEW, and reauthenticate
|
|
everything used by the library. */
|
|
error_t
|
|
_hurd_setauth (auth_t new)
|
|
{
|
|
error_t err;
|
|
unsigned int d;
|
|
mach_port_t newport, ref;
|
|
|
|
/* Give the new send right a user reference.
|
|
This is a good way to check that it is valid. */
|
|
if (err = __mach_port_mod_refs (__mach_task_self (), new,
|
|
MACH_PORT_RIGHT_SEND, 1))
|
|
return err;
|
|
|
|
HURD_CRITICAL_BEGIN;
|
|
|
|
/* We lock against another thread doing setauth. Anyone who sets
|
|
_hurd_ports[INIT_PORT_AUTH] some other way is asking to lose. */
|
|
__mutex_lock (&reauth_lock);
|
|
|
|
/* Install the new port in the cell. */
|
|
__mutex_lock (&_hurd_id.lock);
|
|
_hurd_port_set (&_hurd_ports[INIT_PORT_AUTH], new);
|
|
_hurd_id.valid = 0;
|
|
if (_hurd_id.rid_auth)
|
|
{
|
|
__mach_port_deallocate (__mach_task_self (), _hurd_id.rid_auth);
|
|
_hurd_id.rid_auth = MACH_PORT_NULL;
|
|
}
|
|
__mutex_unlock (&_hurd_id.lock);
|
|
|
|
if (_hurd_init_dtable != NULL)
|
|
/* We just have the simple table we got at startup.
|
|
Otherwise, a reauth_hook in dtable.c takes care of this. */
|
|
for (d = 0; d < _hurd_init_dtablesize; ++d)
|
|
if (_hurd_init_dtable[d] != MACH_PORT_NULL)
|
|
{
|
|
mach_port_t new;
|
|
ref = __mach_reply_port ();
|
|
if (! __io_reauthenticate (_hurd_init_dtable[d],
|
|
ref, MACH_MSG_TYPE_MAKE_SEND)
|
|
&& ! HURD_PORT_USE (&_hurd_ports[INIT_PORT_AUTH],
|
|
__auth_user_authenticate
|
|
(port,
|
|
ref, MACH_MSG_TYPE_MAKE_SEND,
|
|
&new)))
|
|
{
|
|
__mach_port_deallocate (__mach_task_self (),
|
|
_hurd_init_dtable[d]);
|
|
_hurd_init_dtable[d] = new;
|
|
}
|
|
__mach_port_destroy (__mach_task_self (), ref);
|
|
}
|
|
|
|
ref = __mach_reply_port ();
|
|
if (__USEPORT (CRDIR,
|
|
! __io_reauthenticate (port,
|
|
ref, MACH_MSG_TYPE_MAKE_SEND)
|
|
&& ! __auth_user_authenticate (new,
|
|
ref, MACH_MSG_TYPE_MAKE_SEND,
|
|
&newport)))
|
|
_hurd_port_set (&_hurd_ports[INIT_PORT_CRDIR], newport);
|
|
__mach_port_destroy (__mach_task_self (), ref);
|
|
|
|
ref = __mach_reply_port ();
|
|
if (__USEPORT (CWDIR,
|
|
! __io_reauthenticate (port,
|
|
ref, MACH_MSG_TYPE_MAKE_SEND)
|
|
&& ! __auth_user_authenticate (new,
|
|
ref, MACH_MSG_TYPE_MAKE_SEND,
|
|
&newport)))
|
|
_hurd_port_set (&_hurd_ports[INIT_PORT_CWDIR], newport);
|
|
__mach_port_destroy (__mach_task_self (), ref);
|
|
|
|
/* Run things which want to do reauthorization stuff. */
|
|
RUN_HOOK (_hurd_reauth_hook, (new));
|
|
|
|
__mutex_unlock (&reauth_lock);
|
|
|
|
HURD_CRITICAL_END;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
__setauth (auth_t new)
|
|
{
|
|
error_t err = _hurd_setauth (new);
|
|
return err ? __hurd_fail (err) : 0;
|
|
}
|
|
|
|
weak_alias (__setauth, setauth)
|