mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-25 12:11:10 +00:00
24e9ae1bc2
The powerpc implementations of fabsl for ldbl-128ibm (both powerpc32 and powerpc64) wrongly raise the "invalid" exception for sNaN arguments. fabs functions should be quiet for all inputs including signaling NaNs. The problem is the use of a comparison instruction fcmpu to determine if the high part of the argument is negative and so the low part needs to be negated; such instructions raise "invalid" for sNaNs. There is a pure integer implementation of fabsl in sysdeps/ieee754/ldbl-128ibm/s_fabsl.c. However, it's not necessary to use it to avoid such exceptions. The fsel instruction does not raise exceptions for sNaNs, and can be used in place of the original comparison. (Note that if the high part is zero or a NaN, it does not matter whether the low part is negated; the choice of whether the low part of a zero is +0 or -0 does not affect the value, and the low part of a NaN does not affect the value / payload either.) The condition in GCC for fsel to be available is TARGET_PPC_GFXOPT, corresponding to the _ARCH_PPCGR predefined macro. fsel is available on all 64-bit processors supported by GCC. A few 32-bit processors supported by GCC do not have TARGET_PPC_GFXOPT despite having hard float support. To support those processors, integer code (similar to that in copysignl) is included for the !_ARCH_PPCGR case for powerpc32. Tested for powerpc32 (configurations with and without _ARCH_PPCGR) and powerpc64. [BZ #20157] * sysdeps/powerpc/powerpc32/fpu/s_fabsl.S (__fabsl): Use fsel to determine whether to negate low half if [_ARCH_PPCGR], and integer comparison otherwise. * sysdeps/powerpc/powerpc64/fpu/s_fabsl.S (__fabsl): Use fsel to determine whether to negate low half.
53 lines
1.5 KiB
ArmAsm
53 lines
1.5 KiB
ArmAsm
/* Copy a sign bit between floating-point values.
|
|
IBM extended format long double version.
|
|
Copyright (C) 2004-2016 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <sysdep.h>
|
|
#include <math_ldbl_opt.h>
|
|
|
|
ENTRY(__fabsl)
|
|
/* long double [f1,f2] fabs (long double [f1,f2] x);
|
|
fabs(x,y) returns a value with the magnitude of x and
|
|
with the sign bit of y. */
|
|
#ifdef _ARCH_PPCGR
|
|
/* fsel available. */
|
|
fmr fp0,fp1
|
|
#else
|
|
/* Use integer operations to test sign of high part to avoid
|
|
exceptions on sNaNs. */
|
|
stwu r1,-16(r1)
|
|
cfi_adjust_cfa_offset (16)
|
|
stfd fp1,8(r1)
|
|
#endif
|
|
fabs fp1,fp1
|
|
#ifdef _ARCH_PPCGR
|
|
fneg fp3,fp2
|
|
fsel fp2,fp0,fp2,fp3
|
|
#else
|
|
lwz r3,8+HIWORD(r1)
|
|
cmpwi cr6,r3,0
|
|
addi r1,r1,16
|
|
cfi_adjust_cfa_offset (-16)
|
|
bgelr cr6
|
|
fneg fp2,fp2
|
|
#endif
|
|
blr
|
|
END (__fabsl)
|
|
|
|
long_double_symbol (libm, __fabsl, fabsl)
|