glibc/nptl/pthread_setattr_default_np.c
Florian Weimer 2359035ac5 Remove CPU set size checking from affinity functions [BZ #19143]
With current kernel versions, the check does not reliably detect that
unavailable CPUs are requested, for these reasons:

(1) The kernel will silently ignore non-allowed CPUs, that is, CPUs
    which are physically present but disallowed for the thread
    based on system configuration.

(2) Similarly, CPU bits which lack an online CPU (possible CPUs)
    are ignored.

(3) The existing probing code assumes that the CPU mask size is a
    power of two and at least 1024.  Neither has it to be a power
    of two, nor is the minimum possible value 1024, so the value
    determined is often too large.  This means that the CPU set
    size check in glibc accepts CPU bits beyond the actual hard
    system limit.

(4) Future kernel versions may not even have a fixed CPU set size.

After the removal of the probing code, the kernel still returns
EINVAL if no CPU in the requested set remains which can run the
thread after the affinity change.

Applications which care about the exact affinity mask will have
to query it using sched_getaffinity after setting it.  Due to the
effects described above, this commit does not change this.

The new tests supersede tst-getcpu, which is removed.  This
addresses bug 19164 because the new tests allocate CPU sets
dynamically.

	* nptl/check-cpuset.h: Remove.
	* nptl/pthread_attr_setaffinity.c (__pthread_attr_setaffinity_new):
	Remove CPU set size check.
	* nptl/pthread_setattr_default_np.c (pthread_setattr_default_np):
	Likewise.
	* sysdeps/unix/sysv/linux/check-cpuset.h: Remove.
	* sysdeps/unix/sysv/linux/pthread_setaffinity.c
	(__kernel_cpumask_size, __determine_cpumask_size): Remove.
	(__pthread_setaffinity_new): Remove CPU set size check.
	* sysdeps/unix/sysv/linux/sched_setaffinity.c
	(__kernel_cpumask_size): Remove.
	(__sched_setaffinity_new): Remove CPU set size check.
	* manual/threads.texi (Default Thread Attributes): Remove stale
	reference to check_cpuset_attr, determine_cpumask_size in comment.
	* sysdeps/unix/sysv/linux/Makefile [$(subdir) == posix] (tests):
	Remove tst-getcpu.  Add tst-affinity, tst-affinity-pid.
	[$(subdir) == nptl] (tests): Add tst-thread-affinity-pthread,
	tst-thread-affinity-pthread2, tst-thread-affinity-sched.
	* sysdeps/unix/sysv/linux/tst-affinity.c: New file.
	* sysdeps/unix/sysv/linux/tst-affinity-pid.c: New file.
	* sysdeps/unix/sysv/linux/tst-skeleton-affinity.c: New skeleton test file.
	* sysdeps/unix/sysv/linux/tst-thread-affinity-sched.c: New file.
	* sysdeps/unix/sysv/linux/tst-thread-affinity-pthread.c: New file.
	* sysdeps/unix/sysv/linux/tst-thread-affinity-pthread2.c: New file.
	* sysdeps/unix/sysv/linux/tst-thread-skeleton-affinity.c: New
	skeleton test file.
	* sysdeps/unix/sysv/linux/tst-getcpu.c: Remove.  Superseded by
	tst-affinity-pid.
2015-11-24 17:21:01 +01:00

109 lines
3.1 KiB
C

/* Set the default attributes to be used by pthread_create in the process.
Copyright (C) 2013-2015 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
#include <errno.h>
#include <stdlib.h>
#include <pthreadP.h>
#include <assert.h>
#include <string.h>
int
pthread_setattr_default_np (const pthread_attr_t *in)
{
const struct pthread_attr *real_in;
struct pthread_attr attrs;
int ret;
assert (sizeof (*in) >= sizeof (struct pthread_attr));
real_in = (struct pthread_attr *) in;
/* Catch invalid values. */
int policy = real_in->schedpolicy;
ret = check_sched_policy_attr (policy);
if (ret)
return ret;
const struct sched_param *param = &real_in->schedparam;
if (param->sched_priority > 0)
{
ret = check_sched_priority_attr (param->sched_priority, policy);
if (ret)
return ret;
}
/* stacksize == 0 is fine. It means that we don't change the current
value. */
if (real_in->stacksize != 0)
{
ret = check_stacksize_attr (real_in->stacksize);
if (ret)
return ret;
}
/* Having a default stack address is wrong. */
if (real_in->flags & ATTR_FLAG_STACKADDR)
return EINVAL;
attrs = *real_in;
/* Now take the lock because we start writing into
__default_pthread_attr. */
lll_lock (__default_pthread_attr_lock, LLL_PRIVATE);
/* Free the cpuset if the input is 0. Otherwise copy in the cpuset
contents. */
size_t cpusetsize = attrs.cpusetsize;
if (cpusetsize == 0)
{
free (__default_pthread_attr.cpuset);
__default_pthread_attr.cpuset = NULL;
}
else if (cpusetsize == __default_pthread_attr.cpusetsize)
{
attrs.cpuset = __default_pthread_attr.cpuset;
memcpy (attrs.cpuset, real_in->cpuset, cpusetsize);
}
else
{
/* This may look wrong at first sight, but it isn't. We're freeing
__default_pthread_attr.cpuset and allocating to attrs.cpuset because
we'll copy over all of attr to __default_pthread_attr later. */
cpu_set_t *newp = realloc (__default_pthread_attr.cpuset,
cpusetsize);
if (newp == NULL)
{
ret = ENOMEM;
goto out;
}
attrs.cpuset = newp;
memcpy (attrs.cpuset, real_in->cpuset, cpusetsize);
}
/* We don't want to accidentally set the default stacksize to zero. */
if (attrs.stacksize == 0)
attrs.stacksize = __default_pthread_attr.stacksize;
__default_pthread_attr = attrs;
out:
lll_unlock (__default_pthread_attr_lock, LLL_PRIVATE);
return ret;
}