mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-21 20:40:05 +00:00
32c7acd464
Almost all uses of rawmemchr find the end of a string. Since most targets use a generic implementation, replacing it with strchr is better since that is optimized by compilers into strlen (s) + s. Also fix the generic rawmemchr implementation to use a cast to unsigned char in the if statement. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
94 lines
2.9 KiB
C
94 lines
2.9 KiB
C
/* Copyright (c) 1997-2023 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <assert.h>
|
|
#include <string.h>
|
|
#include <rpcsvc/nis.h>
|
|
#include <shlib-compat.h>
|
|
|
|
nis_error
|
|
nis_addmember (const_nis_name member, const_nis_name group)
|
|
{
|
|
if (group != NULL && group[0] != '\0')
|
|
{
|
|
size_t grouplen = strlen (group);
|
|
char buf[grouplen + 14 + NIS_MAXNAMELEN];
|
|
char domainbuf[grouplen + 2];
|
|
nis_result *res, *res2;
|
|
nis_error status;
|
|
char *cp, *cp2;
|
|
|
|
cp = strchr (nis_leaf_of_r (group, buf, sizeof (buf) - 1), '\0');
|
|
cp = stpcpy (cp, ".groups_dir");
|
|
cp2 = nis_domain_of_r (group, domainbuf, sizeof (domainbuf) - 1);
|
|
if (cp2 != NULL && cp2[0] != '\0')
|
|
{
|
|
*cp++ = '.';
|
|
stpcpy (cp, cp2);
|
|
}
|
|
res = nis_lookup (buf, FOLLOW_LINKS | EXPAND_NAME);
|
|
if (NIS_RES_STATUS (res) != NIS_SUCCESS)
|
|
{
|
|
status = NIS_RES_STATUS (res);
|
|
nis_freeresult (res);
|
|
return status;
|
|
}
|
|
if (NIS_RES_NUMOBJ (res) != 1
|
|
|| __type_of (NIS_RES_OBJECT (res)) != NIS_GROUP_OBJ)
|
|
{
|
|
nis_freeresult (res);
|
|
return NIS_INVALIDOBJ;
|
|
}
|
|
|
|
u_int gr_members_len
|
|
= NIS_RES_OBJECT(res)->GR_data.gr_members.gr_members_len;
|
|
|
|
nis_name *new_gr_members_val
|
|
= realloc (NIS_RES_OBJECT (res)->GR_data.gr_members.gr_members_val,
|
|
(gr_members_len + 1) * sizeof (nis_name));
|
|
if (new_gr_members_val == NULL)
|
|
goto nomem_out;
|
|
|
|
NIS_RES_OBJECT (res)->GR_data.gr_members.gr_members_val
|
|
= new_gr_members_val;
|
|
|
|
new_gr_members_val[gr_members_len] = strdup (member);
|
|
if (new_gr_members_val[gr_members_len] == NULL)
|
|
{
|
|
nomem_out:
|
|
nis_freeresult (res);
|
|
return NIS_NOMEMORY;
|
|
}
|
|
++NIS_RES_OBJECT (res)->GR_data.gr_members.gr_members_len;
|
|
|
|
/* Check the buffer bounds are not exceeded. */
|
|
assert (strlen (NIS_RES_OBJECT(res)->zo_name) + 1 < grouplen + 14);
|
|
cp = stpcpy (buf, NIS_RES_OBJECT(res)->zo_name);
|
|
*cp++ = '.';
|
|
strncpy (cp, NIS_RES_OBJECT (res)->zo_domain, NIS_MAXNAMELEN);
|
|
res2 = nis_modify (buf, NIS_RES_OBJECT (res));
|
|
status = NIS_RES_STATUS (res2);
|
|
nis_freeresult (res);
|
|
nis_freeresult (res2);
|
|
|
|
return status;
|
|
}
|
|
else
|
|
return NIS_FAIL;
|
|
}
|
|
libnsl_hidden_nolink_def (nis_addmember, GLIBC_2_1)
|