glibc/sysdeps/i386/i686
Adhemerval Zanella Netto f8f9a27257 i386: Fix build with --enable-fortify=3
The i386 string routines provide multiple internal definitions
for memcpy, memmove, and mempcpy chk routines:

  $ objdump -t libc.a | grep __memcpy_chk
  00000000 g     F .text  0000000e __memcpy_chk
  00000000 g     F .text  00000013 __memcpy_chk
  $ objdump -t libc.a | grep __mempcpy_chk
  00000000 g     F .text  0000000e __mempcpy_chk
  00000000 g     F .text  00000013 __mempcpy_chk
  $ objdump -t libc.a | grep __memmove_chk
  00000000 g     F .text  0000000e __memmove_chk
  00000000 g     F .text  00000013 __memmove_chk

Although is not an issue for normal static builds, with fortify=3
glibc itself might use the fortify chk functions and thus static
build might fail with multiple definitions.  For instance:

x86_64-glibc-linux-gnu-gcc -m32 -march=i686 -o [...]math/test-signgam-uchar-static -nostdlib -nostartfiles -static -static-pie [...]
x86_64-glibc-linux-gnu/bin/ld: [...]/libc.a(mempcpy-ia32.o):
in function `__mempcpy_chk': [...]/glibc-git/string/../sysdeps/i386/i686/mempcpy.S:32: multiple definition of `__mempcpy_chk';
[...]/libc.a(mempcpy_chk-nonshared.o):[...]/debug/../sysdeps/i386/mempcpy_chk.S:28: first defined here
collect2: error: ld returned 1 exit status
make[2]: *** [../Rules:298:

There is no need for mem*-nonshared.S, the __mem*_chk routines
are already provided by the assembly routines.

Checked on i686-linux-gnu with gcc 13 built with fortify=1,2,3 and
without fortify.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2023-07-26 09:45:55 -03:00
..
fpu Update i686 libm-test-ulps (again) 2023-07-19 01:32:13 +02:00
multiarch i386: Fix build with --enable-fortify=3 2023-07-26 09:45:55 -03:00
nptl Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
add_n.S Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
dl-hash.h Fix misspellings in sysdeps/ -- BZ 25337 2023-05-30 23:02:29 +00:00
ffs.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
isa.h Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
Makefile i386: Remove -Wa,-mtune=i686 2022-07-12 11:14:32 -07:00
memcmp.S Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
memcpy.S string: Ensure *_chk routines have their hidden builtin definition available 2023-07-05 16:59:48 +02:00
memmove.S string: Ensure *_chk routines have their hidden builtin definition available 2023-07-05 16:59:48 +02:00
mempcpy.S string: Ensure *_chk routines have their hidden builtin definition available 2023-07-05 16:59:48 +02:00
memset.S string: Ensure *_chk routines have their hidden builtin definition available 2023-07-05 16:59:48 +02:00
pthread_spin_trylock.S Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
strcmp.S Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00