mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-10 15:20:10 +00:00
d0d286d32d
The dbl-64, ldbl-96 and ldbl-128 implementations of lrint and llrint fail to produce "invalid" exceptions in cases where the rounded result overflows the target type, but truncating the floating-point argument to the next integer towards zero does not overflow it (so in particular casts do not produce such exceptions). (This issue cannot arise for float, or for double with 64-bit target type, or for ldbl-96 with 64-bit target type and negative arguments, because of insufficient precision in the floating-point type for arguments with the relevant property to exist. It also obviously cannot arise in FE_TOWARDZERO mode.) This patch fixes these problems by inserting checks for the special cases that can occur in each implementation, and explicitly raising FE_INVALID (and avoiding the cast if it might raise spurious FE_INEXACT, while raising FE_INEXACT explicitly in the cases where it is needed; unlike lround and llround, FE_INEXACT is required, not optional, for these functions for a within-range inexact result). The fixes are conditional on FE_INVALID or FE_INEXACT being defined. If any future architecture supports one but not both of those exceptions, the code will fail to compile and need fixing to handle that case (this seemed better than conditioning on both macros being defined, resulting in code that would compile but quietly miss exceptions on such a system). Tested for x86_64, x86 and mips64. Tested the ldbl-96 changes (only relevant for ia64, it appears) on x86_64 by removing the x86_64 versions of lrintl / llrintl. [BZ #19094] * sysdeps/ieee754/dbl-64/s_lrint.c: Include <fenv.h> and <limits.h>. (__lrint) [FE_INVALID || FE_INEXACT]: Force FE_INVALID exception when result overflows but exception would not result from cast. * sysdeps/ieee754/ldbl-128/s_llrintl.c: Include <fenv.h> and <limits.h>. (__llrintl) [FE_INVALID || FE_INEXACT]: Force FE_INVALID exception when result overflows but exception would not result from cast. * sysdeps/ieee754/ldbl-128/s_lrintl.c: Include <fenv.h> and <limits.h>. (__lrintl) [FE_INVALID || FE_INEXACT]: Force FE_INVALID exception when result overflows but exception would not result from cast. * sysdeps/ieee754/ldbl-96/s_llrintl.c: Include <fenv.h> and <limits.h>. (__llrintl) [FE_INVALID || FE_INEXACT]: Force FE_INVALID exception when result overflows but exception would not result from cast. * sysdeps/ieee754/ldbl-96/s_lrintl.c: Include <fenv.h> and <limits.h>. (__lrintl) [FE_INVALID || FE_INEXACT]: Force FE_INVALID exception when result overflows but exception would not result from cast. * math/libm-test.inc (lrint_test_data): Add more tests. (llrint_test_data): Likewise. |
||
|---|---|---|
| .. | ||
| e_acoshl.c | ||
| e_asinl.c | ||
| e_atanhl.c | ||
| e_coshl.c | ||
| e_gammal_r.c | ||
| e_hypotl.c | ||
| e_j0l.c | ||
| e_j1l.c | ||
| e_jnl.c | ||
| e_lgammal_r.c | ||
| e_rem_pio2l.c | ||
| e_sinhl.c | ||
| gamma_product.c | ||
| gamma_productl.c | ||
| k_cosl.c | ||
| k_sinl.c | ||
| k_tanl.c | ||
| ldbl2mpn.c | ||
| lgamma_negl.c | ||
| lgamma_product.c | ||
| lgamma_productl.c | ||
| math_ldbl.h | ||
| mpn2ldbl.c | ||
| printf_fphex.c | ||
| s_asinhl.c | ||
| s_cbrtl.c | ||
| s_copysignl.c | ||
| s_cosl.c | ||
| s_erfl.c | ||
| s_fma.c | ||
| s_fmal.c | ||
| s_frexpl.c | ||
| s_issignalingl.c | ||
| s_llrintl.c | ||
| s_llroundl.c | ||
| s_lrintl.c | ||
| s_lroundl.c | ||
| s_modfl.c | ||
| s_nexttoward.c | ||
| s_nexttowardf.c | ||
| s_remquol.c | ||
| s_roundl.c | ||
| s_scalblnl.c | ||
| s_signbitl.c | ||
| s_sincosl.c | ||
| s_sinl.c | ||
| s_tanhl.c | ||
| s_tanl.c | ||
| strtold_l.c | ||
| t_sincosl.c | ||
| w_expl.c | ||
| x2y2m1.c | ||
| x2y2m1l.c | ||