AuroraMiddleware/glslang
1
0
Fork 0
mirror of https://github.com/KhronosGroup/glslang synced 2024-11-09 12:00:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

index outside gl_SampleMask range, compiler need report error. (#3556)

Browse Source
This commit is contained in:
jimihem 2024-04-18 08:14:26 +08:00 committed by GitHub
parent 593dbafd0d
commit 68df223056
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
Test/baseResults/index_outside_sample_mask_range.frag.out Normal file
View File

@ -0,0 +1,55 @@
index_outside_sample_mask_range.frag
ERROR: 0:6: '[' : gl_SampleMask array index out of range '1'
ERROR: 1 compilation errors. No code generated.
Shader version: 320
ERROR: node is still EOpNull!
0:3 Function Definition: main( ( global void)
0:3 Function Parameters:
0:? Sequence
0:6 Sequence
0:6 move second child to first child ( temp highp int)
0:6 'invalidValue' ( temp highp int)
0:6 direct index ( temp highp int SampleMaskIn)
0:6 'gl_SampleMask' ( out unsized 2-element array of highp int SampleMaskIn)
0:6 Constant:
0:6 1 (const int)
0:7 move second child to first child ( temp mediump 4-component vector of float)
0:7 'fs_color' (layout( location=0) out mediump 4-component vector of float)
0:7 Constant:
0:7 1.000000
0:7 0.000000
0:7 0.000000
0:7 1.000000
0:? Linker Objects
0:? 'fs_color' (layout( location=0) out mediump 4-component vector of float)
0:? 'gl_SampleMask' ( out unsized 2-element array of highp int SampleMaskIn)
Linked fragment stage:
Shader version: 320
ERROR: node is still EOpNull!
0:3 Function Definition: main( ( global void)
0:3 Function Parameters:
0:? Sequence
0:6 Sequence
0:6 move second child to first child ( temp highp int)
0:6 'invalidValue' ( temp highp int)
0:6 direct index ( temp highp int SampleMaskIn)
0:6 'gl_SampleMask' ( out 2-element array of highp int SampleMaskIn)
0:6 Constant:
0:6 1 (const int)
0:7 move second child to first child ( temp mediump 4-component vector of float)
0:7 'fs_color' (layout( location=0) out mediump 4-component vector of float)
0:7 Constant:
0:7 1.000000
0:7 0.000000
0:7 0.000000
0:7 1.000000
0:? Linker Objects
0:? 'fs_color' (layout( location=0) out mediump 4-component vector of float)
0:? 'gl_SampleMask' ( out 2-element array of highp int SampleMaskIn)

8
Test/index_outside_sample_mask_range.frag Normal file
View File

@ -0,0 +1,8 @@
#version 320 es
layout (location = 0) out mediump vec4 fs_color;
void main()
{
const highp int invalidIndex = (gl_MaxSamples + 31) / 32;
highp int invalidValue = gl_SampleMask[invalidIndex];
fs_color = vec4(1.0f, 0.0f, 0.0f, 1.0f);
}

4
glslang/MachineIndependent/ParseHelper.cpp
View File

@ -598,6 +598,10 @@ TIntermTyped* TParseContext::handleBracketDereference(const TSourceLoc& loc, TIn
indexValue >= resources.maxCullDistances) { indexValue >= resources.maxCullDistances) {
error(loc, "gl_CullDistance", "[", "array index out of range '%d'", indexValue); error(loc, "gl_CullDistance", "[", "array index out of range '%d'", indexValue);
} }
else if (base->getQualifier().builtIn == EbvSampleMask &&
indexValue >= (resources.maxSamples + 31) / 32) {
error(loc, "gl_SampleMask", "[", "array index out of range '%d'", indexValue);
}
// For 2D per-view builtin arrays, update the inner dimension size in parent type // For 2D per-view builtin arrays, update the inner dimension size in parent type
if (base->getQualifier().isPerView() && base->getQualifier().builtIn != EbvNone) { if (base->getQualifier().isPerView() && base->getQualifier().builtIn != EbvNone) {
TIntermBinary* binaryNode = base->getAsBinaryNode(); TIntermBinary* binaryNode = base->getAsBinaryNode();

1
gtests/AST.FromFile.cpp
View File

@ -309,6 +309,7 @@ INSTANTIATE_TEST_SUITE_P(
"GL_EXT_draw_instanced.vert", "GL_EXT_draw_instanced.vert",
"overflow_underflow_toinf_0.frag", "overflow_underflow_toinf_0.frag",
"GL_EXT_texture_array.frag", "GL_EXT_texture_array.frag",
"index_outside_sample_mask_range.frag",
"positive_infinity.frag", "positive_infinity.frag",
})), })),
FileNameAsCustomTestSuffix FileNameAsCustomTestSuffix