AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-11-19 01:40:10 +00:00
Code Issues Projects Releases Wiki Activity

GtkTreeView: Remove a no-longer-valid optimization

Browse Source 
The rubberband rendering code was assuming that we just have
a 1-pixel border and the rest of the rubberband is uniform.
That is not a safe assumption to make with css-styled
rubberbands, so remove it.
This commit is contained in:
Matthias Clasen 2014-06-19 13:51:25 -04:00
parent 72ece5a62c
commit 0056d3a6ad
1 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
gtk/gtktreeview.c
View File

@ -4553,7 +4553,6 @@ gtk_tree_view_update_rubber_band (GtkTreeView *tree_view)
gdouble start_x, start_y, offset_x, offset_y, x, y;
GdkRectangle old_area;
GdkRectangle new_area;
GdkRectangle common;
cairo_region_t *invalid_region;
gint bin_x, bin_y;
@ -4584,23 +4583,6 @@ gtk_tree_view_update_rubber_band (GtkTreeView *tree_view)
invalid_region = cairo_region_create_rectangle (&old_area);
cairo_region_union_rectangle (invalid_region, &new_area);
gdk_rectangle_intersect (&old_area, &new_area, &common);
if (common.width > 2 && common.height > 2)
{
cairo_region_t *common_region;
/* make sure the border is invalidated */
common.x += 1;
common.y += 1;
common.width -= 2;
common.height -= 2;
common_region = cairo_region_create_rectangle (&common);
cairo_region_subtract (invalid_region, common_region);
cairo_region_destroy (common_region);
}
gdk_window_invalidate_region (tree_view->priv->bin_window, invalid_region, TRUE);
cairo_region_destroy (invalid_region);