From 08f58122d1ebeab7bc1be2e0c7f4a612f05d250d Mon Sep 17 00:00:00 2001
From: Matthias Clasen <mclasen@redhat.com>
Date: Mon, 24 Aug 2020 11:38:00 -0400
Subject: [PATCH] Add a reftest for grid layouts

This tests that invisible children don't influence
the layout.
---
 .../gridlayout-invisible-child.ref.ui         | 28 +++++++++++++
 .../reftests/gridlayout-invisible-child.ui    | 39 +++++++++++++++++++
 testsuite/reftests/meson.build                |  2 +
 3 files changed, 69 insertions(+)
 create mode 100644 testsuite/reftests/gridlayout-invisible-child.ref.ui
 create mode 100644 testsuite/reftests/gridlayout-invisible-child.ui

diff --git a/testsuite/reftests/gridlayout-invisible-child.ref.ui b/testsuite/reftests/gridlayout-invisible-child.ref.ui
new file mode 100644
index 0000000000..ad64be95bc
--- /dev/null
+++ b/testsuite/reftests/gridlayout-invisible-child.ref.ui
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<interface>
+  <object class="GtkWindow" id="window_information_collection">
+    <property name="decorated">0</property>
+    <child>
+      <object class="GtkGrid" id="grid1">
+        <child>
+          <object class="GtkLabel" id="label1">
+            <property name="label" translatable="yes">Hello</property>
+            <layout>
+              <property name="row">0</property>
+              <property name="column">0</property>
+            </layout>
+          </object>
+        </child>
+        <child>
+          <object class="GtkLabel" id="label3">
+            <property name="label" translatable="yes">World</property>
+            <layout>
+              <property name="row">0</property>
+              <property name="column">2</property>
+            </layout>
+          </object>
+        </child>
+      </object>
+    </child>
+  </object>
+</interface>
diff --git a/testsuite/reftests/gridlayout-invisible-child.ui b/testsuite/reftests/gridlayout-invisible-child.ui
new file mode 100644
index 0000000000..eeebd7abb2
--- /dev/null
+++ b/testsuite/reftests/gridlayout-invisible-child.ui
@@ -0,0 +1,39 @@
+<!-- check that an invisible child does not influence the layout -->
+<?xml version="1.0" encoding="UTF-8"?>
+<interface>
+  <object class="GtkWindow" id="window_information_collection">
+    <property name="decorated">0</property>
+    <child>
+      <object class="GtkGrid" id="grid1">
+        <child>
+          <object class="GtkLabel" id="label1">
+            <property name="label" translatable="yes">Hello</property>
+            <layout>
+              <property name="row">0</property>
+              <property name="column">0</property>
+            </layout>
+          </object>
+        </child>
+        <child>
+          <object class="GtkLabel" id="label2">
+            <property name="visible">0</property>
+            <property name="label" translatable="yes">cruel</property>
+            <layout>
+              <property name="row">0</property>
+              <property name="column">1</property>
+            </layout>
+          </object>
+        </child>
+        <child>
+          <object class="GtkLabel" id="label3">
+            <property name="label" translatable="yes">World</property>
+            <layout>
+              <property name="row">0</property>
+              <property name="column">2</property>
+            </layout>
+          </object>
+        </child>
+      </object>
+    </child>
+  </object>
+</interface>
diff --git a/testsuite/reftests/meson.build b/testsuite/reftests/meson.build
index 001baa6fb6..a6a5210a77 100644
--- a/testsuite/reftests/meson.build
+++ b/testsuite/reftests/meson.build
@@ -229,6 +229,8 @@ testdata = [
   'gradient-hard-stop.ref.ui',
   'gradient-hard-stop.ui',
   'green-20x20.png',
+  'gridlayout-invisible-child.ref.ui',
+  'gridlayout-invisible-child.ui',
   'grid-empty-with-spacing.ref.ui',
   'grid-empty-with-spacing.ui',
   'grid-expand.css',