AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-11-14 04:31:09 +00:00
Code Issues Projects Releases Wiki Activity

a11y: Don't emit children-changed when nothing changed

Browse Source 
When we have 0 columns, no children ever get added or removed.
This commit is contained in:
Benjamin Otte 2011-12-16 12:57:06 +01:00
parent d78971b31d
commit 113aff673f
1 changed files with 20 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
gtk/a11y/gtktreeviewaccessible.c
View File

@ -1881,10 +1881,13 @@ _gtk_tree_view_accessible_add (GtkTreeView *treeview,
g_signal_emit_by_name (accessible, "row-inserted", row, n_rows); g_signal_emit_by_name (accessible, "row-inserted", row, n_rows);
n_cols = get_n_columns (treeview); n_cols = get_n_columns (treeview);
for (i = (row + 1) * n_cols; i < (row + n_rows + 1) * n_cols; i++) if (n_cols)
{ {
/* Pass NULL as the child object, i.e. 4th argument */ for (i = (row + 1) * n_cols; i < (row + n_rows + 1) * n_cols; i++)
g_signal_emit_by_name (accessible, "children-changed::add", i, NULL, NULL); {
/* Pass NULL as the child object, i.e. 4th argument */
g_signal_emit_by_name (accessible, "children-changed::add", i, NULL, NULL);
}
} }
} }
@ -1920,19 +1923,22 @@ _gtk_tree_view_accessible_remove (GtkTreeView *treeview,
g_signal_emit_by_name (accessible, "row-deleted", row, n_rows); g_signal_emit_by_name (accessible, "row-deleted", row, n_rows);
n_cols = get_n_columns (treeview); n_cols = get_n_columns (treeview);
for (i = (n_rows + row + 1) * n_cols - 1; i >= (row + 1) * n_cols; i--) if (n_cols)
{ {
/* Pass NULL as the child object, i.e. 4th argument */ for (i = (n_rows + row + 1) * n_cols - 1; i >= (row + 1) * n_cols; i--)
g_signal_emit_by_name (accessible, "children-changed::remove", i, NULL, NULL); {
} /* Pass NULL as the child object, i.e. 4th argument */
g_signal_emit_by_name (accessible, "children-changed::remove", i, NULL, NULL);
}
g_hash_table_iter_init (&iter, accessible->cell_infos); g_hash_table_iter_init (&iter, accessible->cell_infos);
while (g_hash_table_iter_next (&iter, NULL, (gpointer *)&cell_info)) while (g_hash_table_iter_next (&iter, NULL, (gpointer *)&cell_info))
{ {
if (node == cell_info->node || if (node == cell_info->node ||
tree == cell_info->tree || tree == cell_info->tree ||
(tree && _gtk_rbtree_contains (tree, cell_info->tree))) (tree && _gtk_rbtree_contains (tree, cell_info->tree)))
g_hash_table_iter_remove (&iter); g_hash_table_iter_remove (&iter);
}
} }
} }