AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-12-30 15:31:34 +00:00
Code Issues Projects Releases Wiki Activity

gtk/window: Only fake motion events on windows with pending allocations

Browse Source 
This fixes an issue where the focus of the window continuously received
fake motion events even when a popover was open, making input events end
up behind the popover.

It also adds a comment describing why motion events are requested. Note
that popovers won't work with this, and it's possible both in the past
and now that sporadic missplaced motion events will appear, e.g. when a
window changes allocation but a popover is open.
This commit is contained in:
Jonas Ådahl 2020-12-03 22:50:31 +01:00
parent 6ee7535af0
commit 19d2a4ab94
1 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
gtk/gtkwindow.c
View File

@ -1894,7 +1894,6 @@ gtk_window_native_layout (GtkNative *native,
GtkWindow *window = GTK_WINDOW (native);
GtkWindowPrivate *priv = gtk_window_get_instance_private (window);
GtkWidget *widget = GTK_WIDGET (native);
GdkSeat *seat;
if (priv->surface_width != width || priv->surface_height != height)
{
@ -1903,21 +1902,30 @@ gtk_window_native_layout (GtkNative *native,
priv->surface_height = height;
}
seat = gdk_display_get_default_seat (gtk_widget_get_display (widget));
if (seat)
/* This fake motion event is needed for getting up to date pointer focus
* and coordinates when tho pointer didn't move but the layout changed
* within the window.
*/
if (gtk_widget_needs_allocate (widget))
{
GdkDevice *device;
GtkWidget *focus;
GdkSeat *seat;
device = gdk_seat_get_pointer (seat);
focus = gtk_window_lookup_pointer_focus_widget (GTK_WINDOW (widget),
device, NULL);
if (focus)
seat = gdk_display_get_default_seat (gtk_widget_get_display (widget));
if (seat)
{
GdkSurface *focus_surface =
gtk_native_get_surface (gtk_widget_get_native (focus));
GdkDevice *device;
GtkWidget *focus;
gdk_surface_request_motion (focus_surface);
device = gdk_seat_get_pointer (seat);
focus = gtk_window_lookup_pointer_focus_widget (GTK_WINDOW (widget),
device, NULL);
if (focus)
{
GdkSurface *focus_surface =
gtk_native_get_surface (gtk_widget_get_native (focus));
gdk_surface_request_motion (focus_surface);
}
}
}