Range: Up should only mean ++ if we are a GtkScale

The last round of patches to get the desired direction of value move in
response to scrolls/keypresses on scales had the inadvertent side effect
of giving the opposite direction on scrollbars. Seeing as gtkrange.c is
already a collection of hacks, add another so that fix only holds if the
instance is a GtkScale, since that is what those patches were aimed at.

Close https://gitlab.gnome.org/GNOME/gtk/issues/1065
This commit is contained in:
Daniel Boles 2018-05-21 19:42:57 +01:00
parent 33b8f087a3
commit 19ed1b92b0

View File

@ -704,8 +704,8 @@ should_invert_move (GtkRange *range,
if (move_orientation == priv->orientation)
return should_invert (range);
/* H range/V move: Always invert, so down/up always dec/increase the value */
if (priv->orientation == GTK_ORIENTATION_HORIZONTAL)
/* H scale/V move: Always invert, so down/up always dec/increase the value */
if (priv->orientation == GTK_ORIENTATION_HORIZONTAL && GTK_IS_SCALE (range))
return TRUE;
/* V range/H move: Left/right always dec/increase the value */