From 1afca5510a9db4f7b4cb6a844b237f072b209b08 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Thu, 2 May 2013 20:00:49 -0400 Subject: [PATCH] Prevent a segfault if GtkAppChooserDialog gets disposed early If the async call is finished after the dialog is already disposed, bad things happen. Prevent that by marking the dialog as dismissed in this case. --- gtk/gtkappchooserdialog.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gtk/gtkappchooserdialog.c b/gtk/gtkappchooserdialog.c index e55eac33e7..ce7cfeed57 100644 --- a/gtk/gtkappchooserdialog.c +++ b/gtk/gtkappchooserdialog.c @@ -536,6 +536,8 @@ gtk_app_chooser_dialog_dispose (GObject *object) cancel_and_clear_cancellable (self); g_clear_object (&self->priv->online); + self->priv->dismissed = TRUE; + G_OBJECT_CLASS (gtk_app_chooser_dialog_parent_class)->dispose (object); }